From fjiang at openjdk.java.net  Wed Apr  6 05:58:59 2022
From: fjiang at openjdk.java.net (Feilong Jiang)
Date: Wed, 6 Apr 2022 05:58:59 GMT
Subject: RFR: 7903138: os.simpleArch is x64 for linux-riscv64 in @require
 context [v3]
In-Reply-To: <PIm_0ANkSQ1-x_LHpJGlg_55b8XUDM47uCUdfXm_IU4=.7777d967-65b6-4308-9813-591c2c49f715@github.com>
References: <eiC8QuVInYOP6q9IDsakQGTfY3p5efP2OQTwKuc3VV0=.871e27a7-cd2d-4963-8310-cd4527d55a57@github.com>
 <PIm_0ANkSQ1-x_LHpJGlg_55b8XUDM47uCUdfXm_IU4=.7777d967-65b6-4308-9813-591c2c49f715@github.com>
Message-ID: <K0-JljVba7hgyaZzQvem9J15G0ifa50eO5CBGyooxKs=.432ef118-0d09-4495-8cb6-06ef25336587@github.com>

On Wed, 30 Mar 2022 08:10:46 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

>> RISC-V Port has been integrated into JDK mainline recently ([JDK-8276799](https://bugs.openjdk.java.net/browse/JDK-8276799)). Set simpleArch to riscv64 when os.arch is riscv64
>> 
>> Tested on  Linux riscv64. With the patch, [test/hotspot/jtreg/compiler/vectorapi/TestMaskedMacroLogicVector.java](https://github.com/openjdk/jdk/blob/jdk-19%2B13/test/hotspot/jtreg/compiler/vectorapi/TestMaskedMacroLogicVector.java) was successfully skipped.
>
> Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove riscv in comment

Could someone take a look please?

-------------

PR: https://git.openjdk.java.net/jtreg/pull/66

From jjg at openjdk.java.net  Wed Apr  6 19:19:00 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Wed, 6 Apr 2022 19:19:00 GMT
Subject: RFR: 7903097: jtreg could implement ToolProvider [v6]
In-Reply-To: <eaKglA4EQM5b_2KYO28IApYiWDBOwld-3DEFZiZYtLU=.689aa487-aa6f-4b2b-b7ad-ac4f3a697f9d@github.com>
References: <g1_TigHY7r1defLWrknrBZPpkSki-ylnVLRmX6EAlN0=.16147a1c-5b77-4511-a346-94dab75f2763@github.com>
 <eaKglA4EQM5b_2KYO28IApYiWDBOwld-3DEFZiZYtLU=.689aa487-aa6f-4b2b-b7ad-ac4f3a697f9d@github.com>
Message-ID: <BZZqVMrLYM_dUybEnngZD0KptjYf2rBCAM6bESLeJw0=.8d00a875-4ff9-4e4e-8b77-05842d4ea217@github.com>

On Tue, 15 Feb 2022 06:42:11 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Implement `ToolProvider`, now that the main `jtreg` tool requires JDK >= 9.
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix indentation
>   
>   [skip actions]

Changes requested by jjg (Lead).

make/jtreg.gmk line 85:

> 83: RESOURCES.com.sun.javatest.regtest = \
> 84: 	$(CLASSDIR)/META-INF/services/java.util.spi.ToolProvider \
> 85: 	$(CLASSDIR)/com/sun/javatest/regtest/i18n.properties \

This line is causing your conflict. It was recently removed, in 163ae22 `7903105: remove jtreg Ant task`

-------------

PR: https://git.openjdk.java.net/jtreg/pull/54

From jjg at openjdk.java.net  Wed Apr  6 21:07:35 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Wed, 6 Apr 2022 21:07:35 GMT
Subject: RFR: CODETOOLS-7903143: jtreg includes `-javaoption` values in rerun
 section for @compile tasks in agentvm mode.
Message-ID: <zfmYjE860EJrBPS66hzhTe8URDStCNlR0DmDiVhLkm4=.7d2d6acf-848f-4a81-9bd2-af5b23f65319@github.com>

Please review a trivial code fix and corresponding bug fix, to address the issue that jtreg incorrectly reports inapplicable options in the rerun info for a `@compile` section.

Background, values for the `-javaoption` should only be applied when running tests (@run main, etc) and not when compiling tests (@compile, @build).   That is true when the test is executed, but not true when generating the `rerun` script.
For `othervm` it's not an issue, because the `rerun` script is more directly derived from the command that is executed, but for `agentvm` the rerun info is just a synthesized approximation.

-------------

Commit messages:
 - CODETOOLS-7903143: jtreg includes `-javaoption` values in rerun section for @compile tasks in agentvm mode.

Changes: https://git.openjdk.java.net/jtreg/pull/67/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=67&range=00
  Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903143
  Stats: 8 lines in 8 files changed: 0 ins; 7 del; 1 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/67.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/67/head:pull/67

PR: https://git.openjdk.java.net/jtreg/pull/67

From iris at openjdk.java.net  Wed Apr  6 21:54:59 2022
From: iris at openjdk.java.net (Iris Clark)
Date: Wed, 6 Apr 2022 21:54:59 GMT
Subject: RFR: CODETOOLS-7903143: jtreg includes `-javaoption` values in
 rerun section for @compile tasks in agentvm mode.
In-Reply-To: <zfmYjE860EJrBPS66hzhTe8URDStCNlR0DmDiVhLkm4=.7d2d6acf-848f-4a81-9bd2-af5b23f65319@github.com>
References: <zfmYjE860EJrBPS66hzhTe8URDStCNlR0DmDiVhLkm4=.7d2d6acf-848f-4a81-9bd2-af5b23f65319@github.com>
Message-ID: <5gLTMd8801Ofh2R-X5Dl3_JYcOQePj6ZCkSFj6PWUQI=.cba985da-d71e-43df-b333-a7d9305dd61e@github.com>

On Wed, 6 Apr 2022 20:59:57 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a trivial code fix and corresponding bug fix, to address the issue that jtreg incorrectly reports inapplicable options in the rerun info for a `@compile` section.
> 
> Background, values for the `-javaoption` should only be applied when running tests (@run main, etc) and not when compiling tests (@compile, @build).   That is true when the test is executed, but not true when generating the `rerun` script.
> For `othervm` it's not an issue, because the `rerun` script is more directly derived from the command that is executed, but for `agentvm` the rerun info is just a synthesized approximation.

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.java.net/jtreg/pull/67

From jjg at openjdk.java.net  Wed Apr  6 23:47:29 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Wed, 6 Apr 2022 23:47:29 GMT
Subject: RFR: CODETOOLS-7903147: unrooted relative paths in checkI18NProps.sh
Message-ID: <lNS2eLtgSiq2bEVfVu5OLMI_I9wYQiRY4vlXEFf0xo4=.f23a1a91-5c8c-4604-9d0c-3dfdfef726e7@github.com>

Please review a reasonably small fix to improve the test that checks localization resources.

Previously, the code created temporary files in the source directory for the script itself.  The script is changed to accept a new leading parameter which is a directory in which to store temporary files.

In addition, the names of the temporary files are made longer and less cryptic.

-------------

Commit messages:
 - fix whitespace
 - CODETOOLS-7903147: unrooted relative paths in checkI18NProps.sh

Changes: https://git.openjdk.java.net/jtreg/pull/68/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=68&range=00
  Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903147
  Stats: 21 lines in 3 files changed: 5 ins; 2 del; 14 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/68.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/68/head:pull/68

PR: https://git.openjdk.java.net/jtreg/pull/68

From iris at openjdk.java.net  Thu Apr  7 00:37:59 2022
From: iris at openjdk.java.net (Iris Clark)
Date: Thu, 7 Apr 2022 00:37:59 GMT
Subject: RFR: CODETOOLS-7903147: unrooted relative paths in
 checkI18NProps.sh
In-Reply-To: <lNS2eLtgSiq2bEVfVu5OLMI_I9wYQiRY4vlXEFf0xo4=.f23a1a91-5c8c-4604-9d0c-3dfdfef726e7@github.com>
References: <lNS2eLtgSiq2bEVfVu5OLMI_I9wYQiRY4vlXEFf0xo4=.f23a1a91-5c8c-4604-9d0c-3dfdfef726e7@github.com>
Message-ID: <AzhXlfv-9MlpjzRdQ4URCAUXAscCuNbiEnLenMt9jMY=.bca8514c-5c5b-4cc3-9fa7-775254a0fac2@github.com>

On Wed, 6 Apr 2022 23:37:11 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a reasonably small fix to improve the test that checks localization resources.
> 
> Previously, the code created temporary files in the source directory for the script itself.  The script is changed to accept a new leading parameter which is a directory in which to store temporary files.
> 
> In addition, the names of the temporary files are made longer and less cryptic.

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.java.net/jtreg/pull/68

From jjg at openjdk.java.net  Thu Apr  7 00:40:52 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Thu, 7 Apr 2022 00:40:52 GMT
Subject: Integrated: CODETOOLS-7903147: unrooted relative paths in
 checkI18NProps.sh
In-Reply-To: <lNS2eLtgSiq2bEVfVu5OLMI_I9wYQiRY4vlXEFf0xo4=.f23a1a91-5c8c-4604-9d0c-3dfdfef726e7@github.com>
References: <lNS2eLtgSiq2bEVfVu5OLMI_I9wYQiRY4vlXEFf0xo4=.f23a1a91-5c8c-4604-9d0c-3dfdfef726e7@github.com>
Message-ID: <p78T15k8bbWVvjxfAWqdyar6yzQDOn-oNUoFLO6s0Z8=.d450e2d6-ccf8-4b61-9373-77cec6581587@github.com>

On Wed, 6 Apr 2022 23:37:11 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a reasonably small fix to improve the test that checks localization resources.
> 
> Previously, the code created temporary files in the source directory for the script itself.  The script is changed to accept a new leading parameter which is a directory in which to store temporary files.
> 
> In addition, the names of the temporary files are made longer and less cryptic.

This pull request has now been integrated.

Changeset: 591466c2
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.java.net/jtreg/commit/591466c2164f2d1019c37c88735055f749194f92
Stats:     21 lines in 3 files changed: 5 ins; 2 del; 14 mod

7903147: unrooted relative paths in checkI18NProps.sh

Reviewed-by: iris

-------------

PR: https://git.openjdk.java.net/jtreg/pull/68

From jjg at openjdk.java.net  Thu Apr  7 00:41:58 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Thu, 7 Apr 2022 00:41:58 GMT
Subject: Integrated: CODETOOLS-7903143: jtreg includes `-javaoption` values in
 rerun section for @compile tasks in agentvm mode.
In-Reply-To: <zfmYjE860EJrBPS66hzhTe8URDStCNlR0DmDiVhLkm4=.7d2d6acf-848f-4a81-9bd2-af5b23f65319@github.com>
References: <zfmYjE860EJrBPS66hzhTe8URDStCNlR0DmDiVhLkm4=.7d2d6acf-848f-4a81-9bd2-af5b23f65319@github.com>
Message-ID: <qqsmlPvJk4MaACfDWpuboUkR3XeNd0ls9WdsYuR6HgA=.bb2a0d23-78bb-4344-9d58-6c7ed557399e@github.com>

On Wed, 6 Apr 2022 20:59:57 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a trivial code fix and corresponding bug fix, to address the issue that jtreg incorrectly reports inapplicable options in the rerun info for a `@compile` section.
> 
> Background, values for the `-javaoption` should only be applied when running tests (@run main, etc) and not when compiling tests (@compile, @build).   That is true when the test is executed, but not true when generating the `rerun` script.
> For `othervm` it's not an issue, because the `rerun` script is more directly derived from the command that is executed, but for `agentvm` the rerun info is just a synthesized approximation.

This pull request has now been integrated.

Changeset: cdcd462f
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.java.net/jtreg/commit/cdcd462ffef177966823154474e46bae0b9d25e5
Stats:     8 lines in 8 files changed: 0 ins; 7 del; 1 mod

7903143: jtreg includes `-javaoption` values in rerun section for @compile tasks in agentvm mode.

Reviewed-by: iris

-------------

PR: https://git.openjdk.java.net/jtreg/pull/67

From cstein at openjdk.java.net  Thu Apr  7 14:52:24 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 7 Apr 2022 14:52:24 GMT
Subject: RFR: 7903097: jtreg could implement ToolProvider [v7]
In-Reply-To: <g1_TigHY7r1defLWrknrBZPpkSki-ylnVLRmX6EAlN0=.16147a1c-5b77-4511-a346-94dab75f2763@github.com>
References: <g1_TigHY7r1defLWrknrBZPpkSki-ylnVLRmX6EAlN0=.16147a1c-5b77-4511-a346-94dab75f2763@github.com>
Message-ID: <8JoGmoXf_onduBENC08O8xtBAX0ZlxteUCk0yV8lqi4=.3f3b3f65-b188-408a-8113-39c3a4efe265@github.com>

> Implement `ToolProvider`, now that the main `jtreg` tool requires JDK >= 9.

Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:

 - Merge branch 'master' into 7903097-implement-toolprovider
 - Fix indentation
   
   [skip actions]
 - Fix java source launcher call
 - Apply suggested changes
 - Prevent non-zero exit code by using supported option
 - Move `ToolProvider`-related test into a dedicated folder
 - Update more expected numbers
 - Expect another passing test
 - Re-use I18N messages by moving `JtregToolProvider` to `tool` package
 - Add rule to copy service-related resource files
 - ... and 1 more: https://git.openjdk.java.net/jtreg/compare/cdcd462f...49c11b09

-------------

Changes: https://git.openjdk.java.net/jtreg/pull/54/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=54&range=06
  Stats: 156 lines in 6 files changed: 155 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/54.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/54/head:pull/54

PR: https://git.openjdk.java.net/jtreg/pull/54

From cstein at openjdk.java.net  Thu Apr  7 14:52:24 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 7 Apr 2022 14:52:24 GMT
Subject: RFR: 7903097: jtreg could implement ToolProvider [v6]
In-Reply-To: <BZZqVMrLYM_dUybEnngZD0KptjYf2rBCAM6bESLeJw0=.8d00a875-4ff9-4e4e-8b77-05842d4ea217@github.com>
References: <g1_TigHY7r1defLWrknrBZPpkSki-ylnVLRmX6EAlN0=.16147a1c-5b77-4511-a346-94dab75f2763@github.com>
 <eaKglA4EQM5b_2KYO28IApYiWDBOwld-3DEFZiZYtLU=.689aa487-aa6f-4b2b-b7ad-ac4f3a697f9d@github.com>
 <BZZqVMrLYM_dUybEnngZD0KptjYf2rBCAM6bESLeJw0=.8d00a875-4ff9-4e4e-8b77-05842d4ea217@github.com>
Message-ID: <b5gzAqLbKgSF2LM3xCTqFZL1qh7vM66amymcrPj8VnY=.5ab72a3f-7974-4ed4-97f2-fa6857d86bbf@github.com>

On Wed, 6 Apr 2022 19:13:24 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix indentation
>>   
>>   [skip actions]
>
> make/jtreg.gmk line 85:
> 
>> 83: RESOURCES.com.sun.javatest.regtest = \
>> 84: 	$(CLASSDIR)/META-INF/services/java.util.spi.ToolProvider \
>> 85: 	$(CLASSDIR)/com/sun/javatest/regtest/i18n.properties \
> 
> This line is causing your conflict. It was recently removed, in 163ae22 `7903105: remove jtreg Ant task`

Understood. Resolving conflict via UI...

-------------

PR: https://git.openjdk.java.net/jtreg/pull/54

From cstein at openjdk.java.net  Thu Apr  7 14:52:25 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 7 Apr 2022 14:52:25 GMT
Subject: RFR: 7903097: jtreg could implement ToolProvider [v6]
In-Reply-To: <b5gzAqLbKgSF2LM3xCTqFZL1qh7vM66amymcrPj8VnY=.5ab72a3f-7974-4ed4-97f2-fa6857d86bbf@github.com>
References: <g1_TigHY7r1defLWrknrBZPpkSki-ylnVLRmX6EAlN0=.16147a1c-5b77-4511-a346-94dab75f2763@github.com>
 <eaKglA4EQM5b_2KYO28IApYiWDBOwld-3DEFZiZYtLU=.689aa487-aa6f-4b2b-b7ad-ac4f3a697f9d@github.com>
 <BZZqVMrLYM_dUybEnngZD0KptjYf2rBCAM6bESLeJw0=.8d00a875-4ff9-4e4e-8b77-05842d4ea217@github.com>
 <b5gzAqLbKgSF2LM3xCTqFZL1qh7vM66amymcrPj8VnY=.5ab72a3f-7974-4ed4-97f2-fa6857d86bbf@github.com>
Message-ID: <t_5UCkTY_2lzMMCZCIae_x5WndQYl9kv0rgdrT-MMRM=.ae284671-7c8c-4303-bc13-1db29d6e191c@github.com>

On Thu, 7 Apr 2022 14:47:07 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> make/jtreg.gmk line 85:
>> 
>>> 83: RESOURCES.com.sun.javatest.regtest = \
>>> 84: 	$(CLASSDIR)/META-INF/services/java.util.spi.ToolProvider \
>>> 85: 	$(CLASSDIR)/com/sun/javatest/regtest/i18n.properties \
>> 
>> This line is causing your conflict. It was recently removed, in 163ae22 `7903105: remove jtreg Ant task`
>
> Understood. Resolving conflict via UI...

Resolved via https://github.com/openjdk/jtreg/pull/54/commits/49c11b09de75ac9ef281722a272020fd188a80fe

-------------

PR: https://git.openjdk.java.net/jtreg/pull/54

From cstein at openjdk.java.net  Thu Apr  7 15:01:44 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 7 Apr 2022 15:01:44 GMT
Subject: RFR: 7903055: Replace `junit.jar` with
 `junit-platform-console-standalone` artifact [v3]
In-Reply-To: <46UymgO92_HIuaimbMUGDI1SPGOKg3pP4jn4IduDcZE=.e056aac8-018b-459a-b61b-00b7b649ea86@github.com>
References: <46UymgO92_HIuaimbMUGDI1SPGOKg3pP4jn4IduDcZE=.e056aac8-018b-459a-b61b-00b7b649ea86@github.com>
Message-ID: <43R6rxzujXm2xVBPrT1ss74QySr5azSyS5aS6qytzI4=.51604afb-77c5-4e65-867c-06a0cb2cee84@github.com>

> https://bugs.openjdk.java.net/browse/CODETOOLS-7903055

Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'openjdk:master' into 7903055-junit5
 - Retain full base name of the JAR file
 - Restore updated comment
 - Replace `junit.jar` with `junit-platform-console-standalone` artifact
   
   https://bugs.openjdk.java.net/browse/CODETOOLS-7903055

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/63/files
  - new: https://git.openjdk.java.net/jtreg/pull/63/files/93a391a5..fc40e4c9

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=63&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=63&range=01-02

  Stats: 37 lines in 12 files changed: 5 ins; 9 del; 23 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/63.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/63/head:pull/63

PR: https://git.openjdk.java.net/jtreg/pull/63

From jjg at openjdk.java.net  Thu Apr  7 15:33:04 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Thu, 7 Apr 2022 15:33:04 GMT
Subject: RFR: 7903097: jtreg could implement ToolProvider [v7]
In-Reply-To: <8JoGmoXf_onduBENC08O8xtBAX0ZlxteUCk0yV8lqi4=.3f3b3f65-b188-408a-8113-39c3a4efe265@github.com>
References: <g1_TigHY7r1defLWrknrBZPpkSki-ylnVLRmX6EAlN0=.16147a1c-5b77-4511-a346-94dab75f2763@github.com>
 <8JoGmoXf_onduBENC08O8xtBAX0ZlxteUCk0yV8lqi4=.3f3b3f65-b188-408a-8113-39c3a4efe265@github.com>
Message-ID: <_-04MZFuWOvSRvmoe5jj3kHt3FIsPi9YWvc7AzKIu1c=.aee44baa-629d-4799-b758-23284b9f4ea2@github.com>

On Thu, 7 Apr 2022 14:52:24 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Implement `ToolProvider`, now that the main `jtreg` tool requires JDK >= 9.
>
> Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
> 
>  - Merge branch 'master' into 7903097-implement-toolprovider
>  - Fix indentation
>    
>    [skip actions]
>  - Fix java source launcher call
>  - Apply suggested changes
>  - Prevent non-zero exit code by using supported option
>  - Move `ToolProvider`-related test into a dedicated folder
>  - Update more expected numbers
>  - Expect another passing test
>  - Re-use I18N messages by moving `JtregToolProvider` to `tool` package
>  - Add rule to copy service-related resource files
>  - ... and 1 more: https://git.openjdk.java.net/jtreg/compare/cdcd462f...49c11b09

Marked as reviewed by jjg (Lead).

src/share/classes/com/sun/javatest/regtest/tool/JtregToolProvider.java line 43:

> 41: 
> 42:     @Override
> 43:     public int run(PrintWriter out, PrintWriter err, String... args) {

OK for now, but at some point we should merge this with Tool.main

-------------

PR: https://git.openjdk.java.net/jtreg/pull/54

From cstein at openjdk.java.net  Thu Apr  7 15:41:04 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 7 Apr 2022 15:41:04 GMT
Subject: Integrated: 7903097: jtreg could implement ToolProvider
In-Reply-To: <g1_TigHY7r1defLWrknrBZPpkSki-ylnVLRmX6EAlN0=.16147a1c-5b77-4511-a346-94dab75f2763@github.com>
References: <g1_TigHY7r1defLWrknrBZPpkSki-ylnVLRmX6EAlN0=.16147a1c-5b77-4511-a346-94dab75f2763@github.com>
Message-ID: <mxPxooktbXZZ0LoHjwq7EurqiBr1fQdtXxbjWX4lj5k=.0336660c-d2e8-4351-89e8-c4ce4803303f@github.com>

On Fri, 11 Feb 2022 08:24:09 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Implement `ToolProvider`, now that the main `jtreg` tool requires JDK >= 9.

This pull request has now been integrated.

Changeset: 1433968b
Author:    Christian Stein <cstein at openjdk.org>
Committer: Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.java.net/jtreg/commit/1433968b29d65ca7ce340ee11ae2b874132c0527
Stats:     156 lines in 6 files changed: 155 ins; 0 del; 1 mod

7903097: jtreg could implement ToolProvider

Reviewed-by: jjg

-------------

PR: https://git.openjdk.java.net/jtreg/pull/54

From cstein at openjdk.java.net  Thu Apr  7 16:14:53 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 7 Apr 2022 16:14:53 GMT
Subject: RFR: 7903055: Replace `junit.jar` with
 `junit-platform-console-standalone` artifact [v4]
In-Reply-To: <46UymgO92_HIuaimbMUGDI1SPGOKg3pP4jn4IduDcZE=.e056aac8-018b-459a-b61b-00b7b649ea86@github.com>
References: <46UymgO92_HIuaimbMUGDI1SPGOKg3pP4jn4IduDcZE=.e056aac8-018b-459a-b61b-00b7b649ea86@github.com>
Message-ID: <CEUi-SwXeltEXxs0qb4zWRUL4ry32YVxKKMpuNEkm40=.b59c5904-eb21-4121-b83a-75819fed17db@github.com>

> https://bugs.openjdk.java.net/browse/CODETOOLS-7903055

Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge branch 'openjdk:master' into 7903055-junit5
 - Merge branch 'openjdk:master' into 7903055-junit5
 - Retain full base name of the JAR file
 - Restore updated comment
 - Replace `junit.jar` with `junit-platform-console-standalone` artifact
   
   https://bugs.openjdk.java.net/browse/CODETOOLS-7903055

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/63/files
  - new: https://git.openjdk.java.net/jtreg/pull/63/files/fc40e4c9..def5a14d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=63&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=63&range=02-03

  Stats: 156 lines in 6 files changed: 155 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/63.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/63/head:pull/63

PR: https://git.openjdk.java.net/jtreg/pull/63

From jjg at openjdk.java.net  Thu Apr  7 21:45:19 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Thu, 7 Apr 2022 21:45:19 GMT
Subject: RFR: CODETOOLS-7903150: Restructure generated files for jtreg
 self-tests
Message-ID: <3pzT1hegJqZoQB-Y4Q-6AfIS51DrfKLROCgxaL0I2NA=.c749801a-37bb-4cc4-893b-4d803ae5636f@github.com>

Please review a mostly test-only fix to move all the output generated by the many jtreg self-tests into a new $(BUILDDIR)/test subdirectory, defined by a new BUILDTESTDIR variable.

All but two of the edited files are "just" test updates, and most of those were done with search/replace in the IDE. That gave a first pass, with about 90% success rate.  The remaining edits were done by fixing tests up manually, either because they had become broken, or because there were still writing files outside the $(BUILDTESTDIR) directory.

Of the two files that were edited that were not in the main `test` directory, one is in Defs.gmk, to define the new BUILDTESTDIR variable, and the other is in Makefile to add some opportunistic new clean targets.

-------------

Commit messages:
 - CODETOOLS-7903150: Restructure generated files for jtreg self-tests

Changes: https://git.openjdk.java.net/jtreg/pull/69/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=69&range=00
  Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903150
  Stats: 824 lines in 142 files changed: 16 ins; 0 del; 808 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/69.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/69/head:pull/69

PR: https://git.openjdk.java.net/jtreg/pull/69

From jjg at openjdk.java.net  Thu Apr  7 21:53:25 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Thu, 7 Apr 2022 21:53:25 GMT
Subject: RFR: CODETOOLS-7903150: Restructure generated files for jtreg
 self-tests [v2]
In-Reply-To: <3pzT1hegJqZoQB-Y4Q-6AfIS51DrfKLROCgxaL0I2NA=.c749801a-37bb-4cc4-893b-4d803ae5636f@github.com>
References: <3pzT1hegJqZoQB-Y4Q-6AfIS51DrfKLROCgxaL0I2NA=.c749801a-37bb-4cc4-893b-4d803ae5636f@github.com>
Message-ID: <V3l9PKzLCzGX5zyDZbWiEJfnBX5ZyCA-8kHbIq4yiUU=.9549beca-f673-4594-8f62-7c4e6bf8be75@github.com>

> Please review a mostly test-only fix to move all the output generated by the many jtreg self-tests into a new $(BUILDDIR)/test subdirectory, defined by a new BUILDTESTDIR variable.
> 
> All but two of the edited files are "just" test updates, and most of those were done with search/replace in the IDE. That gave a first pass, with about 90% success rate.  The remaining edits were done by fixing tests up manually, either because they had become broken, or because there were still writing files outside the $(BUILDTESTDIR) directory.
> 
> Of the two files that were edited that were not in the main `test` directory, one is in Defs.gmk, to define the new BUILDTESTDIR variable, and the other is in Makefile to add some opportunistic new clean targets.

Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:

  ensure $(BUILDTESTDIR) created

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/69/files
  - new: https://git.openjdk.java.net/jtreg/pull/69/files/1f3bc93e..8fa64e67

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=69&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=69&range=00-01

  Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/69.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/69/head:pull/69

PR: https://git.openjdk.java.net/jtreg/pull/69

From iris at openjdk.java.net  Thu Apr  7 23:15:59 2022
From: iris at openjdk.java.net (Iris Clark)
Date: Thu, 7 Apr 2022 23:15:59 GMT
Subject: RFR: CODETOOLS-7903150: Restructure generated files for jtreg
 self-tests [v2]
In-Reply-To: <V3l9PKzLCzGX5zyDZbWiEJfnBX5ZyCA-8kHbIq4yiUU=.9549beca-f673-4594-8f62-7c4e6bf8be75@github.com>
References: <3pzT1hegJqZoQB-Y4Q-6AfIS51DrfKLROCgxaL0I2NA=.c749801a-37bb-4cc4-893b-4d803ae5636f@github.com>
 <V3l9PKzLCzGX5zyDZbWiEJfnBX5ZyCA-8kHbIq4yiUU=.9549beca-f673-4594-8f62-7c4e6bf8be75@github.com>
Message-ID: <2gTmMxYjc5vWjT_qpOv5LxpQIRVkfg5AQIgW3w3lq4E=.e0bfb6ea-e247-4059-9597-eee4080c5f8a@github.com>

On Thu, 7 Apr 2022 21:53:25 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review a mostly test-only fix to move all the output generated by the many jtreg self-tests into a new $(BUILDDIR)/test subdirectory, defined by a new BUILDTESTDIR variable.
>> 
>> All but two of the edited files are "just" test updates, and most of those were done with search/replace in the IDE. That gave a first pass, with about 90% success rate.  The remaining edits were done by fixing tests up manually, either because they had become broken, or because there were still writing files outside the $(BUILDTESTDIR) directory.
>> 
>> Of the two files that were edited that were not in the main `test` directory, one is in Defs.gmk, to define the new BUILDTESTDIR variable, and the other is in Makefile to add some opportunistic new clean targets.
>
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   ensure $(BUILDTESTDIR) created

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.java.net/jtreg/pull/69

From jjg at openjdk.java.net  Thu Apr  7 23:19:02 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Thu, 7 Apr 2022 23:19:02 GMT
Subject: Integrated: CODETOOLS-7903150: Restructure generated files for jtreg
 self-tests
In-Reply-To: <3pzT1hegJqZoQB-Y4Q-6AfIS51DrfKLROCgxaL0I2NA=.c749801a-37bb-4cc4-893b-4d803ae5636f@github.com>
References: <3pzT1hegJqZoQB-Y4Q-6AfIS51DrfKLROCgxaL0I2NA=.c749801a-37bb-4cc4-893b-4d803ae5636f@github.com>
Message-ID: <9XldLU6pD1gd0JXUSijqvRxQQv8iDtnsP5mIoLv7HIE=.93292cd9-a89a-4239-a4cf-55b4e70bf075@github.com>

On Thu, 7 Apr 2022 21:39:33 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a mostly test-only fix to move all the output generated by the many jtreg self-tests into a new $(BUILDDIR)/test subdirectory, defined by a new BUILDTESTDIR variable.
> 
> All but two of the edited files are "just" test updates, and most of those were done with search/replace in the IDE. That gave a first pass, with about 90% success rate.  The remaining edits were done by fixing tests up manually, either because they had become broken, or because there were still writing files outside the $(BUILDTESTDIR) directory.
> 
> Of the two files that were edited that were not in the main `test` directory, one is in Defs.gmk, to define the new BUILDTESTDIR variable, and the other is in Makefile to add some opportunistic new clean targets.

This pull request has now been integrated.

Changeset: ff5d2b94
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.java.net/jtreg/commit/ff5d2b94627bbfef8942807f66a99336faabf9d5
Stats:     831 lines in 142 files changed: 21 ins; 0 del; 810 mod

7903150: Restructure generated files for jtreg self-tests

Reviewed-by: iris

-------------

PR: https://git.openjdk.java.net/jtreg/pull/69

From mcimadamore at openjdk.java.net  Fri Apr  8 14:32:33 2022
From: mcimadamore at openjdk.java.net (Maurizio Cimadamore)
Date: Fri, 8 Apr 2022 14:32:33 GMT
Subject: RFR: 7903151: NPE when resolving @library from jtreg plugin
Message-ID: <vcbUNDr1V80ggR3Q_ILuXzBoPyyhcZEFLW1KfzpQ3ZU=.8ebc7da8-a801-401f-966b-da79888235ec@github.com>

This pathc fixes a trivial NPE which occurs when the plugin is attempting to resolve an absolute library in a `@library` tag. If no library is found starting from TEST.ROOT, and if TEST.ROOT does not specify any alternate library root, the plugin fails with a NPE, as the code is eagerly trimming the property value "external.lib.roots", which might not exist.

The solution is simple, e.g. check for null before trimming.

-------------

Commit messages:
 - Initial push

Changes: https://git.openjdk.java.net/jtreg/pull/70/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=70&range=00
  Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903151
  Stats: 5 lines in 3 files changed: 2 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/70.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/70/head:pull/70

PR: https://git.openjdk.java.net/jtreg/pull/70

From mcimadamore at openjdk.java.net  Fri Apr  8 14:32:33 2022
From: mcimadamore at openjdk.java.net (Maurizio Cimadamore)
Date: Fri, 8 Apr 2022 14:32:33 GMT
Subject: RFR: 7903151: NPE when resolving @library from jtreg plugin
In-Reply-To: <vcbUNDr1V80ggR3Q_ILuXzBoPyyhcZEFLW1KfzpQ3ZU=.8ebc7da8-a801-401f-966b-da79888235ec@github.com>
References: <vcbUNDr1V80ggR3Q_ILuXzBoPyyhcZEFLW1KfzpQ3ZU=.8ebc7da8-a801-401f-966b-da79888235ec@github.com>
Message-ID: <JZXl28_OHl12KFQvPEVLuGHMPtAIVd4Pnb1maz7-uOA=.fb31c08c-d496-4f61-abbc-f0f59ae1cd6e@github.com>

On Fri, 8 Apr 2022 14:25:21 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> This pathc fixes a trivial NPE which occurs when the plugin is attempting to resolve an absolute library in a `@library` tag. If no library is found starting from TEST.ROOT, and if TEST.ROOT does not specify any alternate library root, the plugin fails with a NPE, as the code is eagerly trimming the property value "external.lib.roots", which might not exist.
> 
> The solution is simple, e.g. check for null before trimming.

plugins/idea/build.gradle line 29:

> 27: // See https://github.com/JetBrains/gradle-intellij-plugin/
> 28: intellij {
> 29:     version = '2021.3.3'

This change to the build was necessary as the 1.0 of the IntelliJ gradle plugin seems to have an issue when working with the latest IntelliJ EAP (which the build downloads so that it can build against it). This problem is documented here:

https://youtrack.jetbrains.com/issue/IDEA-291192

The solution would be to update to plugin version 1.5.2 - but that plugin version still requires an intellij version to be specified manually. I found that by specify the current IntelliJ version as the IntelliJ API we wanna build against, things work just fine, even with the 1.0 plugin.

-------------

PR: https://git.openjdk.java.net/jtreg/pull/70

From jjg at openjdk.java.net  Sat Apr  9 00:22:27 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Sat, 9 Apr 2022 00:22:27 GMT
Subject: RFR: CODETOOLS-7903152: On macOS, avoid using /usr/bin/tidy
Message-ID: <P158O7w6oDWrhkjvhbqLkUmMF3RKXL8xl8KR_Ljv0nA=.22c0e516-53e8-44a9-8383-318b32b1dc43@github.com>

Please review a simple makefile change to search for a better version of `tidy` on macOS than that in /usr/bin/tidy.

For compatibility, there is no change in the behavior on other platforms, although it might be reasonable to eventually extend the search to `/usr/local/bin/tidy` on other platforms if needed.

-------------

Commit messages:
 - CODETOOLS-7903152: On macOS, avoid using /usr/bin/tidy

Changes: https://git.openjdk.java.net/jtreg/pull/71/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=71&range=00
  Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903152
  Stats: 12 lines in 1 file changed: 10 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/71.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/71/head:pull/71

PR: https://git.openjdk.java.net/jtreg/pull/71

From iris at openjdk.java.net  Sat Apr  9 03:48:57 2022
From: iris at openjdk.java.net (Iris Clark)
Date: Sat, 9 Apr 2022 03:48:57 GMT
Subject: RFR: CODETOOLS-7903152: On macOS, avoid using /usr/bin/tidy
In-Reply-To: <P158O7w6oDWrhkjvhbqLkUmMF3RKXL8xl8KR_Ljv0nA=.22c0e516-53e8-44a9-8383-318b32b1dc43@github.com>
References: <P158O7w6oDWrhkjvhbqLkUmMF3RKXL8xl8KR_Ljv0nA=.22c0e516-53e8-44a9-8383-318b32b1dc43@github.com>
Message-ID: <1rNbQuwEx1SGQGdGJmFK7VVTuteXKZpPzhml43NaKN0=.44fcc6de-e214-40b5-bc91-d4d3e0db6c31@github.com>

On Sat, 9 Apr 2022 00:16:21 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple makefile change to search for a better version of `tidy` on macOS than that in /usr/bin/tidy.
> 
> For compatibility, there is no change in the behavior on other platforms, although it might be reasonable to eventually extend the search to `/usr/local/bin/tidy` on other platforms if needed.

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.java.net/jtreg/pull/71

From jjg at openjdk.java.net  Mon Apr 11 23:47:23 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Mon, 11 Apr 2022 23:47:23 GMT
Subject: RFR: CODETOOLS-7903155: replace single use of `rsync` with `cp -R`
Message-ID: <CDAqEuUfKHahzGGpJRs8FbKLrf9Ea-iO0ot_pjBNL_Q=.d0ac919e-7026-4686-b798-1070716f37a4@github.com>

Please review a simple test-only fix to replace the one single use of `rsync` with equivalent  `rm ...` `cp -R`

-------------

Commit messages:
 - CODETOOLS-7903155: replace single use of `rsync` with `cp -R`

Changes: https://git.openjdk.java.net/jtreg/pull/73/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=73&range=00
  Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903155
  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/73.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/73/head:pull/73

PR: https://git.openjdk.java.net/jtreg/pull/73

From jjg at openjdk.java.net  Tue Apr 12 01:41:57 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Tue, 12 Apr 2022 01:41:57 GMT
Subject: Integrated: CODETOOLS-7903152: On macOS, avoid using /usr/bin/tidy
In-Reply-To: <P158O7w6oDWrhkjvhbqLkUmMF3RKXL8xl8KR_Ljv0nA=.22c0e516-53e8-44a9-8383-318b32b1dc43@github.com>
References: <P158O7w6oDWrhkjvhbqLkUmMF3RKXL8xl8KR_Ljv0nA=.22c0e516-53e8-44a9-8383-318b32b1dc43@github.com>
Message-ID: <eH_xPY9Yn1zrXqLyE_wE6RR77_qzajFde2O1fdKO3cs=.6a62b7b7-1309-4c5a-8b2c-191d514b9257@github.com>

On Sat, 9 Apr 2022 00:16:21 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple makefile change to search for a better version of `tidy` on macOS than that in /usr/bin/tidy.
> 
> For compatibility, there is no change in the behavior on other platforms, although it might be reasonable to eventually extend the search to `/usr/local/bin/tidy` on other platforms if needed.

This pull request has now been integrated.

Changeset: 266576ab
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.java.net/jtreg/commit/266576abd759168dafa664a35dded76e827c46f5
Stats:     12 lines in 1 file changed: 10 ins; 0 del; 2 mod

7903152: On macOS, avoid using /usr/bin/tidy

Reviewed-by: iris

-------------

PR: https://git.openjdk.java.net/jtreg/pull/71

From iris at openjdk.java.net  Tue Apr 12 02:27:00 2022
From: iris at openjdk.java.net (Iris Clark)
Date: Tue, 12 Apr 2022 02:27:00 GMT
Subject: RFR: CODETOOLS-7903155: replace single use of `rsync` with `cp -R`
In-Reply-To: <CDAqEuUfKHahzGGpJRs8FbKLrf9Ea-iO0ot_pjBNL_Q=.d0ac919e-7026-4686-b798-1070716f37a4@github.com>
References: <CDAqEuUfKHahzGGpJRs8FbKLrf9Ea-iO0ot_pjBNL_Q=.d0ac919e-7026-4686-b798-1070716f37a4@github.com>
Message-ID: <_XRUau1NiPUrMicSdk5T-hpM-DOGoSVWcElLVY04JAg=.b1e5bbd7-4200-4d17-9b39-65789d4454e2@github.com>

On Mon, 11 Apr 2022 23:40:27 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple test-only fix to replace the one single use of `rsync` with equivalent  `rm ...` `cp -R`

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.java.net/jtreg/pull/73

From jjg at openjdk.java.net  Tue Apr 12 03:19:00 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Tue, 12 Apr 2022 03:19:00 GMT
Subject: Integrated: CODETOOLS-7903155: replace single use of `rsync` with `cp
 -R`
In-Reply-To: <CDAqEuUfKHahzGGpJRs8FbKLrf9Ea-iO0ot_pjBNL_Q=.d0ac919e-7026-4686-b798-1070716f37a4@github.com>
References: <CDAqEuUfKHahzGGpJRs8FbKLrf9Ea-iO0ot_pjBNL_Q=.d0ac919e-7026-4686-b798-1070716f37a4@github.com>
Message-ID: <hCKXC1SYh5SlMdGguhFng8o9vLc_rdT1qQANPgT8dY8=.e4f4052a-0657-4adc-8e93-f7ec9512ac79@github.com>

On Mon, 11 Apr 2022 23:40:27 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple test-only fix to replace the one single use of `rsync` with equivalent  `rm ...` `cp -R`

This pull request has now been integrated.

Changeset: b498d9e0
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.java.net/jtreg/commit/b498d9e06ecbd18131e06672afb71e621f4938e5
Stats:     2 lines in 1 file changed: 1 ins; 0 del; 1 mod

7903155: replace single use of `rsync` with `cp -R`

Reviewed-by: iris

-------------

PR: https://git.openjdk.java.net/jtreg/pull/73

From cstein at openjdk.java.net  Wed Apr 13 19:45:08 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Wed, 13 Apr 2022 19:45:08 GMT
Subject: RFR: 7903159: Make jtreg self-tests run on Windows/Cygwin
Message-ID: <rcF-VwZSIt9e8h1u0D2XVRkp0Xocvk_mf_qz07DvyQo=.3e6d6349-48f7-4e78-a71c-38dea30e28b7@github.com>

Prior to this commit some of `jtreg`'s self-tests failed on Windows/Cygwin systems.

This commit fixes this mainly by adjusting assertions expecting Windows-style paths, `\r\n` line-breaks, and ignoring/normalizing other differences compared to Unix-based systems.

https://bugs.openjdk.java.net/browse/CODETOOLS-7903159

-------------

Commit messages:
 - 7903159: Make jtreg self-tests run on Windows/Cygwin

Changes: https://git.openjdk.java.net/jtreg/pull/74/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=74&range=00
  Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903159
  Stats: 49 lines in 22 files changed: 8 ins; 0 del; 41 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/74.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/74/head:pull/74

PR: https://git.openjdk.java.net/jtreg/pull/74

From cstein at openjdk.java.net  Wed Apr 13 19:55:09 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Wed, 13 Apr 2022 19:55:09 GMT
Subject: RFR: 7903159: Make jtreg self-tests run on Windows/Cygwin [v2]
In-Reply-To: <rcF-VwZSIt9e8h1u0D2XVRkp0Xocvk_mf_qz07DvyQo=.3e6d6349-48f7-4e78-a71c-38dea30e28b7@github.com>
References: <rcF-VwZSIt9e8h1u0D2XVRkp0Xocvk_mf_qz07DvyQo=.3e6d6349-48f7-4e78-a71c-38dea30e28b7@github.com>
Message-ID: <ZrLtkiAEPb2Xh90LKIFslmShcS95XSWKRO6eRwcJXrs=.06eddc7c-fbcd-4e42-8389-172de5ef771c@github.com>

> Prior to this commit some of `jtreg`'s self-tests failed on Windows/Cygwin systems.
> 
> This commit fixes this mainly by adjusting assertions expecting Windows-style paths, `\r\n` line-breaks, and ignoring/normalizing other differences compared to Unix-based systems.
> 
> https://bugs.openjdk.java.net/browse/CODETOOLS-7903159

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Fix typo

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/74/files
  - new: https://git.openjdk.java.net/jtreg/pull/74/files/901be16c..d19e9cc6

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=74&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=74&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/74.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/74/head:pull/74

PR: https://git.openjdk.java.net/jtreg/pull/74

From jjg at openjdk.java.net  Wed Apr 13 21:31:37 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Wed, 13 Apr 2022 21:31:37 GMT
Subject: RFR: 7903159: Make jtreg self-tests run on Windows/Cygwin [v2]
In-Reply-To: <ZrLtkiAEPb2Xh90LKIFslmShcS95XSWKRO6eRwcJXrs=.06eddc7c-fbcd-4e42-8389-172de5ef771c@github.com>
References: <rcF-VwZSIt9e8h1u0D2XVRkp0Xocvk_mf_qz07DvyQo=.3e6d6349-48f7-4e78-a71c-38dea30e28b7@github.com>
 <ZrLtkiAEPb2Xh90LKIFslmShcS95XSWKRO6eRwcJXrs=.06eddc7c-fbcd-4e42-8389-172de5ef771c@github.com>
Message-ID: <fQU_jlqsi5B7--sl7aljou3M6-RR2e98dVs3ak97rWQ=.f2b0e945-3996-44c8-8d2b-4eb8d78b03c2@github.com>

On Wed, 13 Apr 2022 19:55:09 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Prior to this commit some of `jtreg`'s self-tests failed on Windows/Cygwin systems.
>> 
>> This commit fixes this mainly by adjusting assertions expecting Windows-style paths, `\r\n` line-breaks, and ignoring/normalizing other differences compared to Unix-based systems.
>> 
>> https://bugs.openjdk.java.net/browse/CODETOOLS-7903159
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix typo

Good work.

There's more than one way to solve most of these (annoying) problems/differences, and we might want to tweak the style as we figure out more appropriate solutions.  But for now, this establishes a good baseline.

test/nativepath/NativesOK.java line 36:

> 34:         String j_l_path = System.getProperty("java.library.path");
> 35:         String t_native = System.getProperty("test.nativepath");
> 36:         String c_native = System.getProperty("correct.nativepath").replace("/", File.separator);

the name "correct.nativepath" is slightly off, since it needs to be fixed up, but well, ... it works!

-------------

Marked as reviewed by jjg (Lead).

PR: https://git.openjdk.java.net/jtreg/pull/74

From jjg at openjdk.java.net  Wed Apr 13 23:03:42 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Wed, 13 Apr 2022 23:03:42 GMT
Subject: RFR: 7903159: Make jtreg self-tests run on Windows/Cygwin [v2]
In-Reply-To: <ZrLtkiAEPb2Xh90LKIFslmShcS95XSWKRO6eRwcJXrs=.06eddc7c-fbcd-4e42-8389-172de5ef771c@github.com>
References: <rcF-VwZSIt9e8h1u0D2XVRkp0Xocvk_mf_qz07DvyQo=.3e6d6349-48f7-4e78-a71c-38dea30e28b7@github.com>
 <ZrLtkiAEPb2Xh90LKIFslmShcS95XSWKRO6eRwcJXrs=.06eddc7c-fbcd-4e42-8389-172de5ef771c@github.com>
Message-ID: <_fa-2kAT2XaJne8go9b_rrnlEWHVkxSAVe_g2IzU_F0=.48816270-f57c-428b-8efa-12ab77345b74@github.com>

On Wed, 13 Apr 2022 19:55:09 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Prior to this commit some of `jtreg`'s self-tests failed on Windows/Cygwin systems.
>> 
>> This commit fixes this mainly by adjusting assertions expecting Windows-style paths, `\r\n` line-breaks, and ignoring/normalizing other differences compared to Unix-based systems.
>> 
>> https://bugs.openjdk.java.net/browse/CODETOOLS-7903159
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix typo

Marked as reviewed by jjg (Lead).

-------------

PR: https://git.openjdk.java.net/jtreg/pull/74

From cstein at openjdk.java.net  Wed Apr 13 23:03:43 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Wed, 13 Apr 2022 23:03:43 GMT
Subject: Integrated: 7903159: Make jtreg self-tests run on Windows/Cygwin
In-Reply-To: <rcF-VwZSIt9e8h1u0D2XVRkp0Xocvk_mf_qz07DvyQo=.3e6d6349-48f7-4e78-a71c-38dea30e28b7@github.com>
References: <rcF-VwZSIt9e8h1u0D2XVRkp0Xocvk_mf_qz07DvyQo=.3e6d6349-48f7-4e78-a71c-38dea30e28b7@github.com>
Message-ID: <ixQ0Ajbt9I71t8kmuRBb4XglMJYfopBpRs6zsqn4G7M=.9a65fa34-e58e-4e57-9a15-1d21a3dfb3d5@github.com>

On Wed, 13 Apr 2022 19:38:18 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Prior to this commit some of `jtreg`'s self-tests failed on Windows/Cygwin systems.
> 
> This commit fixes this mainly by adjusting assertions expecting Windows-style paths, `\r\n` line-breaks, and ignoring/normalizing other differences compared to Unix-based systems.
> 
> https://bugs.openjdk.java.net/browse/CODETOOLS-7903159

This pull request has now been integrated.

Changeset: dec2a59d
Author:    Christian Stein <cstein at openjdk.org>
Committer: Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.java.net/jtreg/commit/dec2a59de0c7788a1494e4bd0ee50ab23b228505
Stats:     49 lines in 22 files changed: 8 ins; 0 del; 41 mod

7903159: Make jtreg self-tests run on Windows/Cygwin

Reviewed-by: jjg

-------------

PR: https://git.openjdk.java.net/jtreg/pull/74

From cstein at openjdk.java.net  Thu Apr 14 12:29:55 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 14 Apr 2022 12:29:55 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows
Message-ID: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>

CI builds including self-tests for `jtreg` are run on Linux.

Now, they also run on MacOS and Windows.

-------------

Commit messages:
 - 7903160: Run self-tests for jtreg on MacOS and Windows

Changes: https://git.openjdk.java.net/jtreg/pull/75/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=00
  Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903160
  Stats: 10 lines in 1 file changed: 7 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From cstein at openjdk.java.net  Thu Apr 14 12:36:20 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 14 Apr 2022 12:36:20 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v2]
In-Reply-To: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
Message-ID: <aR9gz-1NqhyTq2MeKIEIq34DPgHIHZHtyrsfOoMXkf8=.8f07d4e8-04e1-450c-892e-1da0385e5f27@github.com>

> CI builds including self-tests for `jtreg` are run on Linux.
> 
> Now, they also run on MacOS and Windows.

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Set up JDK 11

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/75/files
  - new: https://git.openjdk.java.net/jtreg/pull/75/files/d9589351..3349e5ed

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=00-01

  Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From cstein at openjdk.java.net  Thu Apr 14 12:42:06 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 14 Apr 2022 12:42:06 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v3]
In-Reply-To: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
Message-ID: <G3cVQb4qI5YLMFUBgAoTIQP9QE9CnXX2kNGQTb5AsKo=.9f80c61c-118c-4654-a5fe-b6e3dcc8b6df@github.com>

> CI builds including self-tests for `jtreg` are run on Linux.
> 
> Now, they also run on MacOS and Windows.

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Use default `JAVA_HOME` environment variable

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/75/files
  - new: https://git.openjdk.java.net/jtreg/pull/75/files/3349e5ed..a87f3498

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=01-02

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From jjg at openjdk.java.net  Thu Apr 14 22:06:30 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Thu, 14 Apr 2022 22:06:30 GMT
Subject: RFR: CODETOOLS-7903165: change -encoding option to use ASCII instead
 of ISO8859
Message-ID: <k7tlDZz6jeoxaRsrxrMcSyB8xCaHFL_4pZTJPsilnxA=.2200a390-3df1-471b-9b00-fa78e0d734d4@github.com>

Please review a trivial change to replace use of `-encoding ISO8859-1` (in various forms) to `-encoding ASCII`

-------------

Commit messages:
 - CODETOOLS-7903165: change -encoding option to use ASCII instead of ISO8859

Changes: https://git.openjdk.java.net/jtreg/pull/76/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=76&range=00
  Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903165
  Stats: 12 lines in 8 files changed: 0 ins; 0 del; 12 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/76.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/76/head:pull/76

PR: https://git.openjdk.java.net/jtreg/pull/76

From cstein at openjdk.java.net  Fri Apr 15 05:14:57 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Fri, 15 Apr 2022 05:14:57 GMT
Subject: RFR: CODETOOLS-7903165: change -encoding option to use ASCII
 instead of ISO8859
In-Reply-To: <k7tlDZz6jeoxaRsrxrMcSyB8xCaHFL_4pZTJPsilnxA=.2200a390-3df1-471b-9b00-fa78e0d734d4@github.com>
References: <k7tlDZz6jeoxaRsrxrMcSyB8xCaHFL_4pZTJPsilnxA=.2200a390-3df1-471b-9b00-fa78e0d734d4@github.com>
Message-ID: <Z2q3vmKAHaHLVoBEOtEp_laVwLHKNpW0rCEbBKJOCZw=.35b707da-2a9d-4ee9-bd4c-fed75b755d8e@github.com>

On Thu, 14 Apr 2022 21:59:25 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a trivial change to replace use of `-encoding ISO8859-1` (in various forms) to `-encoding ASCII`

LGTM

-------------

Marked as reviewed by cstein (Author).

PR: https://git.openjdk.java.net/jtreg/pull/76

From cstein at openjdk.java.net  Fri Apr 15 05:22:45 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Fri, 15 Apr 2022 05:22:45 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v4]
In-Reply-To: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
Message-ID: <9uglSCtT3XK5noPDA5kzThLV3KWVxELeD6hvwgvYe3c=.2ef587f4-91c5-4ccb-80eb-eddb2aff4d07@github.com>

> CI builds including self-tests for `jtreg` are run on Linux.
> 
> Now, they also run on MacOS and Windows.

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Install Cygwin on Windows

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/75/files
  - new: https://git.openjdk.java.net/jtreg/pull/75/files/a87f3498..b192d16b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=02-03

  Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From cstein at openjdk.java.net  Fri Apr 15 05:27:44 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Fri, 15 Apr 2022 05:27:44 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v5]
In-Reply-To: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
Message-ID: <WHCD3ALAqBfWSYK4JVnYYjju-ZqVcmut9V9r9hQvOog=.a786e78c-78d1-4cd2-b5b5-df1dd3c60ca3@github.com>

> CI builds including self-tests for `jtreg` are run on Linux.
> 
> Now, they also run on MacOS and Windows.

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Update CheckJavaOSVersion.java
  
  Make `11.6...` a match for `11.6`

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/75/files
  - new: https://git.openjdk.java.net/jtreg/pull/75/files/b192d16b..4140de8e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=03-04

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From cstein at openjdk.java.net  Fri Apr 15 05:43:35 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Fri, 15 Apr 2022 05:43:35 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v6]
In-Reply-To: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
Message-ID: <4CaUD7xki4fO-DUelCHcJCe80otZ4jQTV7CDu-gYbLY=.4c709b1d-a1ef-442e-9100-a842e009c43b@github.com>

> CI builds including self-tests for `jtreg` are run on Linux.
> 
> Now, they also run on MacOS and Windows.

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Update test.yml

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/75/files
  - new: https://git.openjdk.java.net/jtreg/pull/75/files/4140de8e..815320ba

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=04-05

  Stats: 12 lines in 1 file changed: 8 ins; 4 del; 0 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From cstein at openjdk.java.net  Fri Apr 15 05:59:35 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Fri, 15 Apr 2022 05:59:35 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v7]
In-Reply-To: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
Message-ID: <PHkVGnuuUc-4Og0LLR0RW6ojufQWSya1WuX5GKSopWM=.3e480037-b47f-4d77-873a-f08edc368dc4@github.com>

> CI builds including self-tests for `jtreg` are run on Linux.
> 
> Now, they also run on MacOS and Windows.

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Update test.yml

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/75/files
  - new: https://git.openjdk.java.net/jtreg/pull/75/files/815320ba..a2044bb2

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=05-06

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From cstein at openjdk.java.net  Fri Apr 15 06:05:37 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Fri, 15 Apr 2022 06:05:37 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v8]
In-Reply-To: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
Message-ID: <pM16k2h0bk6JFrndf46Xq_KSoqvpZ1hYeoiBMhbQPUs=.7e40e41a-f1fb-4315-b4f8-330b6a284f46@github.com>

> CI builds including self-tests for `jtreg` are run on Linux.
> 
> Now, they also run on MacOS and Windows.

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Update test.yml

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/75/files
  - new: https://git.openjdk.java.net/jtreg/pull/75/files/a2044bb2..cac46790

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=07
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=06-07

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From cstein at openjdk.java.net  Fri Apr 15 06:17:48 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Fri, 15 Apr 2022 06:17:48 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v9]
In-Reply-To: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
Message-ID: <YE_vQ2pLhgVIumoa9WBzNVvWIcNncwYJGcb-xJ3AWEg=.cec87481-e45a-419c-a12c-26fde13065e2@github.com>

> CI builds including self-tests for `jtreg` are run on Linux.
> 
> Now, they also run on MacOS and Windows.

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Update test.yml

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/75/files
  - new: https://git.openjdk.java.net/jtreg/pull/75/files/cac46790..464385a1

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=08
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=07-08

  Stats: 7 lines in 1 file changed: 0 ins; 4 del; 3 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From cstein at openjdk.java.net  Fri Apr 15 06:23:40 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Fri, 15 Apr 2022 06:23:40 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v10]
In-Reply-To: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
Message-ID: <LKtRrPPvH6-ZorLCyGRgpKwo7k91-a9FtRKLu6vWFzY=.f2967216-809e-4709-9806-d09c0f87703b@github.com>

> CI builds including self-tests for `jtreg` are run on Linux.
> 
> Now, they also run on MacOS and Windows.

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Install more Cygwin packages

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/75/files
  - new: https://git.openjdk.java.net/jtreg/pull/75/files/464385a1..a9131b15

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=09
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=08-09

  Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From enikitin at openjdk.java.net  Fri Apr 15 06:30:32 2022
From: enikitin at openjdk.java.net (Evgeny Nikitin)
Date: Fri, 15 Apr 2022 06:30:32 GMT
Subject: RFR: 7903166: jtreg crashes trying to compile .jasm with
 enablePreview=true
Message-ID: <b6i7Rd4DpBeGm464nTVdk9TrEWr8Xajcn-SoZJDRVQE=.3e98e652-17db-4e4e-8957-72df6d2aa0a3@github.com>

The bug: [CODETOOLS-7903166](https://bugs.openjdk.java.net/browse/CODETOOLS-7903166)

A small fix targeting crashes that occurs when jtreg compiles non-javac files with enablePreview. Prior the fix, the code crashed trying to insert arguments into javacArgs list using negative index.

Testing: test/preview folder self-tests.

-------------

Commit messages:
 - 7903166: jtreg crashes trying to compile .jasm with enablePreview=true

Changes: https://git.openjdk.java.net/jtreg/pull/77/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=77&range=00
  Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903166
  Stats: 73 lines in 4 files changed: 71 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/77.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/77/head:pull/77

PR: https://git.openjdk.java.net/jtreg/pull/77

From jjg at openjdk.java.net  Fri Apr 15 16:09:01 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Fri, 15 Apr 2022 16:09:01 GMT
Subject: RFR: 7903166: jtreg crashes trying to compile .jasm with
 enablePreview=true
In-Reply-To: <b6i7Rd4DpBeGm464nTVdk9TrEWr8Xajcn-SoZJDRVQE=.3e98e652-17db-4e4e-8957-72df6d2aa0a3@github.com>
References: <b6i7Rd4DpBeGm464nTVdk9TrEWr8Xajcn-SoZJDRVQE=.3e98e652-17db-4e4e-8957-72df6d2aa0a3@github.com>
Message-ID: <RPyZrNUMOC6_Ooru6HXCXB8hSrsQ0UEC-2Vma4AzL-8=.f3a6ae17-b061-4107-9b81-cf56432f341e@github.com>

On Fri, 15 Apr 2022 06:24:52 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:

> The bug: [CODETOOLS-7903166](https://bugs.openjdk.java.net/browse/CODETOOLS-7903166)
> 
> A small fix targeting crashes that occurs when jtreg compiles non-javac files with enablePreview. Prior the fix, the code crashed trying to insert arguments into javacArgs list using negative index.
> 
> Testing: test/preview folder self-tests.

Good catch; one improvement suggested.

src/share/classes/com/sun/javatest/regtest/exec/CompileAction.java line 367:

> 365:         }
> 366: 
> 367:         if (insertPos != -1 && script.enablePreview() && !seenEnablePreview) {

The fix would be clearer and more self-explanatory if you used the boolean `runJavac`. instead of the expression `insertPos != -1`.  It is already the case that `runJavac` implies `insertPos` is not `-1`.

-------------

Changes requested by jjg (Lead).

PR: https://git.openjdk.java.net/jtreg/pull/77

From jjg at openjdk.java.net  Fri Apr 15 16:22:10 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Fri, 15 Apr 2022 16:22:10 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v10]
In-Reply-To: <LKtRrPPvH6-ZorLCyGRgpKwo7k91-a9FtRKLu6vWFzY=.f2967216-809e-4709-9806-d09c0f87703b@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
 <LKtRrPPvH6-ZorLCyGRgpKwo7k91-a9FtRKLu6vWFzY=.f2967216-809e-4709-9806-d09c0f87703b@github.com>
Message-ID: <L-_IoPPyuraqSjh4txRy6AhieNzWxgxstnNZwLyvLeA=.7debc5a9-4fe3-44a2-b0ce-5350de93b71e@github.com>

On Fri, 15 Apr 2022 06:23:40 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> CI builds including self-tests for `jtreg` are run on Linux.
>> 
>> Now, they also run on MacOS and Windows.
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Install more Cygwin packages

.github/workflows/test.yml line 29:

> 27:       with:
> 28:         packages: >-
> 29:           rsync

You should not need rsync, with the latest version of the repo

-------------

PR: https://git.openjdk.java.net/jtreg/pull/75

From jjg at openjdk.java.net  Fri Apr 15 16:31:02 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Fri, 15 Apr 2022 16:31:02 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v10]
In-Reply-To: <LKtRrPPvH6-ZorLCyGRgpKwo7k91-a9FtRKLu6vWFzY=.f2967216-809e-4709-9806-d09c0f87703b@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
 <LKtRrPPvH6-ZorLCyGRgpKwo7k91-a9FtRKLu6vWFzY=.f2967216-809e-4709-9806-d09c0f87703b@github.com>
Message-ID: <tG0uli4I3eJkEgOndwakKMlh_SML-C6VOALxS1VLkNU=.c27ae88f-8a3c-4eae-ae12-4387860ab815@github.com>

On Fri, 15 Apr 2022 06:23:40 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> CI builds including self-tests for `jtreg` are run on Linux.
>> 
>> Now, they also run on MacOS and Windows.
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Install more Cygwin packages

make/CheckJavaOSVersion.java line 37:

> 35:     private static void checkJavaOSVersion(String expectVersion) {
> 36:         String osVersion = System.getProperty("os.version");
> 37:         if (!osVersion.startsWith(expectVersion)) {

This change seems questionable.

`os.version` is supposed to reflect (`.equals`) the OS version. We should at least understand why it is being reporting as a leading substring.   
Instead of `.startsWith`, consider `.matches` with a pattern that allows optional trailing dotted digits.

-------------

PR: https://git.openjdk.java.net/jtreg/pull/75

From enikitin at openjdk.java.net  Tue Apr 19 13:04:30 2022
From: enikitin at openjdk.java.net (Evgeny Nikitin)
Date: Tue, 19 Apr 2022 13:04:30 GMT
Subject: RFR: 7903166: jtreg crashes trying to compile .jasm with
 enablePreview=true [v2]
In-Reply-To: <b6i7Rd4DpBeGm464nTVdk9TrEWr8Xajcn-SoZJDRVQE=.3e98e652-17db-4e4e-8957-72df6d2aa0a3@github.com>
References: <b6i7Rd4DpBeGm464nTVdk9TrEWr8Xajcn-SoZJDRVQE=.3e98e652-17db-4e4e-8957-72df6d2aa0a3@github.com>
Message-ID: <vRepOM5LzoV1jiecaouprvX7qxTIs_b1dfA-H8q4R_8=.d716704c-6e21-4a75-8570-c2376647892f@github.com>

> The bug: [CODETOOLS-7903166](https://bugs.openjdk.java.net/browse/CODETOOLS-7903166)
> 
> A small fix targeting crashes that occurs when jtreg compiles non-javac files with enablePreview. Prior the fix, the code crashed trying to insert arguments into javacArgs list using negative index.
> 
> Testing: test/preview folder self-tests.

Evgeny Nikitin has updated the pull request incrementally with one additional commit since the last revision:

  Test for runJavac variable prior adding --enable-preview

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/77/files
  - new: https://git.openjdk.java.net/jtreg/pull/77/files/994d0aee..96230a3b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=77&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=77&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/77.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/77/head:pull/77

PR: https://git.openjdk.java.net/jtreg/pull/77

From enikitin at openjdk.java.net  Tue Apr 19 13:04:32 2022
From: enikitin at openjdk.java.net (Evgeny Nikitin)
Date: Tue, 19 Apr 2022 13:04:32 GMT
Subject: RFR: 7903166: jtreg crashes trying to compile .jasm with
 enablePreview=true [v2]
In-Reply-To: <RPyZrNUMOC6_Ooru6HXCXB8hSrsQ0UEC-2Vma4AzL-8=.f3a6ae17-b061-4107-9b81-cf56432f341e@github.com>
References: <b6i7Rd4DpBeGm464nTVdk9TrEWr8Xajcn-SoZJDRVQE=.3e98e652-17db-4e4e-8957-72df6d2aa0a3@github.com>
 <RPyZrNUMOC6_Ooru6HXCXB8hSrsQ0UEC-2Vma4AzL-8=.f3a6ae17-b061-4107-9b81-cf56432f341e@github.com>
Message-ID: <6CRXR6xwbITG3BRoTLkJEl0Yoe5nc_10ZHObe_cU-SU=.6ca6af1b-1e47-4afb-821e-301936fef147@github.com>

On Fri, 15 Apr 2022 16:05:12 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Evgeny Nikitin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Test for runJavac variable prior adding --enable-preview
>
> src/share/classes/com/sun/javatest/regtest/exec/CompileAction.java line 367:
> 
>> 365:         }
>> 366: 
>> 367:         if (insertPos != -1 && script.enablePreview() && !seenEnablePreview) {
> 
> The fix would be clearer and more self-explanatory if you used the boolean `runJavac`. instead of the expression `insertPos != -1`.  It is already the case that `runJavac` implies `insertPos` is not `-1`.

Argh, missed that variable. Agreed, that would be better. Fixed.

-------------

PR: https://git.openjdk.java.net/jtreg/pull/77

From cstein at openjdk.java.net  Wed Apr 20 16:02:51 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Wed, 20 Apr 2022 16:02:51 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v10]
In-Reply-To: <tG0uli4I3eJkEgOndwakKMlh_SML-C6VOALxS1VLkNU=.c27ae88f-8a3c-4eae-ae12-4387860ab815@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
 <LKtRrPPvH6-ZorLCyGRgpKwo7k91-a9FtRKLu6vWFzY=.f2967216-809e-4709-9806-d09c0f87703b@github.com>
 <tG0uli4I3eJkEgOndwakKMlh_SML-C6VOALxS1VLkNU=.c27ae88f-8a3c-4eae-ae12-4387860ab815@github.com>
Message-ID: <_z1sa2RL5FcON5wRkHFEDxYYkvXmFVkKMlI14ZdYBSE=.dc73207e-d038-4b3c-bfdb-9cd6c38ea806@github.com>

On Fri, 15 Apr 2022 16:27:58 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Install more Cygwin packages
>
> make/CheckJavaOSVersion.java line 37:
> 
>> 35:     private static void checkJavaOSVersion(String expectVersion) {
>> 36:         String osVersion = System.getProperty("os.version");
>> 37:         if (!osVersion.startsWith(expectVersion)) {
> 
> This change seems questionable.
> 
> `os.version` is supposed to reflect (`.equals`) the OS version. We should at least understand why it is being reporting as a leading substring.   
> Instead of `.startsWith`, consider `.matches` with a pattern that allows optional trailing dotted digits.

Could be related to https://bugs.openjdk.java.net/browse/JDK-8269850

The [error message](https://github.com/openjdk/jtreg/runs/6034597187?check_suite_focus=true#step:6:197) reported in the logs reads:

-------------

PR: https://git.openjdk.java.net/jtreg/pull/75

From jjg at openjdk.java.net  Wed Apr 20 16:30:45 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Wed, 20 Apr 2022 16:30:45 GMT
Subject: RFR: 7903055: Replace `junit.jar` with
 `junit-platform-console-standalone` artifact [v4]
In-Reply-To: <CEUi-SwXeltEXxs0qb4zWRUL4ry32YVxKKMpuNEkm40=.b59c5904-eb21-4121-b83a-75819fed17db@github.com>
References: <46UymgO92_HIuaimbMUGDI1SPGOKg3pP4jn4IduDcZE=.e056aac8-018b-459a-b61b-00b7b649ea86@github.com>
 <CEUi-SwXeltEXxs0qb4zWRUL4ry32YVxKKMpuNEkm40=.b59c5904-eb21-4121-b83a-75819fed17db@github.com>
Message-ID: <TJFXZuakQFNCXhwIpVKkoW1v9ZlcDLZiEmrw8bj7Uc4=.4820221e-6a9e-45ed-be43-42c1849f611e@github.com>

On Thu, 7 Apr 2022 16:14:53 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> https://bugs.openjdk.java.net/browse/CODETOOLS-7903055
>
> Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into 7903055-junit5
>  - Merge branch 'openjdk:master' into 7903055-junit5
>  - Retain full base name of the JAR file
>  - Restore updated comment
>  - Replace `junit.jar` with `junit-platform-console-standalone` artifact
>    
>    https://bugs.openjdk.java.net/browse/CODETOOLS-7903055

LGTM

-------------

Marked as reviewed by jjg (Lead).

PR: https://git.openjdk.java.net/jtreg/pull/63

From cstein at openjdk.java.net  Wed Apr 20 19:55:38 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Wed, 20 Apr 2022 19:55:38 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v11]
In-Reply-To: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
Message-ID: <-s1lvVWSOqcuhJmBXjt9L335w0OEnhcbYYafVs5Bzik=.e5b38bb7-da5b-4bcc-be9f-c5ecf6543f4e@github.com>

> CI builds including self-tests for `jtreg` are run on Linux.
> 
> Now, they also run on MacOS and Windows.

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Update CheckJavaOSVersion.java

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/75/files
  - new: https://git.openjdk.java.net/jtreg/pull/75/files/a9131b15..73babf29

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=10
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=09-10

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From cstein at openjdk.java.net  Fri Apr 22 15:51:51 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Fri, 22 Apr 2022 15:51:51 GMT
Subject: Integrated: 7903055: Replace `junit.jar` with
 `junit-platform-console-standalone` artifact
In-Reply-To: <46UymgO92_HIuaimbMUGDI1SPGOKg3pP4jn4IduDcZE=.e056aac8-018b-459a-b61b-00b7b649ea86@github.com>
References: <46UymgO92_HIuaimbMUGDI1SPGOKg3pP4jn4IduDcZE=.e056aac8-018b-459a-b61b-00b7b649ea86@github.com>
Message-ID: <JVXk1tCOEjAuF3UdUaml9RPmo6MRXIanDRyo98l9CcM=.49350916-a4ad-4700-863c-fcbde2736fbc@github.com>

On Thu, 3 Mar 2022 06:58:35 GMT, Christian Stein <cstein at openjdk.org> wrote:

> https://bugs.openjdk.java.net/browse/CODETOOLS-7903055

This pull request has now been integrated.

Changeset: e7a8de66
Author:    Christian Stein <cstein at openjdk.org>
Committer: Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.java.net/jtreg/commit/e7a8de66693c3bca74e5b581ab8c460f3ddff580
Stats:     55 lines in 3 files changed: 1 ins; 47 del; 7 mod

7903055: Replace `junit.jar` with `junit-platform-console-standalone` artifact

Reviewed-by: jjg

-------------

PR: https://git.openjdk.java.net/jtreg/pull/63

From cstein at openjdk.java.net  Sat Apr 23 05:56:01 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 05:56:01 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
Message-ID: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>

Make JUnit runner use the JUnit Platform Launcher

See https://bugs.openjdk.java.net/browse/CODETOOLS-7903047

-------------

Commit messages:
 - Target Java SE 11
 - 7903047: Make JUnit runner use the JUnit Platform Launcher

Changes: https://git.openjdk.java.net/jtreg/pull/78/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=00
  Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903047
  Stats: 45 lines in 2 files changed: 42 ins; 1 del; 2 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/78/head:pull/78

PR: https://git.openjdk.java.net/jtreg/pull/78

From cstein at openjdk.java.net  Sat Apr 23 06:09:26 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 06:09:26 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v2]
In-Reply-To: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
Message-ID: <Gr2K17mjIlL0MhwPuyPDocyV_WSk25eOz_1mtfKfo3A=.415fcf5b-69f7-4d43-be78-3426fb6d17b8@github.com>

> Make JUnit runner use the JUnit Platform Launcher
> 
> See https://bugs.openjdk.java.net/browse/CODETOOLS-7903047

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Include JUnit Jupiter test

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/78/files
  - new: https://git.openjdk.java.net/jtreg/pull/78/files/5110e470..ed9a76aa

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=00-01

  Stats: 12 lines in 2 files changed: 5 ins; 3 del; 4 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/78/head:pull/78

PR: https://git.openjdk.java.net/jtreg/pull/78

From cstein at openjdk.java.net  Sat Apr 23 06:18:19 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 06:18:19 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v3]
In-Reply-To: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
Message-ID: <4kgajRt5huYL6RnlDmh1BWf96CV1BDJi2H7MEbP7d94=.158ef0a2-7c21-44fc-a19d-4a370a3bf1ed@github.com>

> Make JUnit runner use the JUnit Platform Launcher
> 
> See https://bugs.openjdk.java.net/browse/CODETOOLS-7903047

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Include JUnit Trace test in set of initial tests

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/78/files
  - new: https://git.openjdk.java.net/jtreg/pull/78/files/ed9a76aa..3e4aac01

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=01-02

  Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/78/head:pull/78

PR: https://git.openjdk.java.net/jtreg/pull/78

From cstein at openjdk.java.net  Sat Apr 23 06:24:32 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 06:24:32 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v4]
In-Reply-To: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
Message-ID: <2Re2MSRggHfDOz1ClmlARDWUVjuR3qhPAG9B5P1sxbw=.f79b2b66-b36b-49d5-bd6b-6c6e82e1b5d6@github.com>

> Make JUnit runner use the JUnit Platform Launcher
> 
> See https://bugs.openjdk.java.net/browse/CODETOOLS-7903047

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Print test work files for debugging

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/78/files
  - new: https://git.openjdk.java.net/jtreg/pull/78/files/3e4aac01..44be3f6b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=02-03

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/78/head:pull/78

PR: https://git.openjdk.java.net/jtreg/pull/78

From cstein at openjdk.java.net  Sat Apr 23 06:32:23 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 06:32:23 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v5]
In-Reply-To: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
Message-ID: <bZ8uLvra4ktZybQ6RplE3Lvka2I-DjrBoFsIxJ5gI4I=.9154aa56-ff34-4b10-b62b-fda482d5a28e@github.com>

> Make JUnit runner use the JUnit Platform Launcher
> 
> See https://bugs.openjdk.java.net/browse/CODETOOLS-7903047

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Print stacktrace for each failed test

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/78/files
  - new: https://git.openjdk.java.net/jtreg/pull/78/files/44be3f6b..be0db311

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=03-04

  Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/78/head:pull/78

PR: https://git.openjdk.java.net/jtreg/pull/78

From cstein at openjdk.java.net  Sat Apr 23 06:40:29 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 06:40:29 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v6]
In-Reply-To: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
Message-ID: <vgz3QZ8uoNWoc-RdxWJIttAJw3EdKtGNo6YFrE6Ffso=.e605d210-0de4-45ed-b021-e0e288daf737@github.com>

> Make JUnit runner use the JUnit Platform Launcher
> 
> See https://bugs.openjdk.java.net/browse/CODETOOLS-7903047

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Treat `Pass.java` as single test

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/78/files
  - new: https://git.openjdk.java.net/jtreg/pull/78/files/be0db311..758b65c4

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=04-05

  Stats: 6 lines in 1 file changed: 0 ins; 4 del; 2 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/78/head:pull/78

PR: https://git.openjdk.java.net/jtreg/pull/78

From cstein at openjdk.java.net  Sat Apr 23 11:34:29 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 11:34:29 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v7]
In-Reply-To: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
Message-ID: <eLIdMvIIrRbxmJf4YQex31I1hhtdrtxv-51KArE82kk=.699fb446-bb3c-49b4-bd15-3170ab28e7e9@github.com>

> Make JUnit runner use the JUnit Platform Launcher
> 
> See https://bugs.openjdk.java.net/browse/CODETOOLS-7903047

Christian Stein has updated the pull request incrementally with two additional commits since the last revision:

 - Fix typo
 - Add dedicated test class using JUnit Jupiter API

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/78/files
  - new: https://git.openjdk.java.net/jtreg/pull/78/files/758b65c4..763e6d13

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=05-06

  Stats: 45 lines in 3 files changed: 36 ins; 4 del; 5 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/78/head:pull/78

PR: https://git.openjdk.java.net/jtreg/pull/78

From cstein at openjdk.java.net  Sat Apr 23 12:21:25 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 12:21:25 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v8]
In-Reply-To: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
Message-ID: <hVrpWqrcjvjPgIkHUnBqFPnS7xZV9HGwlb2HmkDGiEI=.eddeea18-5e72-4b3b-bc85-01923c09f161@github.com>

> Make JUnit runner use the JUnit Platform Launcher
> 
> See https://bugs.openjdk.java.net/browse/CODETOOLS-7903047

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Check usage of standard and parameterized Jupiter API

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/78/files
  - new: https://git.openjdk.java.net/jtreg/pull/78/files/763e6d13..a0a31ff9

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=07
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=06-07

  Stats: 44 lines in 2 files changed: 40 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/78/head:pull/78

PR: https://git.openjdk.java.net/jtreg/pull/78

From cstein at openjdk.java.net  Sat Apr 23 12:34:16 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 12:34:16 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v9]
In-Reply-To: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
Message-ID: <Zwflav1u4KxCGWo1kNczY6e9IcdZXT3uZr9B-8rdH2Y=.c08419ce-5beb-488d-b042-8611220da8e1@github.com>

> Make JUnit runner use the JUnit Platform Launcher
> 
> See https://bugs.openjdk.java.net/browse/CODETOOLS-7903047

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Remove JUnit Trace test from set of initial tests

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/78/files
  - new: https://git.openjdk.java.net/jtreg/pull/78/files/a0a31ff9..f402d99b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=08
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=07-08

  Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/78/head:pull/78

PR: https://git.openjdk.java.net/jtreg/pull/78

From cstein at openjdk.java.net  Sat Apr 23 12:49:30 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 12:49:30 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v12]
In-Reply-To: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
Message-ID: <PmG8CiY6t9dYnOpxBlvJ0bZZPVqhNkG_3HIpHmmbdEg=.52a2e6bf-e675-4468-a5cf-1581db8d4c32@github.com>

> CI builds including self-tests for `jtreg` are run on Linux.
> 
> Now, they also run on MacOS and Windows.

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Create build.yml
  
  [skip CI]

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/75/files
  - new: https://git.openjdk.java.net/jtreg/pull/75/files/73babf29..e7884677

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=11
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=10-11

  Stats: 23 lines in 1 file changed: 23 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From cstein at openjdk.java.net  Sat Apr 23 12:53:32 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 12:53:32 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v13]
In-Reply-To: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
Message-ID: <45i03MwNOrUy38pxnusFH2kPes1aRRruytXtpPuq1uI=.a7162f36-b2a0-469c-a4ba-4162ecf6195b@github.com>

> CI builds including self-tests for `jtreg` are run on Linux.
> 
> Now, they also run on MacOS and Windows.

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Update build.yml
  
  [skip CI]

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/75/files
  - new: https://git.openjdk.java.net/jtreg/pull/75/files/e7884677..06c707e9

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=12
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=11-12

  Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From cstein at openjdk.java.net  Sat Apr 23 13:00:30 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 13:00:30 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v14]
In-Reply-To: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
Message-ID: <I6A74Ih0QOTKsovZ-YBH_C0AE3KVL1q7tswXyBiMGXA=.b68835f2-dbc6-45fd-8aac-de7f75b2e669@github.com>

> CI builds including self-tests for `jtreg` are run on Linux.
> 
> Now, they also run on MacOS and Windows.

Christian Stein has updated the pull request incrementally with two additional commits since the last revision:

 - Rename .github/actions/build.yml to .github/actions/build/action.yml
 - One job per OS

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/75/files
  - new: https://git.openjdk.java.net/jtreg/pull/75/files/06c707e9..56cd9a09

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=13
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=12-13

  Stats: 49 lines in 2 files changed: 0 ins; 31 del; 18 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From cstein at openjdk.java.net  Sat Apr 23 13:22:46 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 13:22:46 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v10]
In-Reply-To: <L-_IoPPyuraqSjh4txRy6AhieNzWxgxstnNZwLyvLeA=.7debc5a9-4fe3-44a2-b0ce-5350de93b71e@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
 <LKtRrPPvH6-ZorLCyGRgpKwo7k91-a9FtRKLu6vWFzY=.f2967216-809e-4709-9806-d09c0f87703b@github.com>
 <L-_IoPPyuraqSjh4txRy6AhieNzWxgxstnNZwLyvLeA=.7debc5a9-4fe3-44a2-b0ce-5350de93b71e@github.com>
Message-ID: <O0HpiLFLFmV-jII-Fp7PBL_XyT-v3k22fCjxrOFb5A0=.44762f48-e00d-4a3a-ad8f-821a4d823326@github.com>

On Fri, 15 Apr 2022 16:18:47 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Install more Cygwin packages
>
> .github/workflows/test.yml line 29:
> 
>> 27:       with:
>> 28:         packages: >-
>> 29:           rsync
> 
> You should not need rsync, with the latest version of the repo

Removed `rsync` from the list of packages.

-------------

PR: https://git.openjdk.java.net/jtreg/pull/75

From cstein at openjdk.java.net  Sat Apr 23 13:22:49 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 13:22:49 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v10]
In-Reply-To: <_z1sa2RL5FcON5wRkHFEDxYYkvXmFVkKMlI14ZdYBSE=.dc73207e-d038-4b3c-bfdb-9cd6c38ea806@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
 <LKtRrPPvH6-ZorLCyGRgpKwo7k91-a9FtRKLu6vWFzY=.f2967216-809e-4709-9806-d09c0f87703b@github.com>
 <tG0uli4I3eJkEgOndwakKMlh_SML-C6VOALxS1VLkNU=.c27ae88f-8a3c-4eae-ae12-4387860ab815@github.com>
 <_z1sa2RL5FcON5wRkHFEDxYYkvXmFVkKMlI14ZdYBSE=.dc73207e-d038-4b3c-bfdb-9cd6c38ea806@github.com>
Message-ID: <a-W1oqp28aJZu0juGGAK7jac88IszcDxTZzA-9yuMfw=.c1e1d243-a714-4d8e-95d6-bd879f30c4df@github.com>

On Wed, 20 Apr 2022 15:56:38 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> make/CheckJavaOSVersion.java line 37:
>> 
>>> 35:     private static void checkJavaOSVersion(String expectVersion) {
>>> 36:         String osVersion = System.getProperty("os.version");
>>> 37:         if (!osVersion.startsWith(expectVersion)) {
>> 
>> This change seems questionable.
>> 
>> `os.version` is supposed to reflect (`.equals`) the OS version. We should at least understand why it is being reporting as a leading substring.   
>> Instead of `.startsWith`, consider `.matches` with a pattern that allows optional trailing dotted digits.
>
> Could be related to https://bugs.openjdk.java.net/browse/JDK-8269850
> 
> The [error message](https://github.com/openjdk/jtreg/runs/6034597187?check_suite_focus=true#step:6:197) reported in the logs reads:

Added an explanatory comment.

-------------

PR: https://git.openjdk.java.net/jtreg/pull/75

From cstein at openjdk.java.net  Sat Apr 23 13:33:17 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 13:33:17 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v15]
In-Reply-To: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
Message-ID: <Gy9RB31cjro1q0Mtzhrg3MbwxfdCYZfGsc4vnKXch30=.8d21c3ba-e4ad-4dad-bf97-20fd77aa42ed@github.com>

> CI builds including self-tests for `jtreg` are run on Linux.
> 
> Now, they also run on MacOS and Windows.

Christian Stein has updated the pull request incrementally with two additional commits since the last revision:

 - Update action.yml
 - Update test.yml

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/75/files
  - new: https://git.openjdk.java.net/jtreg/pull/75/files/56cd9a09..7365403f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=14
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=13-14

  Stats: 20 lines in 2 files changed: 16 ins; 4 del; 0 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From cstein at openjdk.java.net  Sat Apr 23 13:37:08 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 13:37:08 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v16]
In-Reply-To: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
Message-ID: <6NNVNoYYWvjiAs_gJXeLZj3Dr2xoKQQi8X-2Tw4VQ_M=.58243999-263a-40bb-bbf8-9dfd0a515cf5@github.com>

> CI builds including self-tests for `jtreg` are run on Linux.
> 
> Now, they also run on MacOS and Windows.

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Update test.yml

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/75/files
  - new: https://git.openjdk.java.net/jtreg/pull/75/files/7365403f..ec2cbb80

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=15
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=14-15

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From cstein at openjdk.java.net  Sat Apr 23 13:47:29 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 13:47:29 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v17]
In-Reply-To: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
Message-ID: <VojHyXwsetGt8fLQeF3y5wu2rynZj5Z0YK8vvSi_rrA=.c2c4861b-3b0c-45f1-85a8-846d3e2339f6@github.com>

> CI builds including self-tests for `jtreg` are run on Linux.
> 
> Now, they also run on MacOS and Windows.

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Update test.yml

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/75/files
  - new: https://git.openjdk.java.net/jtreg/pull/75/files/ec2cbb80..c6f84e72

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=16
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=15-16

  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From cstein at openjdk.java.net  Sat Apr 23 13:55:16 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 13:55:16 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v18]
In-Reply-To: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
Message-ID: <xs4Wripyr6vQcyiE5axV2WF6qIQIUiDXytm4P7J7H-w=.337fbb65-c382-4c1a-92da-d79552faf641@github.com>

> CI builds including self-tests for `jtreg` are run on Linux.
> 
> Now, they also run on MacOS and Windows.

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Update test.yml

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/75/files
  - new: https://git.openjdk.java.net/jtreg/pull/75/files/c6f84e72..be412c52

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=17
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=16-17

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From cstein at openjdk.java.net  Sat Apr 23 13:59:26 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 13:59:26 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v19]
In-Reply-To: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
Message-ID: <URaHafvAgQ3aHcR46mHvZ5BPOuwpOe4hoGSi4ySQrx0=.3aa4fe3f-d11a-45bc-9ab0-f098f3fc28ff@github.com>

> CI builds including self-tests for `jtreg` are run on Linux.
> 
> Now, they also run on MacOS and Windows.

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Update test.yml

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/75/files
  - new: https://git.openjdk.java.net/jtreg/pull/75/files/be412c52..e552ee7a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=18
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=17-18

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From cstein at openjdk.java.net  Sat Apr 23 14:14:20 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 14:14:20 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v20]
In-Reply-To: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
Message-ID: <X73wIZr54nYWcLqoavp54rt93CVnHWMQKpMb0gPsNQU=.485e8009-2218-4bf1-bb63-8e4ade379371@github.com>

> CI builds including self-tests for `jtreg` are run on Linux.
> 
> Now, they also run on MacOS and Windows.

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Inline steps on Windows

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/75/files
  - new: https://git.openjdk.java.net/jtreg/pull/75/files/e552ee7a..086ef746

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=19
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=18-19

  Stats: 14 lines in 1 file changed: 12 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From cstein at openjdk.java.net  Sat Apr 23 14:18:13 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Sat, 23 Apr 2022 14:18:13 GMT
Subject: RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v21]
In-Reply-To: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
References: <t9ot-iJNpIzJ1Mloucsiefis9EP-gZYE1Iaj-wRk0mM=.25cab353-46a1-485f-93f4-21a23ca53fe8@github.com>
Message-ID: <17ijetEhr8QZ5UCX84M8DWDRI0I1BaZW4QgCeA-vhMk=.4745ef11-4065-4d2b-9fb0-7ae5d82e52f0@github.com>

> CI builds including self-tests for `jtreg` are run on Linux.
> 
> Now, they also run on MacOS and Windows.

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Reorder steps

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/75/files
  - new: https://git.openjdk.java.net/jtreg/pull/75/files/086ef746..d62e2665

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=20
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=75&range=19-20

  Stats: 21 lines in 1 file changed: 0 ins; 15 del; 6 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/75.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/75/head:pull/75

PR: https://git.openjdk.java.net/jtreg/pull/75

From jjg at openjdk.java.net  Mon Apr 25 14:43:48 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Mon, 25 Apr 2022 14:43:48 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v9]
In-Reply-To: <Zwflav1u4KxCGWo1kNczY6e9IcdZXT3uZr9B-8rdH2Y=.c08419ce-5beb-488d-b042-8611220da8e1@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
 <Zwflav1u4KxCGWo1kNczY6e9IcdZXT3uZr9B-8rdH2Y=.c08419ce-5beb-488d-b042-8611220da8e1@github.com>
Message-ID: <iTGrU5dHIOsYqolZ8RHiF9ncjKened7Bq6H9-dru-ig=.a56529cf-bfb5-4faf-b461-7373643745fc@github.com>

On Sat, 23 Apr 2022 12:34:16 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Make JUnit runner use the JUnit Platform Launcher
>> 
>> See https://bugs.openjdk.java.net/browse/CODETOOLS-7903047
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove JUnit Trace test from set of initial tests

Changes requested by jjg (Lead).

make/Defs.gmk line 114:

> 112: JAR = $(JDKHOME)/bin/jar
> 113: 
> 114: AGENT_JAVAC_SOURCE_TARGET = --release 11

No. The use of 8 is deliberate, so that we can run use jtreg to test older versions of JDK.

-------------

PR: https://git.openjdk.java.net/jtreg/pull/78

From cstein at openjdk.java.net  Mon Apr 25 14:49:48 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Mon, 25 Apr 2022 14:49:48 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v9]
In-Reply-To: <iTGrU5dHIOsYqolZ8RHiF9ncjKened7Bq6H9-dru-ig=.a56529cf-bfb5-4faf-b461-7373643745fc@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
 <Zwflav1u4KxCGWo1kNczY6e9IcdZXT3uZr9B-8rdH2Y=.c08419ce-5beb-488d-b042-8611220da8e1@github.com>
 <iTGrU5dHIOsYqolZ8RHiF9ncjKened7Bq6H9-dru-ig=.a56529cf-bfb5-4faf-b461-7373643745fc@github.com>
Message-ID: <tOgarrQLG6wkTEj1jmwe2JL0vFCwja1tFA4cm_dCm6k=.2f76e510-7da1-4eb0-8cb6-fffd95d68819@github.com>

On Mon, 25 Apr 2022 14:40:20 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove JUnit Trace test from set of initial tests
>
> make/Defs.gmk line 114:
> 
>> 112: JAR = $(JDKHOME)/bin/jar
>> 113: 
>> 114: AGENT_JAVAC_SOURCE_TARGET = --release 11
> 
> No. The use of 8 is deliberate, so that we can run use jtreg to test older versions of JDK.

OK. Reverting to `--release 8` and replacing all `var` usages with explicit type references.

-------------

PR: https://git.openjdk.java.net/jtreg/pull/78

From cstein at openjdk.java.net  Mon Apr 25 14:56:29 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Mon, 25 Apr 2022 14:56:29 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v10]
In-Reply-To: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
Message-ID: <gb_Wi25c4wuBMscHQOvvnnsDums9vpS0olxGdpgJprM=.6c1749e9-bad2-4338-a666-def40d72a368@github.com>

> Make JUnit runner use the JUnit Platform Launcher
> 
> See https://bugs.openjdk.java.net/browse/CODETOOLS-7903047

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Agent's sources target Java SE release 8

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/78/files
  - new: https://git.openjdk.java.net/jtreg/pull/78/files/f402d99b..0cdb4e48

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=09
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=08-09

  Stats: 15 lines in 3 files changed: 5 ins; 0 del; 10 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/78/head:pull/78

PR: https://git.openjdk.java.net/jtreg/pull/78

From jjg at openjdk.java.net  Mon Apr 25 14:56:30 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Mon, 25 Apr 2022 14:56:30 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v9]
In-Reply-To: <tOgarrQLG6wkTEj1jmwe2JL0vFCwja1tFA4cm_dCm6k=.2f76e510-7da1-4eb0-8cb6-fffd95d68819@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
 <Zwflav1u4KxCGWo1kNczY6e9IcdZXT3uZr9B-8rdH2Y=.c08419ce-5beb-488d-b042-8611220da8e1@github.com>
 <iTGrU5dHIOsYqolZ8RHiF9ncjKened7Bq6H9-dru-ig=.a56529cf-bfb5-4faf-b461-7373643745fc@github.com>
 <tOgarrQLG6wkTEj1jmwe2JL0vFCwja1tFA4cm_dCm6k=.2f76e510-7da1-4eb0-8cb6-fffd95d68819@github.com>
Message-ID: <gWjRR4Cuy0V39Rk1FOJJv-wy8_tmA7pVcnQ2Zwgruvc=.43ed33e6-d9e8-4f2a-8807-4ee10f8a6c05@github.com>

On Mon, 25 Apr 2022 14:46:22 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> make/Defs.gmk line 114:
>> 
>>> 112: JAR = $(JDKHOME)/bin/jar
>>> 113: 
>>> 114: AGENT_JAVAC_SOURCE_TARGET = --release 11
>> 
>> No. The use of 8 is deliberate, so that we can run use jtreg to test older versions of JDK.
>
> OK. Reverting to `--release 8` and replacing all `var` usages with explicit type references.

Maybe prefix the line with a comment of the form:

// Specify oldest supported JDK version that can be tested

-------------

PR: https://git.openjdk.java.net/jtreg/pull/78

From cstein at openjdk.java.net  Mon Apr 25 15:05:39 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Mon, 25 Apr 2022 15:05:39 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v11]
In-Reply-To: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
Message-ID: <TTwTDb2V9AYTGxaNngj49lWW2_6pavyeVsRGNg2zMnU=.15739f82-9f33-46b2-b15c-73b553e735f3@github.com>

> Make JUnit runner use the JUnit Platform Launcher
> 
> See https://bugs.openjdk.java.net/browse/CODETOOLS-7903047

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Replace one last `var` usage

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/78/files
  - new: https://git.openjdk.java.net/jtreg/pull/78/files/0cdb4e48..223af3c2

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=10
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=09-10

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/78/head:pull/78

PR: https://git.openjdk.java.net/jtreg/pull/78

From cstein at openjdk.java.net  Mon Apr 25 15:52:24 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Mon, 25 Apr 2022 15:52:24 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v12]
In-Reply-To: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
Message-ID: <El8-dHgXS8MWTmnXARFwCSlNSbgGZXHvWOO0eBLL80g=.e44866f4-a1bc-4199-b798-8b9f4979c8c4@github.com>

> Make JUnit runner use the JUnit Platform Launcher
> 
> See https://bugs.openjdk.java.net/browse/CODETOOLS-7903047

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Add support for `runWithJUnit4` flag

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/78/files
  - new: https://git.openjdk.java.net/jtreg/pull/78/files/223af3c2..5454a561

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=11
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=10-11

  Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/78/head:pull/78

PR: https://git.openjdk.java.net/jtreg/pull/78

From jjg at openjdk.java.net  Mon Apr 25 19:23:57 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Mon, 25 Apr 2022 19:23:57 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v12]
In-Reply-To: <El8-dHgXS8MWTmnXARFwCSlNSbgGZXHvWOO0eBLL80g=.e44866f4-a1bc-4199-b798-8b9f4979c8c4@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
 <El8-dHgXS8MWTmnXARFwCSlNSbgGZXHvWOO0eBLL80g=.e44866f4-a1bc-4199-b798-8b9f4979c8c4@github.com>
Message-ID: <tTOvk0fI545N1ckaAE3oluu9yhy7AJ9SqWhU2Os-X2A=.43c55ce8-a0bd-458e-b353-8d0b0524be95@github.com>

On Mon, 25 Apr 2022 15:52:24 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Make JUnit runner use the JUnit Platform Launcher
>> 
>> See https://bugs.openjdk.java.net/browse/CODETOOLS-7903047
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add support for `runWithJUnit4` flag

src/share/classes/com/sun/javatest/regtest/agent/JUnitRunner.java line 46:

> 44: public class JUnitRunner implements MainActionHelper.TestRunner {
> 45:     private static final String
> 46:         JUNIT_NO_DRIVER        = "No JUnit driver (install junit-platform-console-standalone.jar next to jtreg.jar)";

The code should not specifically require this jar file by name. We went to an effort recently to decouple the names of the jar files used to build jtreg from the code that uses them.
Admittedly, this string literal was an accidental oversight from that recent work. I suggest changing the name of the jar file to just `JUnit` or `JUnit jar file(s)`

src/share/classes/com/sun/javatest/regtest/agent/JUnitRunner.java line 48:

> 46:         JUNIT_NO_DRIVER        = "No JUnit driver (install junit-platform-console-standalone.jar next to jtreg.jar)";
> 47:     private static final boolean
> 48:         JUNIT_RUN_WITH_JUNIT_4 = Flags.get("runWithJUnit4");

suggest adding comment that this is temporary, during the transition.

-------------

PR: https://git.openjdk.java.net/jtreg/pull/78

From jjg at openjdk.java.net  Mon Apr 25 19:31:49 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Mon, 25 Apr 2022 19:31:49 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v12]
In-Reply-To: <El8-dHgXS8MWTmnXARFwCSlNSbgGZXHvWOO0eBLL80g=.e44866f4-a1bc-4199-b798-8b9f4979c8c4@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
 <El8-dHgXS8MWTmnXARFwCSlNSbgGZXHvWOO0eBLL80g=.e44866f4-a1bc-4199-b798-8b9f4979c8c4@github.com>
Message-ID: <1WZhFes3-j7iKq8CnzPCk91_jJj9p4xDb2DxiSBE1jM=.a0f34735-cc0f-4326-8b75-7d0154c03684@github.com>

On Mon, 25 Apr 2022 15:52:24 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Make JUnit runner use the JUnit Platform Launcher
>> 
>> See https://bugs.openjdk.java.net/browse/CODETOOLS-7903047
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add support for `runWithJUnit4` flag

src/share/classes/com/sun/javatest/regtest/agent/JUnitRunner.java line 114:

> 112:     private static void runWithJUnitPlatform(Class<?> mainClass) throws Exception {
> 113:         // https://junit.org/junit5/docs/current/user-guide/#launcher-api-execution
> 114:         Thread.currentThread().setContextClassLoader(mainClass.getClassLoader());

this line, to set the context class loader, might be an issue for some core-libs tests.

src/share/classes/com/sun/javatest/regtest/agent/JUnitRunner.java line 140:

> 138:                     summary.printTo(pw);
> 139:                 }
> 140:                 System.err.println(sw);

printing to `System.err` may be an issue; this is happening on the test-side, isn't it?

test/junitTrace/JUnitTrace.gmk line 35:

> 33: 		-w:$(@:%.ok=%)/work -r:$(@:%.ok=%)/report \
> 34: 		-jdk:$(JDKHOME) \
> 35: 		-agentvm \

It might be better to upgrade this test to run in both modes (othervm, agentvm), although maybe that could be could separately

-------------

PR: https://git.openjdk.java.net/jtreg/pull/78

From jjg at openjdk.java.net  Mon Apr 25 19:35:46 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Mon, 25 Apr 2022 19:35:46 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v12]
In-Reply-To: <1WZhFes3-j7iKq8CnzPCk91_jJj9p4xDb2DxiSBE1jM=.a0f34735-cc0f-4326-8b75-7d0154c03684@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
 <El8-dHgXS8MWTmnXARFwCSlNSbgGZXHvWOO0eBLL80g=.e44866f4-a1bc-4199-b798-8b9f4979c8c4@github.com>
 <1WZhFes3-j7iKq8CnzPCk91_jJj9p4xDb2DxiSBE1jM=.a0f34735-cc0f-4326-8b75-7d0154c03684@github.com>
Message-ID: <C0r6gcFx7AHjNfo3scMDSXCB-XZm_s0vw0O1OErxH9E=.0fc76ce0-ab4f-484a-a356-0d85150415d5@github.com>

On Mon, 25 Apr 2022 19:21:55 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add support for `runWithJUnit4` flag
>
> src/share/classes/com/sun/javatest/regtest/agent/JUnitRunner.java line 114:
> 
>> 112:     private static void runWithJUnitPlatform(Class<?> mainClass) throws Exception {
>> 113:         // https://junit.org/junit5/docs/current/user-guide/#launcher-api-execution
>> 114:         Thread.currentThread().setContextClassLoader(mainClass.getClassLoader());
> 
> this line, to set the context class loader, might be an issue for some core-libs tests.

... I guess it might just mean we can't use JUnit Jupiter for some of the low-level core-libs tests

-------------

PR: https://git.openjdk.java.net/jtreg/pull/78

From jjg at openjdk.java.net  Tue Apr 26 16:36:51 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Tue, 26 Apr 2022 16:36:51 GMT
Subject: RFR: CODETOOLS-7903171: Fix issues related to generating internal API
 documentation
Message-ID: <wd6VVoZkbSYDBP-L5AQzXUQFMdil_NEjgkc46BMyeEU=.66cb2e0e-6a50-4a32-bfec-6a02518e652c@github.com>

Please review some trivial changes to update the makefiles and doc comments used to generate internal API documentation

-------------

Commit messages:
 - CODETOOLS-7903171: Fix issues related to generating internal API documentation

Changes: https://git.openjdk.java.net/jtreg/pull/79/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=79&range=00
  Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903171
  Stats: 23 lines in 5 files changed: 1 ins; 1 del; 21 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/79.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/79/head:pull/79

PR: https://git.openjdk.java.net/jtreg/pull/79

From jjg at openjdk.java.net  Tue Apr 26 16:39:40 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Tue, 26 Apr 2022 16:39:40 GMT
Subject: RFR: CODETOOLS-7903168: Update openjdk/jtreg repo to require 1
 Reviewer
Message-ID: <ksfdi6vKj79-ij32jevykUKiJdZIKviB_IcS10v9r1E=.fcabc8c5-5c89-4a4a-ab46-a823002f2966@github.com>

Please review a small change to require a "R"eviewer for changes to the jtreg repo

-------------

Commit messages:
 - CODETOOLS-7903168: Update openjdk/jtreg repo to require 1 Reviewer

Changes: https://git.openjdk.java.net/jtreg/pull/80/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=80&range=00
  Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903168
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/80.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/80/head:pull/80

PR: https://git.openjdk.java.net/jtreg/pull/80

From jjg at openjdk.java.net  Tue Apr 26 17:14:24 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Tue, 26 Apr 2022 17:14:24 GMT
Subject: RFR: 7903166: jtreg crashes trying to compile .jasm with
 enablePreview=true [v2]
In-Reply-To: <vRepOM5LzoV1jiecaouprvX7qxTIs_b1dfA-H8q4R_8=.d716704c-6e21-4a75-8570-c2376647892f@github.com>
References: <b6i7Rd4DpBeGm464nTVdk9TrEWr8Xajcn-SoZJDRVQE=.3e98e652-17db-4e4e-8957-72df6d2aa0a3@github.com>
 <vRepOM5LzoV1jiecaouprvX7qxTIs_b1dfA-H8q4R_8=.d716704c-6e21-4a75-8570-c2376647892f@github.com>
Message-ID: <7jkbL4aivrvlYmI4nNEwdUC2HeSuj51zGuBJABN8baE=.eb836ab6-def0-400b-b15a-bd2a21af4b17@github.com>

On Tue, 19 Apr 2022 13:04:30 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:

>> The bug: [CODETOOLS-7903166](https://bugs.openjdk.java.net/browse/CODETOOLS-7903166)
>> 
>> A small fix targeting crashes that occurs when jtreg compiles non-javac files with enablePreview. Prior the fix, the code crashed trying to insert arguments into javacArgs list using negative index.
>> 
>> Testing: test/preview folder self-tests.
>
> Evgeny Nikitin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test for runJavac variable prior adding --enable-preview

LGTM

You need to add `/integrate` and then I can `/sponsor` it

-------------

Marked as reviewed by jjg (Lead).

PR: https://git.openjdk.java.net/jtreg/pull/77

From iris at openjdk.java.net  Tue Apr 26 17:17:16 2022
From: iris at openjdk.java.net (Iris Clark)
Date: Tue, 26 Apr 2022 17:17:16 GMT
Subject: RFR: CODETOOLS-7903168: Update openjdk/jtreg repo to require 1
 Reviewer
In-Reply-To: <ksfdi6vKj79-ij32jevykUKiJdZIKviB_IcS10v9r1E=.fcabc8c5-5c89-4a4a-ab46-a823002f2966@github.com>
References: <ksfdi6vKj79-ij32jevykUKiJdZIKviB_IcS10v9r1E=.fcabc8c5-5c89-4a4a-ab46-a823002f2966@github.com>
Message-ID: <pjKoX-NPGDUc72uJW4gjHmOxZljS2cfbzQncRpId9Bw=.11f24355-e592-428e-8c4b-6f17b2c47685@github.com>

On Tue, 26 Apr 2022 16:29:30 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a small change to require a "R"eviewer for changes to the jtreg repo

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.java.net/jtreg/pull/80

From iris at openjdk.java.net  Tue Apr 26 17:31:21 2022
From: iris at openjdk.java.net (Iris Clark)
Date: Tue, 26 Apr 2022 17:31:21 GMT
Subject: RFR: CODETOOLS-7903171: Fix issues related to generating internal
 API documentation
In-Reply-To: <wd6VVoZkbSYDBP-L5AQzXUQFMdil_NEjgkc46BMyeEU=.66cb2e0e-6a50-4a32-bfec-6a02518e652c@github.com>
References: <wd6VVoZkbSYDBP-L5AQzXUQFMdil_NEjgkc46BMyeEU=.66cb2e0e-6a50-4a32-bfec-6a02518e652c@github.com>
Message-ID: <KMKEKLdUHShAI9XSIIKvUa7RkISJqSu9_JrAjFlSeT4=.9c744ea4-0022-458e-a64b-5386e716a107@github.com>

On Tue, 26 Apr 2022 16:17:11 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review some trivial changes to update the makefiles and doc comments used to generate internal API documentation

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.java.net/jtreg/pull/79

From jjg at openjdk.java.net  Tue Apr 26 18:41:15 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Tue, 26 Apr 2022 18:41:15 GMT
Subject: Integrated: CODETOOLS-7903171: Fix issues related to generating
 internal API documentation
In-Reply-To: <wd6VVoZkbSYDBP-L5AQzXUQFMdil_NEjgkc46BMyeEU=.66cb2e0e-6a50-4a32-bfec-6a02518e652c@github.com>
References: <wd6VVoZkbSYDBP-L5AQzXUQFMdil_NEjgkc46BMyeEU=.66cb2e0e-6a50-4a32-bfec-6a02518e652c@github.com>
Message-ID: <F7WHrbxNx-O6ULMKD0QCqx4H1GSATJOs6QOF_La8THI=.20d5475e-0787-4ae6-b0ae-776fdc402981@github.com>

On Tue, 26 Apr 2022 16:17:11 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review some trivial changes to update the makefiles and doc comments used to generate internal API documentation

This pull request has now been integrated.

Changeset: 7966ad04
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.java.net/jtreg/commit/7966ad0415cd97971ed74b82f74a38eac1bf3eca
Stats:     23 lines in 5 files changed: 1 ins; 1 del; 21 mod

7903171: Fix issues related to generating internal API documentation

Reviewed-by: iris

-------------

PR: https://git.openjdk.java.net/jtreg/pull/79

From jjg at openjdk.java.net  Tue Apr 26 18:50:11 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Tue, 26 Apr 2022 18:50:11 GMT
Subject: Integrated: CODETOOLS-7903168: Update openjdk/jtreg repo to require 1
 Reviewer
In-Reply-To: <ksfdi6vKj79-ij32jevykUKiJdZIKviB_IcS10v9r1E=.fcabc8c5-5c89-4a4a-ab46-a823002f2966@github.com>
References: <ksfdi6vKj79-ij32jevykUKiJdZIKviB_IcS10v9r1E=.fcabc8c5-5c89-4a4a-ab46-a823002f2966@github.com>
Message-ID: <SfAZ_tFwufTKMmi9CPLv_g06lzvm1VvDYYISRHIUMX4=.e8278371-5ad9-4c1a-8756-ed22cd7854c0@github.com>

On Tue, 26 Apr 2022 16:29:30 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a small change to require a "R"eviewer for changes to the jtreg repo

This pull request has now been integrated.

Changeset: c415cd0d
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.java.net/jtreg/commit/c415cd0d5edd55204bac9dc6b10a65083e3b011d
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

7903168: Update openjdk/jtreg repo to require 1 Reviewer

Reviewed-by: iris

-------------

PR: https://git.openjdk.java.net/jtreg/pull/80

From erikj at openjdk.java.net  Tue Apr 26 20:07:05 2022
From: erikj at openjdk.java.net (Erik Joelsson)
Date: Tue, 26 Apr 2022 20:07:05 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v12]
In-Reply-To: <El8-dHgXS8MWTmnXARFwCSlNSbgGZXHvWOO0eBLL80g=.e44866f4-a1bc-4199-b798-8b9f4979c8c4@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
 <El8-dHgXS8MWTmnXARFwCSlNSbgGZXHvWOO0eBLL80g=.e44866f4-a1bc-4199-b798-8b9f4979c8c4@github.com>
Message-ID: <ADii-_cWTsKJ8D7KkgtUSGFkdZBDvQDuCGyK5YtQYP4=.ab3f7178-f73f-4959-850e-73590f4cdce1@github.com>

On Mon, 25 Apr 2022 15:52:24 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Make JUnit runner use the JUnit Platform Launcher
>> 
>> See https://bugs.openjdk.java.net/browse/CODETOOLS-7903047
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add support for `runWithJUnit4` flag

Dummy comment to trigger bots.

-------------

PR: https://git.openjdk.java.net/jtreg/pull/78

From djelinski at openjdk.java.net  Thu Apr 28 12:33:58 2022
From: djelinski at openjdk.java.net (Daniel =?UTF-8?B?SmVsacWEc2tp?=)
Date: Thu, 28 Apr 2022 12:33:58 GMT
Subject: RFR: 7903151: NPE when resolving @library from jtreg plugin
In-Reply-To: <vcbUNDr1V80ggR3Q_ILuXzBoPyyhcZEFLW1KfzpQ3ZU=.8ebc7da8-a801-401f-966b-da79888235ec@github.com>
References: <vcbUNDr1V80ggR3Q_ILuXzBoPyyhcZEFLW1KfzpQ3ZU=.8ebc7da8-a801-401f-966b-da79888235ec@github.com>
Message-ID: <0Qi_-uJtOg00I8j9ZpjJ0bFRNYy0L6lKGxD_LGPicFQ=.da312929-906c-458d-8088-469893115d6d@github.com>

On Fri, 8 Apr 2022 14:25:21 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> This pathc fixes a trivial NPE which occurs when the plugin is attempting to resolve an absolute library in a `@library` tag. If no library is found starting from TEST.ROOT, and if TEST.ROOT does not specify any alternate library root, the plugin fails with a NPE, as the code is eagerly trimming the property value "external.lib.roots", which might not exist.
> 
> The solution is simple, e.g. check for null before trimming.

plugins/idea/build.gradle line 29:

> 27: // See https://github.com/JetBrains/gradle-intellij-plugin/
> 28: intellij {
> 29:     version = '2021.3.3'

Suggestion:

    version = project.findProperty('intellijVersion') ?: '2021.3.3'

while at it, you could also update the docs on `intellijVersion` [here](https://github.com/openjdk/jtreg/blob/master/plugins/idea/README.md?plain=1#L41)

-------------

PR: https://git.openjdk.java.net/jtreg/pull/70

From mcimadamore at openjdk.java.net  Thu Apr 28 13:28:52 2022
From: mcimadamore at openjdk.java.net (Maurizio Cimadamore)
Date: Thu, 28 Apr 2022 13:28:52 GMT
Subject: RFR: 7903151: NPE when resolving @library from jtreg plugin [v2]
In-Reply-To: <vcbUNDr1V80ggR3Q_ILuXzBoPyyhcZEFLW1KfzpQ3ZU=.8ebc7da8-a801-401f-966b-da79888235ec@github.com>
References: <vcbUNDr1V80ggR3Q_ILuXzBoPyyhcZEFLW1KfzpQ3ZU=.8ebc7da8-a801-401f-966b-da79888235ec@github.com>
Message-ID: <XwW9uAbi2BgTwceRrsYLgSS32RtSBnQPdZVXvK378_M=.e21d9adc-acc6-47d3-8473-413b28d314d4@github.com>

> This pathc fixes a trivial NPE which occurs when the plugin is attempting to resolve an absolute library in a `@library` tag. If no library is found starting from TEST.ROOT, and if TEST.ROOT does not specify any alternate library root, the plugin fails with a NPE, as the code is eagerly trimming the property value "external.lib.roots", which might not exist.
> 
> The solution is simple, e.g. check for null before trimming.

Maurizio Cimadamore has updated the pull request incrementally with two additional commits since the last revision:

 - Fix typo in gradle.properties
 - Use gradle property to specify version of IntelliJ dependency
   Fix readme

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/70/files
  - new: https://git.openjdk.java.net/jtreg/pull/70/files/a05c1bab..345b5f12

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=70&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=70&range=00-01

  Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/70.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/70/head:pull/70

PR: https://git.openjdk.java.net/jtreg/pull/70

From cstein at openjdk.java.net  Thu Apr 28 13:47:58 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 28 Apr 2022 13:47:58 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v12]
In-Reply-To: <ADii-_cWTsKJ8D7KkgtUSGFkdZBDvQDuCGyK5YtQYP4=.ab3f7178-f73f-4959-850e-73590f4cdce1@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
 <El8-dHgXS8MWTmnXARFwCSlNSbgGZXHvWOO0eBLL80g=.e44866f4-a1bc-4199-b798-8b9f4979c8c4@github.com>
 <ADii-_cWTsKJ8D7KkgtUSGFkdZBDvQDuCGyK5YtQYP4=.ab3f7178-f73f-4959-850e-73590f4cdce1@github.com>
Message-ID: <pKA1j4kwh1NZuTuD-6fyUuCNGQKOxKWPYwLmIGvaaCA=.f84ddc42-ca33-4400-a98a-d705bb22e297@github.com>

On Tue, 26 Apr 2022 20:03:51 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> Dummy comment to trigger bots.

Did bots what bots had to do?

-------------

PR: https://git.openjdk.java.net/jtreg/pull/78

From cstein at openjdk.java.net  Thu Apr 28 13:48:05 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 28 Apr 2022 13:48:05 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v12]
In-Reply-To: <tTOvk0fI545N1ckaAE3oluu9yhy7AJ9SqWhU2Os-X2A=.43c55ce8-a0bd-458e-b353-8d0b0524be95@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
 <El8-dHgXS8MWTmnXARFwCSlNSbgGZXHvWOO0eBLL80g=.e44866f4-a1bc-4199-b798-8b9f4979c8c4@github.com>
 <tTOvk0fI545N1ckaAE3oluu9yhy7AJ9SqWhU2Os-X2A=.43c55ce8-a0bd-458e-b353-8d0b0524be95@github.com>
Message-ID: <tn_qGwODBe1WG8MICjghCo3KCrVi5Brl5mCE2S2bsLc=.69444a7e-36c4-47db-a7c4-63152c747faa@github.com>

On Mon, 25 Apr 2022 19:19:41 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add support for `runWithJUnit4` flag
>
> src/share/classes/com/sun/javatest/regtest/agent/JUnitRunner.java line 46:
> 
>> 44: public class JUnitRunner implements MainActionHelper.TestRunner {
>> 45:     private static final String
>> 46:         JUNIT_NO_DRIVER        = "No JUnit driver (install junit-platform-console-standalone.jar next to jtreg.jar)";
> 
> The code should not specifically require this jar file by name. We went to an effort recently to decouple the names of the jar files used to build jtreg from the code that uses them.
> Admittedly, this string literal was an accidental oversight from that recent work. I suggest changing the name of the jar file to just `JUnit` or `JUnit jar file(s)`

Changed to `JUnit JAR file(s)`.

> src/share/classes/com/sun/javatest/regtest/agent/JUnitRunner.java line 48:
> 
>> 46:         JUNIT_NO_DRIVER        = "No JUnit driver (install junit-platform-console-standalone.jar next to jtreg.jar)";
>> 47:     private static final boolean
>> 48:         JUNIT_RUN_WITH_JUNIT_4 = Flags.get("runWithJUnit4");
> 
> suggest adding comment that this is temporary, during the transition.

Comment added.

> src/share/classes/com/sun/javatest/regtest/agent/JUnitRunner.java line 140:
> 
>> 138:                     summary.printTo(pw);
>> 139:                 }
>> 140:                 System.err.println(sw);
> 
> printing to `System.err` may be an issue; this is happening on the test-side, isn't it?

It's doing the same as the JUnit 4 runner already did before. Thus, it shouldn't introduce new issues.

> test/junitTrace/JUnitTrace.gmk line 35:
> 
>> 33: 		-w:$(@:%.ok=%)/work -r:$(@:%.ok=%)/report \
>> 34: 		-jdk:$(JDKHOME) \
>> 35: 		-agentvm \
> 
> It might be better to upgrade this test to run in both modes (othervm, agentvm), although maybe that could be could separately

I agree ? should be done in separate PR to keep the changes of this PR focussed around making the JUnit Platform Launcher work.

-------------

PR: https://git.openjdk.java.net/jtreg/pull/78

From cstein at openjdk.java.net  Thu Apr 28 13:48:07 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 28 Apr 2022 13:48:07 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v12]
In-Reply-To: <C0r6gcFx7AHjNfo3scMDSXCB-XZm_s0vw0O1OErxH9E=.0fc76ce0-ab4f-484a-a356-0d85150415d5@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
 <El8-dHgXS8MWTmnXARFwCSlNSbgGZXHvWOO0eBLL80g=.e44866f4-a1bc-4199-b798-8b9f4979c8c4@github.com>
 <1WZhFes3-j7iKq8CnzPCk91_jJj9p4xDb2DxiSBE1jM=.a0f34735-cc0f-4326-8b75-7d0154c03684@github.com>
 <C0r6gcFx7AHjNfo3scMDSXCB-XZm_s0vw0O1OErxH9E=.0fc76ce0-ab4f-484a-a356-0d85150415d5@github.com>
Message-ID: <HSk8hcxgvqsozODzlYVO_0JqCzkbHPD5KWfDSlCj2dY=.00497742-12b0-4952-9872-dbd61376f230@github.com>

On Mon, 25 Apr 2022 19:32:00 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> src/share/classes/com/sun/javatest/regtest/agent/JUnitRunner.java line 114:
>> 
>>> 112:     private static void runWithJUnitPlatform(Class<?> mainClass) throws Exception {
>>> 113:         // https://junit.org/junit5/docs/current/user-guide/#launcher-api-execution
>>> 114:         Thread.currentThread().setContextClassLoader(mainClass.getClassLoader());
>> 
>> this line, to set the context class loader, might be an issue for some core-libs tests.
>
> ... I guess it might just mean we can't use JUnit Jupiter for some of the low-level core-libs tests

Yes, either that or we find another way to make those core-libs tests and JUnit happy by agreeing upon a class loader.

-------------

PR: https://git.openjdk.java.net/jtreg/pull/78

From cstein at openjdk.java.net  Thu Apr 28 13:54:45 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 28 Apr 2022 13:54:45 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v13]
In-Reply-To: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
Message-ID: <kDei2mlAdbIBVXRBLOFFT2APQw_ofiQi6Xr2xIVFVT4=.f1fbe021-0bbe-4642-a04a-6a132f8e4985@github.com>

> Make JUnit runner use the JUnit Platform Launcher
> 
> See https://bugs.openjdk.java.net/browse/CODETOOLS-7903047

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Address review comments

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/78/files
  - new: https://git.openjdk.java.net/jtreg/pull/78/files/5454a561..fff3c159

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=12
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=11-12

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/78/head:pull/78

PR: https://git.openjdk.java.net/jtreg/pull/78

From cstein at openjdk.java.net  Thu Apr 28 14:17:59 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 28 Apr 2022 14:17:59 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v12]
In-Reply-To: <pKA1j4kwh1NZuTuD-6fyUuCNGQKOxKWPYwLmIGvaaCA=.f84ddc42-ca33-4400-a98a-d705bb22e297@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
 <El8-dHgXS8MWTmnXARFwCSlNSbgGZXHvWOO0eBLL80g=.e44866f4-a1bc-4199-b798-8b9f4979c8c4@github.com>
 <ADii-_cWTsKJ8D7KkgtUSGFkdZBDvQDuCGyK5YtQYP4=.ab3f7178-f73f-4959-850e-73590f4cdce1@github.com>
 <pKA1j4kwh1NZuTuD-6fyUuCNGQKOxKWPYwLmIGvaaCA=.f84ddc42-ca33-4400-a98a-d705bb22e297@github.com>
Message-ID: <TgdF8rHTir0jmj_oF7JDf7T5S8qMzGLHPEV3O2fCGIc=.07a4cafe-a73a-4b23-857e-f4f43aa19c07@github.com>

On Thu, 28 Apr 2022 13:44:40 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Dummy comment to trigger bots.
>
> Did bots what bots had to do?

Ah, now bot removed the `ready` label. Good bot!

![image](https://user-images.githubusercontent.com/2319838/165772472-1d5a868b-977b-48e3-b8bc-476ef4ae14c9.png)

-------------

PR: https://git.openjdk.java.net/jtreg/pull/78

From djelinski at openjdk.java.net  Thu Apr 28 14:40:09 2022
From: djelinski at openjdk.java.net (Daniel =?UTF-8?B?SmVsacWEc2tp?=)
Date: Thu, 28 Apr 2022 14:40:09 GMT
Subject: RFR: 7903151: NPE when resolving @library from jtreg plugin [v2]
In-Reply-To: <XwW9uAbi2BgTwceRrsYLgSS32RtSBnQPdZVXvK378_M=.e21d9adc-acc6-47d3-8473-413b28d314d4@github.com>
References: <vcbUNDr1V80ggR3Q_ILuXzBoPyyhcZEFLW1KfzpQ3ZU=.8ebc7da8-a801-401f-966b-da79888235ec@github.com>
 <XwW9uAbi2BgTwceRrsYLgSS32RtSBnQPdZVXvK378_M=.e21d9adc-acc6-47d3-8473-413b28d314d4@github.com>
Message-ID: <DxBKGN3oaRZKU5oqO72j6Y0ijmVRixWNd8-VeBla33g=.38f69942-b1fc-4676-895b-6c3a466f7b3c@github.com>

On Thu, 28 Apr 2022 13:28:52 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This pathc fixes a trivial NPE which occurs when the plugin is attempting to resolve an absolute library in a `@library` tag. If no library is found starting from TEST.ROOT, and if TEST.ROOT does not specify any alternate library root, the plugin fails with a NPE, as the code is eagerly trimming the property value "external.lib.roots", which might not exist.
>> 
>> The solution is simple, e.g. check for null before trimming.
>
> Maurizio Cimadamore has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix typo in gradle.properties
>  - Use gradle property to specify version of IntelliJ dependency
>    Fix readme

LGTM

-------------

Marked as reviewed by djelinski (no project role).

PR: https://git.openjdk.java.net/jtreg/pull/70

From jjg at openjdk.java.net  Thu Apr 28 14:48:16 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Thu, 28 Apr 2022 14:48:16 GMT
Subject: RFR: 7903151: NPE when resolving @library from jtreg plugin [v2]
In-Reply-To: <XwW9uAbi2BgTwceRrsYLgSS32RtSBnQPdZVXvK378_M=.e21d9adc-acc6-47d3-8473-413b28d314d4@github.com>
References: <vcbUNDr1V80ggR3Q_ILuXzBoPyyhcZEFLW1KfzpQ3ZU=.8ebc7da8-a801-401f-966b-da79888235ec@github.com>
 <XwW9uAbi2BgTwceRrsYLgSS32RtSBnQPdZVXvK378_M=.e21d9adc-acc6-47d3-8473-413b28d314d4@github.com>
Message-ID: <6bPYS8qx5Qq5gntV3cqPTkVjGxW4gxNz9c9GsNg3k6g=.0b8df358-a64f-4da0-81be-ec8b1e9ebcd4@github.com>

On Thu, 28 Apr 2022 13:28:52 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This patch fixes a trivial NPE which occurs when the plugin is attempting to resolve an absolute library in a `@library` tag. If no library is found starting from TEST.ROOT, and if TEST.ROOT does not specify any alternate library root, the plugin fails with a NPE, as the code is eagerly trimming the property value "external.lib.roots", which might not exist.
>> 
>> The solution is simple, e.g. check for null before trimming.
>
> Maurizio Cimadamore has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix typo in gradle.properties
>  - Use gradle property to specify version of IntelliJ dependency
>    Fix readme

Marked as reviewed by jjg (Lead).

-------------

PR: https://git.openjdk.java.net/jtreg/pull/70

From cstein at openjdk.java.net  Thu Apr 28 19:25:47 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 28 Apr 2022 19:25:47 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v14]
In-Reply-To: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
Message-ID: <A4i1Jbun_x4D4KIrXpsc1FVa4kMwXn_6qB11MehJPS4=.27aef862-1a5e-4f0a-96af-5a8b07b79845@github.com>

> Make JUnit runner use the JUnit Platform Launcher
> 
> See https://bugs.openjdk.java.net/browse/CODETOOLS-7903047

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Run in `agent` and `other` VM mode

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/78/files
  - new: https://git.openjdk.java.net/jtreg/pull/78/files/fff3c159..b2e0fd27

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=13
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=12-13

  Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/78/head:pull/78

PR: https://git.openjdk.java.net/jtreg/pull/78

From cstein at openjdk.java.net  Thu Apr 28 19:25:51 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 28 Apr 2022 19:25:51 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v12]
In-Reply-To: <tn_qGwODBe1WG8MICjghCo3KCrVi5Brl5mCE2S2bsLc=.69444a7e-36c4-47db-a7c4-63152c747faa@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
 <El8-dHgXS8MWTmnXARFwCSlNSbgGZXHvWOO0eBLL80g=.e44866f4-a1bc-4199-b798-8b9f4979c8c4@github.com>
 <tTOvk0fI545N1ckaAE3oluu9yhy7AJ9SqWhU2Os-X2A=.43c55ce8-a0bd-458e-b353-8d0b0524be95@github.com>
 <tn_qGwODBe1WG8MICjghCo3KCrVi5Brl5mCE2S2bsLc=.69444a7e-36c4-47db-a7c4-63152c747faa@github.com>
Message-ID: <onugjLbH3U3FqdMCedy3nRQQnxoXRX20Z6k5-j7I16s=.97dc1abe-8d29-4ff5-85d2-bfe00a2b9bdc@github.com>

On Thu, 28 Apr 2022 13:43:51 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> test/junitTrace/JUnitTrace.gmk line 35:
>> 
>>> 33: 		-w:$(@:%.ok=%)/work -r:$(@:%.ok=%)/report \
>>> 34: 		-jdk:$(JDKHOME) \
>>> 35: 		-agentvm \
>> 
>> It might be better to upgrade this test to run in both modes (othervm, agentvm), although maybe that could be could separately
>
> I agree ? should be done in separate PR to keep the changes of this PR focussed around making the JUnit Platform Launcher work.

Done via https://github.com/openjdk/jtreg/pull/78/commits/b2e0fd27f63eb5b25fa2554b135ea8a25d24d196

-------------

PR: https://git.openjdk.java.net/jtreg/pull/78

From cstein at openjdk.java.net  Thu Apr 28 19:33:53 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 28 Apr 2022 19:33:53 GMT
Subject: RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher
 [v15]
In-Reply-To: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
References: <mkfjDVdPuKgR8iF08WkNEcoBlRxymkNP53ziUEi9P1c=.b732e297-7efa-4400-b69e-69062943fcac@github.com>
Message-ID: <FpBXyU678lXl-vUUOUYvHeNnSr3P5XKkh9hp98Y0h3k=.0fe8750d-e102-4106-8c69-d31b275de889@github.com>

> Make JUnit runner use the JUnit Platform Launcher
> 
> See https://bugs.openjdk.java.net/browse/CODETOOLS-7903047

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Fix typo

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/78/files
  - new: https://git.openjdk.java.net/jtreg/pull/78/files/b2e0fd27..4fe0743c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=14
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=78&range=13-14

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/78/head:pull/78

PR: https://git.openjdk.java.net/jtreg/pull/78

From mcimadamore at openjdk.java.net  Thu Apr 28 20:46:06 2022
From: mcimadamore at openjdk.java.net (Maurizio Cimadamore)
Date: Thu, 28 Apr 2022 20:46:06 GMT
Subject: Integrated: 7903151: NPE when resolving @library from jtreg plugin
In-Reply-To: <vcbUNDr1V80ggR3Q_ILuXzBoPyyhcZEFLW1KfzpQ3ZU=.8ebc7da8-a801-401f-966b-da79888235ec@github.com>
References: <vcbUNDr1V80ggR3Q_ILuXzBoPyyhcZEFLW1KfzpQ3ZU=.8ebc7da8-a801-401f-966b-da79888235ec@github.com>
Message-ID: <3bhmpbN6ih4VTuTukoCpSYpxy8KsL-BfJeBTGG71ce0=.4e45b39a-5ae3-4d3c-ae93-7ff42640b73f@github.com>

On Fri, 8 Apr 2022 14:25:21 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> This patch fixes a trivial NPE which occurs when the plugin is attempting to resolve an absolute library in a `@library` tag. If no library is found starting from TEST.ROOT, and if TEST.ROOT does not specify any alternate library root, the plugin fails with a NPE, as the code is eagerly trimming the property value "external.lib.roots", which might not exist.
> 
> The solution is simple, e.g. check for null before trimming.

This pull request has now been integrated.

Changeset: bc75e5f4
Author:    Maurizio Cimadamore <mcimadamore at openjdk.org>
URL:       https://git.openjdk.java.net/jtreg/commit/bc75e5f4bec2160bf850dd30597cb4e0016ab5f5
Stats:     7 lines in 4 files changed: 2 ins; 0 del; 5 mod

7903151: NPE when resolving @library from jtreg plugin

Reviewed-by: djelinski, jjg

-------------

PR: https://git.openjdk.java.net/jtreg/pull/70

From jjg at openjdk.java.net  Thu Apr 28 21:20:30 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Thu, 28 Apr 2022 21:20:30 GMT
Subject: RFR: CODETOOLS-7903172: Change invocation of GitHub Actions
Message-ID: <vpZqzwH8sv7L2m8PFVDGdO7iCyl-S86ZZJ93ubKyoNQ=.12a619cb-ac9c-4b6e-9187-24c73f02350b@github.com>

Update the events for GitHub Actions to better align with JDK.

-------------

Commit messages:
 - CODETOOLS-7903172: Change invocation of GitHub Actions

Changes: https://git.openjdk.java.net/jtreg/pull/81/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=81&range=00
  Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903172
  Stats: 6 lines in 1 file changed: 0 ins; 3 del; 3 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/81.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/81/head:pull/81

PR: https://git.openjdk.java.net/jtreg/pull/81

From kcr at openjdk.java.net  Thu Apr 28 23:43:02 2022
From: kcr at openjdk.java.net (Kevin Rushforth)
Date: Thu, 28 Apr 2022 23:43:02 GMT
Subject: RFR: CODETOOLS-7903172: Change invocation of GitHub Actions
In-Reply-To: <vpZqzwH8sv7L2m8PFVDGdO7iCyl-S86ZZJ93ubKyoNQ=.12a619cb-ac9c-4b6e-9187-24c73f02350b@github.com>
References: <vpZqzwH8sv7L2m8PFVDGdO7iCyl-S86ZZJ93ubKyoNQ=.12a619cb-ac9c-4b6e-9187-24c73f02350b@github.com>
Message-ID: <82W4_3aLa2ASRYn6FK4niRP6RHRNyAPM_HCZrWGLySg=.c7359163-6611-484d-99f1-b3372cf10707@github.com>

On Thu, 28 Apr 2022 21:14:47 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Update the events for GitHub Actions to better align with JDK.

.github/workflows/test.yml line 4:

> 2: 
> 3: on:
> 4:   branches-ignore:

Looks like you deleted one too many lines. You need "push:" before this line.

-------------

PR: https://git.openjdk.java.net/jtreg/pull/81

From jjg at openjdk.java.net  Fri Apr 29 00:51:42 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Fri, 29 Apr 2022 00:51:42 GMT
Subject: RFR: CODETOOLS-7903172: Change invocation of GitHub Actions [v2]
In-Reply-To: <vpZqzwH8sv7L2m8PFVDGdO7iCyl-S86ZZJ93ubKyoNQ=.12a619cb-ac9c-4b6e-9187-24c73f02350b@github.com>
References: <vpZqzwH8sv7L2m8PFVDGdO7iCyl-S86ZZJ93ubKyoNQ=.12a619cb-ac9c-4b6e-9187-24c73f02350b@github.com>
Message-ID: <GM1zRSFg5zGQEkBAUOBIt9cUy1dwjJBePIBJvPhwlF0=.cfc1c5ee-7cce-4bf2-ba15-418346963370@github.com>

> Update the events for GitHub Actions to better align with JDK.

Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:

  fix bad copy-paste

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/81/files
  - new: https://git.openjdk.java.net/jtreg/pull/81/files/11725e3d..828d0ee5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=81&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=81&range=00-01

  Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/81.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/81/head:pull/81

PR: https://git.openjdk.java.net/jtreg/pull/81

From jjg at openjdk.java.net  Fri Apr 29 00:51:42 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Fri, 29 Apr 2022 00:51:42 GMT
Subject: RFR: CODETOOLS-7903172: Change invocation of GitHub Actions [v2]
In-Reply-To: <82W4_3aLa2ASRYn6FK4niRP6RHRNyAPM_HCZrWGLySg=.c7359163-6611-484d-99f1-b3372cf10707@github.com>
References: <vpZqzwH8sv7L2m8PFVDGdO7iCyl-S86ZZJ93ubKyoNQ=.12a619cb-ac9c-4b6e-9187-24c73f02350b@github.com>
 <82W4_3aLa2ASRYn6FK4niRP6RHRNyAPM_HCZrWGLySg=.c7359163-6611-484d-99f1-b3372cf10707@github.com>
Message-ID: <A3VKBux7dllHBH6L8fZtH2_eEEKKTJpotXhfX7PTnZQ=.f4c4a524-a68b-475f-8d7f-c1d19db83c29@github.com>

On Thu, 28 Apr 2022 23:38:11 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix bad copy-paste
>
> .github/workflows/test.yml line 4:
> 
>> 2: 
>> 3: on:
>> 4:   branches-ignore:
> 
> Looks like you deleted one too many lines. You need "push:" before this line.

Ooops, thanks for spotting that.

-------------

PR: https://git.openjdk.java.net/jtreg/pull/81

From kcr at openjdk.java.net  Fri Apr 29 12:15:08 2022
From: kcr at openjdk.java.net (Kevin Rushforth)
Date: Fri, 29 Apr 2022 12:15:08 GMT
Subject: RFR: CODETOOLS-7903172: Change invocation of GitHub Actions [v2]
In-Reply-To: <GM1zRSFg5zGQEkBAUOBIt9cUy1dwjJBePIBJvPhwlF0=.cfc1c5ee-7cce-4bf2-ba15-418346963370@github.com>
References: <vpZqzwH8sv7L2m8PFVDGdO7iCyl-S86ZZJ93ubKyoNQ=.12a619cb-ac9c-4b6e-9187-24c73f02350b@github.com>
 <GM1zRSFg5zGQEkBAUOBIt9cUy1dwjJBePIBJvPhwlF0=.cfc1c5ee-7cce-4bf2-ba15-418346963370@github.com>
Message-ID: <_qaw1VogUfwN3mx7HqcMbdI-v150Fc0kVh8XaXCzrrA=.66783b75-57c5-48eb-9f8a-7de0a077ca82@github.com>

On Fri, 29 Apr 2022 00:51:42 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Update the events for GitHub Actions to better align with JDK.
>
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix bad copy-paste

Marked as reviewed by kcr (no project role).

-------------

PR: https://git.openjdk.java.net/jtreg/pull/81

From iris at openjdk.java.net  Fri Apr 29 17:44:56 2022
From: iris at openjdk.java.net (Iris Clark)
Date: Fri, 29 Apr 2022 17:44:56 GMT
Subject: RFR: CODETOOLS-7903172: Change invocation of GitHub Actions [v2]
In-Reply-To: <GM1zRSFg5zGQEkBAUOBIt9cUy1dwjJBePIBJvPhwlF0=.cfc1c5ee-7cce-4bf2-ba15-418346963370@github.com>
References: <vpZqzwH8sv7L2m8PFVDGdO7iCyl-S86ZZJ93ubKyoNQ=.12a619cb-ac9c-4b6e-9187-24c73f02350b@github.com>
 <GM1zRSFg5zGQEkBAUOBIt9cUy1dwjJBePIBJvPhwlF0=.cfc1c5ee-7cce-4bf2-ba15-418346963370@github.com>
Message-ID: <zg2iWTqvX1s8dFRPvenwxQF9u7kKYY5ehfkCHYKqeM8=.4237111f-e20e-4c1c-bba6-b36b9cbe9294@github.com>

On Fri, 29 Apr 2022 00:51:42 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Update the events for GitHub Actions to better align with JDK.
>
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix bad copy-paste

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.java.net/jtreg/pull/81

From jjg at openjdk.java.net  Fri Apr 29 19:02:00 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Fri, 29 Apr 2022 19:02:00 GMT
Subject: Integrated: CODETOOLS-7903172: Change invocation of GitHub Actions
In-Reply-To: <vpZqzwH8sv7L2m8PFVDGdO7iCyl-S86ZZJ93ubKyoNQ=.12a619cb-ac9c-4b6e-9187-24c73f02350b@github.com>
References: <vpZqzwH8sv7L2m8PFVDGdO7iCyl-S86ZZJ93ubKyoNQ=.12a619cb-ac9c-4b6e-9187-24c73f02350b@github.com>
Message-ID: <uM2TG0xDiT8mxRlt5YzfOJ9Aw4VlEql6oExZVEaEUGI=.c33bc6ca-8273-4496-9576-8e0ad5de4c46@github.com>

On Thu, 28 Apr 2022 21:14:47 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Update the events for GitHub Actions to better align with JDK.

This pull request has now been integrated.

Changeset: ba60f75d
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.java.net/jtreg/commit/ba60f75d93fda32f4ab075dd80af48e66ee395e7
Stats:     4 lines in 1 file changed: 0 ins; 2 del; 2 mod

7903172: Change invocation of GitHub Actions

Reviewed-by: kcr, iris

-------------

PR: https://git.openjdk.java.net/jtreg/pull/81