RFR: 7903159: Make jtreg self-tests run on Windows/Cygwin [v2]
Jonathan Gibbons
jjg at openjdk.java.net
Wed Apr 13 21:31:37 UTC 2022
On Wed, 13 Apr 2022 19:55:09 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> Prior to this commit some of `jtreg`'s self-tests failed on Windows/Cygwin systems.
>>
>> This commit fixes this mainly by adjusting assertions expecting Windows-style paths, `\r\n` line-breaks, and ignoring/normalizing other differences compared to Unix-based systems.
>>
>> https://bugs.openjdk.java.net/browse/CODETOOLS-7903159
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix typo
Good work.
There's more than one way to solve most of these (annoying) problems/differences, and we might want to tweak the style as we figure out more appropriate solutions. But for now, this establishes a good baseline.
test/nativepath/NativesOK.java line 36:
> 34: String j_l_path = System.getProperty("java.library.path");
> 35: String t_native = System.getProperty("test.nativepath");
> 36: String c_native = System.getProperty("correct.nativepath").replace("/", File.separator);
the name "correct.nativepath" is slightly off, since it needs to be fixed up, but well, ... it works!
-------------
Marked as reviewed by jjg (Lead).
PR: https://git.openjdk.java.net/jtreg/pull/74
More information about the jtreg-dev
mailing list