RFR: 7903160: Run self-tests for jtreg on MacOS and Windows [v10]

Jonathan Gibbons jjg at openjdk.java.net
Fri Apr 15 16:31:02 UTC 2022


On Fri, 15 Apr 2022 06:23:40 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> CI builds including self-tests for `jtreg` are run on Linux.
>> 
>> Now, they also run on MacOS and Windows.
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Install more Cygwin packages

make/CheckJavaOSVersion.java line 37:

> 35:     private static void checkJavaOSVersion(String expectVersion) {
> 36:         String osVersion = System.getProperty("os.version");
> 37:         if (!osVersion.startsWith(expectVersion)) {

This change seems questionable.

`os.version` is supposed to reflect (`.equals`) the OS version. We should at least understand why it is being reporting as a leading substring.   
Instead of `.startsWith`, consider `.matches` with a pattern that allows optional trailing dotted digits.

-------------

PR: https://git.openjdk.java.net/jtreg/pull/75


More information about the jtreg-dev mailing list