RFR: 7903166: jtreg crashes trying to compile .jasm with enablePreview=true [v2]

[Evgeny Nikitin]

On Fri, 15 Apr 2022 16:05:12 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Evgeny Nikitin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Test for runJavac variable prior adding --enable-preview
>
> src/share/classes/com/sun/javatest/regtest/exec/CompileAction.java line 367:
> 
>> 365:         }
>> 366: 
>> 367:         if (insertPos != -1 && script.enablePreview() && !seenEnablePreview) {
> 
> The fix would be clearer and more self-explanatory if you used the boolean `runJavac`. instead of the expression `insertPos != -1`.  It is already the case that `runJavac` implies `insertPos` is not `-1`.

Argh, missed that variable. Agreed, that would be better. Fixed.

-------------

PR: https://git.openjdk.java.net/jtreg/pull/77