RFR: 7903047: Make JUnit runner use the JUnit Platform Launcher [v12]
Jonathan Gibbons
jjg at openjdk.java.net
Mon Apr 25 19:23:57 UTC 2022
On Mon, 25 Apr 2022 15:52:24 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> Make JUnit runner use the JUnit Platform Launcher
>>
>> See https://bugs.openjdk.java.net/browse/CODETOOLS-7903047
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>
> Add support for `runWithJUnit4` flag
src/share/classes/com/sun/javatest/regtest/agent/JUnitRunner.java line 46:
> 44: public class JUnitRunner implements MainActionHelper.TestRunner {
> 45: private static final String
> 46: JUNIT_NO_DRIVER = "No JUnit driver (install junit-platform-console-standalone.jar next to jtreg.jar)";
The code should not specifically require this jar file by name. We went to an effort recently to decouple the names of the jar files used to build jtreg from the code that uses them.
Admittedly, this string literal was an accidental oversight from that recent work. I suggest changing the name of the jar file to just `JUnit` or `JUnit jar file(s)`
src/share/classes/com/sun/javatest/regtest/agent/JUnitRunner.java line 48:
> 46: JUNIT_NO_DRIVER = "No JUnit driver (install junit-platform-console-standalone.jar next to jtreg.jar)";
> 47: private static final boolean
> 48: JUNIT_RUN_WITH_JUNIT_4 = Flags.get("runWithJUnit4");
suggest adding comment that this is temporary, during the transition.
-------------
PR: https://git.openjdk.java.net/jtreg/pull/78
More information about the jtreg-dev
mailing list