RFR: 7903151: NPE when resolving @library from jtreg plugin

[Daniel Jeliński]

On Fri, 8 Apr 2022 14:25:21 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> This pathc fixes a trivial NPE which occurs when the plugin is attempting to resolve an absolute library in a `@library` tag. If no library is found starting from TEST.ROOT, and if TEST.ROOT does not specify any alternate library root, the plugin fails with a NPE, as the code is eagerly trimming the property value "external.lib.roots", which might not exist.
> 
> The solution is simple, e.g. check for null before trimming.

plugins/idea/build.gradle line 29:

> 27: // See https://github.com/JetBrains/gradle-intellij-plugin/
> 28: intellij {
> 29:     version = '2021.3.3'

Suggestion:

    version = project.findProperty('intellijVersion') ?: '2021.3.3'

while at it, you could also update the docs on `intellijVersion` [here](https://github.com/openjdk/jtreg/blob/master/plugins/idea/README.md?plain=1#L41)

-------------

PR: https://git.openjdk.java.net/jtreg/pull/70