RFR: 7903151: NPE when resolving @library from jtreg plugin [v2]

Daniel Jeliński djelinski at openjdk.java.net
Thu Apr 28 14:40:09 UTC 2022


On Thu, 28 Apr 2022 13:28:52 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This pathc fixes a trivial NPE which occurs when the plugin is attempting to resolve an absolute library in a `@library` tag. If no library is found starting from TEST.ROOT, and if TEST.ROOT does not specify any alternate library root, the plugin fails with a NPE, as the code is eagerly trimming the property value "external.lib.roots", which might not exist.
>> 
>> The solution is simple, e.g. check for null before trimming.
>
> Maurizio Cimadamore has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix typo in gradle.properties
>  - Use gradle property to specify version of IntelliJ dependency
>    Fix readme

LGTM

-------------

Marked as reviewed by djelinski (no project role).

PR: https://git.openjdk.java.net/jtreg/pull/70


More information about the jtreg-dev mailing list