From jjg at openjdk.org  Thu Aug 11 05:20:48 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Thu, 11 Aug 2022 05:20:48 GMT
Subject: RFR: CODETOOLS-7903244: Add FAQ entry about accessing JUnit and TestNG
 libraries
Message-ID: <BH_fN86fp49aE72mWpNWEPHgezezqkDT8_i4j0f2VLE=.503247c5-a18c-4e07-978f-cfb00abddcf1@github.com>

Please review an update to the jtreg FAQ, on how to determine the location of the TestNG and JUnit jar files.

(The underlying need is because we have  changed the names of these jar files in jtreg 7, to be the base name of the jar file provided when building jjtreg, which may contain the version number. Thus, tests should no longer assume a simple name like unit.jar and testng.jar.)

In addition, while editing the file, the IDE removed some redundant end-of-line spaces.

-------------

Commit messages:
 - CODETOOLS-7903244: Add FAQ entry about accessing JUnit and TestNG libraries

Changes: https://git.openjdk.org/jtreg/pull/99/files
 Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=99&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903244
  Stats: 41 lines in 1 file changed: 31 ins; 0 del; 10 mod
  Patch: https://git.openjdk.org/jtreg/pull/99.diff
  Fetch: git fetch https://git.openjdk.org/jtreg pull/99/head:pull/99

PR: https://git.openjdk.org/jtreg/pull/99

From jjg at openjdk.org  Thu Aug 11 05:20:53 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Thu, 11 Aug 2022 05:20:53 GMT
Subject: RFR: CODETOOLS-7903245: Save copy of `make` command after running
 `make/build.sh`
Message-ID: <P9FEMOkeYp0RjDdVla3hJc1c34rSu8tgwJXYK5nfNE0=.5fb5fc07-e01e-483f-b8e6-6541f4d80fb4@github.com>

Please review a simple change to save a copy of the make command generated by `make/build.sh`, for later reuse to bypass downloading and building dependencies.

-------------

Commit messages:
 - CODETOOLS-7903245: Save copy of `make` command after running `make/build.sh`

Changes: https://git.openjdk.org/jtreg/pull/98/files
 Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=98&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903245
  Stats: 22 lines in 1 file changed: 7 ins; 0 del; 15 mod
  Patch: https://git.openjdk.org/jtreg/pull/98.diff
  Fetch: git fetch https://git.openjdk.org/jtreg pull/98/head:pull/98

PR: https://git.openjdk.org/jtreg/pull/98

From iris at openjdk.org  Thu Aug 11 10:00:53 2022
From: iris at openjdk.org (Iris Clark)
Date: Thu, 11 Aug 2022 10:00:53 GMT
Subject: RFR: CODETOOLS-7903244: Add FAQ entry about accessing JUnit and
 TestNG libraries
In-Reply-To: <BH_fN86fp49aE72mWpNWEPHgezezqkDT8_i4j0f2VLE=.503247c5-a18c-4e07-978f-cfb00abddcf1@github.com>
References: <BH_fN86fp49aE72mWpNWEPHgezezqkDT8_i4j0f2VLE=.503247c5-a18c-4e07-978f-cfb00abddcf1@github.com>
Message-ID: <PKQBvz-O-5MRniXmiw0CY4tCR5G5iwLbF1eenZ0dH98=.1299983c-3ad9-4fdc-a4dd-a7055213a099@github.com>

On Wed, 10 Aug 2022 21:53:00 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review an update to the jtreg FAQ, on how to determine the location of the TestNG and JUnit jar files.
> 
> (The underlying need is because we have  changed the names of these jar files in jtreg 7, to be the base name of the jar file provided when building jjtreg, which may contain the version number. Thus, tests should no longer assume a simple name like unit.jar and testng.jar.)
> 
> In addition, while editing the file, the IDE removed some redundant end-of-line spaces.

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.org/jtreg/pull/99

From iris at openjdk.org  Thu Aug 11 14:37:50 2022
From: iris at openjdk.org (Iris Clark)
Date: Thu, 11 Aug 2022 14:37:50 GMT
Subject: RFR: CODETOOLS-7903245: Save copy of `make` command after running
 `make/build.sh`
In-Reply-To: <P9FEMOkeYp0RjDdVla3hJc1c34rSu8tgwJXYK5nfNE0=.5fb5fc07-e01e-483f-b8e6-6541f4d80fb4@github.com>
References: <P9FEMOkeYp0RjDdVla3hJc1c34rSu8tgwJXYK5nfNE0=.5fb5fc07-e01e-483f-b8e6-6541f4d80fb4@github.com>
Message-ID: <-6LTPntM5Q9em5FPFSIFM3YK8X7zdTmXbras369V4Zo=.7aaf541b-c835-4f12-bd3e-642fdda44f7c@github.com>

On Wed, 10 Aug 2022 21:00:42 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple change to save a copy of the make command generated by `make/build.sh`, for later reuse to bypass downloading and building dependencies.

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.org/jtreg/pull/98

From jjg at openjdk.org  Thu Aug 11 14:42:45 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Thu, 11 Aug 2022 14:42:45 GMT
Subject: Integrated: CODETOOLS-7903245: Save copy of `make` command after
 running `make/build.sh`
In-Reply-To: <P9FEMOkeYp0RjDdVla3hJc1c34rSu8tgwJXYK5nfNE0=.5fb5fc07-e01e-483f-b8e6-6541f4d80fb4@github.com>
References: <P9FEMOkeYp0RjDdVla3hJc1c34rSu8tgwJXYK5nfNE0=.5fb5fc07-e01e-483f-b8e6-6541f4d80fb4@github.com>
Message-ID: <Zgz0VVXRfyqMvyeU-bY5L06Zlr-7X12Ss3f0DvRtC9g=.58605fe4-8b05-4b64-b1e1-a0aba4ffbb32@github.com>

On Wed, 10 Aug 2022 21:00:42 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple change to save a copy of the make command generated by `make/build.sh`, for later reuse to bypass downloading and building dependencies.

This pull request has now been integrated.

Changeset: e7ed70eb
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/e7ed70ebbc433ca27c6a5a8340b1ab6bf32523c1
Stats:     22 lines in 1 file changed: 7 ins; 0 del; 15 mod

7903245: Save copy of `make` command after running `make/build.sh`

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/jtreg/pull/98

From jjg at openjdk.org  Thu Aug 11 14:44:43 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Thu, 11 Aug 2022 14:44:43 GMT
Subject: Integrated: CODETOOLS-7903244: Add FAQ entry about accessing JUnit and
 TestNG libraries
In-Reply-To: <BH_fN86fp49aE72mWpNWEPHgezezqkDT8_i4j0f2VLE=.503247c5-a18c-4e07-978f-cfb00abddcf1@github.com>
References: <BH_fN86fp49aE72mWpNWEPHgezezqkDT8_i4j0f2VLE=.503247c5-a18c-4e07-978f-cfb00abddcf1@github.com>
Message-ID: <048erZvdN5zo-TRpcoXpJ83HpR02II830vfDm5NTTWE=.6c52e69f-b704-4d61-86f3-b918aeb7f65f@github.com>

On Wed, 10 Aug 2022 21:53:00 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review an update to the jtreg FAQ, on how to determine the location of the TestNG and JUnit jar files.
> 
> (The underlying need is because we have  changed the names of these jar files in jtreg 7, to be the base name of the jar file provided when building jjtreg, which may contain the version number. Thus, tests should no longer assume a simple name like junit.jar and testng.jar.)
> 
> In addition, while editing the file, the IDE removed some redundant end-of-line spaces.

This pull request has now been integrated.

Changeset: 22ac4520
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/22ac452062be5ddd0bc8ca07c2c472b524d8bd6e
Stats:     41 lines in 1 file changed: 31 ins; 0 del; 10 mod

7903244: Add FAQ entry about accessing JUnit and TestNG libraries

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/jtreg/pull/99

From jjg at openjdk.org  Thu Aug 11 19:48:56 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Thu, 11 Aug 2022 19:48:56 GMT
Subject: RFR: CODETOOLS-7903246: Use homebrew/bin for pandoc if available
Message-ID: <4_ntVJWeVs6mPkau6gr_Q_6gW_MHWJcWIz6DPatvM4g=.cac11dad-c208-490c-ae6a-9c5011cb183f@github.com>

Please review a simple patch to include `/opt/homebrew/bin` in the list of locations to look for pandoc.

-------------

Commit messages:
 - CODETOOLS-7903246: Use homebrew/bin for pandoc if available

Changes: https://git.openjdk.org/jtreg/pull/100/files
 Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=100&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903246
  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jtreg/pull/100.diff
  Fetch: git fetch https://git.openjdk.org/jtreg pull/100/head:pull/100

PR: https://git.openjdk.org/jtreg/pull/100

From iris at openjdk.org  Thu Aug 11 19:53:56 2022
From: iris at openjdk.org (Iris Clark)
Date: Thu, 11 Aug 2022 19:53:56 GMT
Subject: RFR: CODETOOLS-7903246: Use homebrew/bin for pandoc if available
In-Reply-To: <4_ntVJWeVs6mPkau6gr_Q_6gW_MHWJcWIz6DPatvM4g=.cac11dad-c208-490c-ae6a-9c5011cb183f@github.com>
References: <4_ntVJWeVs6mPkau6gr_Q_6gW_MHWJcWIz6DPatvM4g=.cac11dad-c208-490c-ae6a-9c5011cb183f@github.com>
Message-ID: <ElEI22ss6KC9Ngr5oTZVmzCe31lnku6dSU2oVx-AYgQ=.28ada5a2-be40-41c3-8b21-16103955cb03@github.com>

On Thu, 11 Aug 2022 19:17:32 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple patch to include `/opt/homebrew/bin` in the list of locations to look for pandoc.

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.org/jtreg/pull/100

From jjg at openjdk.org  Thu Aug 11 20:36:18 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Thu, 11 Aug 2022 20:36:18 GMT
Subject: RFR: 7903217: jtreg could try killing descendants of stuck test, 
 before timing out the test
In-Reply-To: <EdrQ-aAmgSQVIN34XjqcMdlHJxpwhow0IDkxsBtGw-M=.6f881262-2039-49a7-8496-7f98caed6aa8@github.com>
References: <EdrQ-aAmgSQVIN34XjqcMdlHJxpwhow0IDkxsBtGw-M=.6f881262-2039-49a7-8496-7f98caed6aa8@github.com>
Message-ID: <0_0yJzR0O012cAMqYQFnObMgLWhNFyvF7V_MBY85lDk=.72af50d0-27d8-4042-b219-0c55e76ad54a@github.com>

On Thu, 28 Jul 2022 18:58:41 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

> This is an enhancement that aims to improve the robustness of the testing by attempting to quit any child processes (that are possibly stuck and are blocking the parent process from terminating) before timing out the target parent process.
> 
> Aborting a process will flush its stdout/stderr streams, which will hopefully get captured in the test's log and provide additional clues as to why a test was timing out.
> 
> This enhancement was locally tested with a handcrafted test that itself launched a child process that would get stuck on purpose and worked as intended.
> 
> Hopefully, this will help debug issues such as [JDK-8286345](https://bugs.openjdk.org/browse/JDK-8286345)

src/share/classes/com/sun/javatest/diff/SuperDiff.java line 286:

> 284: 
> 285:         final transient Set<String> platforms = new TreeSet<>();
> 286:         final transient Map<String, Info> infoTable = new HashMap<>();

This seems totally unrelated

-------------

PR: https://git.openjdk.org/jtreg/pull/97

From jjg at openjdk.org  Thu Aug 11 20:46:18 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Thu, 11 Aug 2022 20:46:18 GMT
Subject: RFR: 7903217: jtreg could try killing descendants of stuck test, 
 before timing out the test
In-Reply-To: <EdrQ-aAmgSQVIN34XjqcMdlHJxpwhow0IDkxsBtGw-M=.6f881262-2039-49a7-8496-7f98caed6aa8@github.com>
References: <EdrQ-aAmgSQVIN34XjqcMdlHJxpwhow0IDkxsBtGw-M=.6f881262-2039-49a7-8496-7f98caed6aa8@github.com>
Message-ID: <0g7fnN6RoKfFB3JhT5Z58jXp2lsrfEAECCxLHlxISAw=.17efd471-d55c-4b90-84a9-2df8d845e212@github.com>

On Thu, 28 Jul 2022 18:58:41 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

> This is an enhancement that aims to improve the robustness of the testing by attempting to quit any child processes (that are possibly stuck and are blocking the parent process from terminating) before timing out the target parent process.
> 
> Aborting a process will flush its stdout/stderr streams, which will hopefully get captured in the test's log and provide additional clues as to why a test was timing out.
> 
> This enhancement was locally tested with a handcrafted test that itself launched a child process that would get stuck on purpose and worked as intended.
> 
> Hopefully, this will help debug issues such as [JDK-8286345](https://bugs.openjdk.org/browse/JDK-8286345)

src/share/classes/com/sun/javatest/regtest/exec/ProcessCommand.java line 267:

> 265:                       long count = descendants.count();
> 266:                       if (count > 0) {
> 267:                         System.err.println("Detected a possibly stuck process (pid:"+pid+") with "+count+" descendants");

Don't use `System.err` directly;  use the `err` and `out` streams that were passed in when the class was invoked.

src/share/classes/com/sun/javatest/regtest/exec/ProcessCommand.java line 307:

> 305:                 alarm.cancel();
> 306: 
> 307:                 return getStatus(exitCode, statusScanner.exitStatus());

I think you need to do something more here.   If the class killed child processes, you need to ensure that (probably) `Status.error` is returned with a suitable string. In other words, consider the case where you unlock a child process and the main process exits normally for some reason. That should *not* be grounds for the test to pass.

-------------

PR: https://git.openjdk.org/jtreg/pull/97

From jjg at openjdk.org  Thu Aug 11 21:50:00 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Thu, 11 Aug 2022 21:50:00 GMT
Subject: RFR: CODETOOLS-7903250: RerunTest fails if no display is set
Message-ID: <5TYKwebHmUsII97CbJJsuCUCNYeTe6uMToKe89adNq0=.55cd7f08-431f-4b5a-85f1-0e5ed8d4adc5@github.com>

Please review a simple fix for a jtreg self-test, to set a dummy value for DISPLAY if no value already set.

-------------

Commit messages:
 - CODETOOLS-7903250: RerunTest fails if no display is set

Changes: https://git.openjdk.org/jtreg/pull/101/files
 Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=101&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903250
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jtreg/pull/101.diff
  Fetch: git fetch https://git.openjdk.org/jtreg pull/101/head:pull/101

PR: https://git.openjdk.org/jtreg/pull/101

From iris at openjdk.org  Thu Aug 11 23:36:21 2022
From: iris at openjdk.org (Iris Clark)
Date: Thu, 11 Aug 2022 23:36:21 GMT
Subject: RFR: CODETOOLS-7903250: RerunTest fails if no display is set
In-Reply-To: <5TYKwebHmUsII97CbJJsuCUCNYeTe6uMToKe89adNq0=.55cd7f08-431f-4b5a-85f1-0e5ed8d4adc5@github.com>
References: <5TYKwebHmUsII97CbJJsuCUCNYeTe6uMToKe89adNq0=.55cd7f08-431f-4b5a-85f1-0e5ed8d4adc5@github.com>
Message-ID: <FDEw4q1UjXzMuqOnKrBurFBjbHZQH0NA4_xdN2KNOj8=.a45347db-2777-4768-823a-fefbe1023d97@github.com>

On Thu, 11 Aug 2022 21:43:14 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple fix for a jtreg self-test, to set a dummy value for DISPLAY if no value already set.

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.org/jtreg/pull/101

From jjg at openjdk.org  Fri Aug 12 00:55:33 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 12 Aug 2022 00:55:33 GMT
Subject: Integrated: CODETOOLS-7903250: RerunTest fails if no display is set
In-Reply-To: <5TYKwebHmUsII97CbJJsuCUCNYeTe6uMToKe89adNq0=.55cd7f08-431f-4b5a-85f1-0e5ed8d4adc5@github.com>
References: <5TYKwebHmUsII97CbJJsuCUCNYeTe6uMToKe89adNq0=.55cd7f08-431f-4b5a-85f1-0e5ed8d4adc5@github.com>
Message-ID: <iXNlGAQjtF-d1N-1x6K4XNRZ-JND-EWOjYHHrsjKffE=.e11cb5fb-ea61-407e-93b2-f59def331745@github.com>

On Thu, 11 Aug 2022 21:43:14 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple fix for a jtreg self-test, to set a dummy value for DISPLAY if no value already set.

This pull request has now been integrated.

Changeset: 292d24b1
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/292d24b1cc856f74ee28f4ae9fb0058e87abc84a
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

7903250: RerunTest fails if no display is set

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/jtreg/pull/101

From jjg at openjdk.org  Fri Aug 12 01:35:19 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 12 Aug 2022 01:35:19 GMT
Subject: RFR: CODETOOLS-7903251: ProblemList test fails on M1 Mac
Message-ID: <T-dhB_-y945dlee7s_yvSYyF_i8fRWjA3EfE9umej8U=.8ee54641-0b09-4dbf-b748-4e9a2b2c0281@github.com>

Please review a test fix for a jtreg self-test.(There's also an update to a comment in a source file.)

This one is somewhat interesting.  Despite the name `System.getProperty("os.arch")` depends on the JDK being run, more than anything derived from `uname`.  In particular, for older JDKs on an M1 Mac, they report `os.arch` as the older `x86_64`, since older JDKs, up to JDK 11.0.15 inclusive, do not come as `aarch64` binaries.   But newer JDKs do report `os.arch` as `aarch64`.   

The fix for the test is to use the JDK being tested to update the problem-list template with the values that it will recognize when used as the test OS.  Tested with `JDKHOME` set to  JDK 11.0.15 and JDK 17.

-------------

Commit messages:
 - CODETOOLS-7903251: ProblemList test fails on M1 Mac

Changes: https://git.openjdk.org/jtreg/pull/102/files
 Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=102&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903251
  Stats: 68 lines in 3 files changed: 57 ins; 7 del; 4 mod
  Patch: https://git.openjdk.org/jtreg/pull/102.diff
  Fetch: git fetch https://git.openjdk.org/jtreg pull/102/head:pull/102

PR: https://git.openjdk.org/jtreg/pull/102

From iris at openjdk.org  Fri Aug 12 01:50:37 2022
From: iris at openjdk.org (Iris Clark)
Date: Fri, 12 Aug 2022 01:50:37 GMT
Subject: RFR: CODETOOLS-7903251: ProblemList test fails on M1 Mac
In-Reply-To: <T-dhB_-y945dlee7s_yvSYyF_i8fRWjA3EfE9umej8U=.8ee54641-0b09-4dbf-b748-4e9a2b2c0281@github.com>
References: <T-dhB_-y945dlee7s_yvSYyF_i8fRWjA3EfE9umej8U=.8ee54641-0b09-4dbf-b748-4e9a2b2c0281@github.com>
Message-ID: <LA0Ki_ztWxfEnJ-8RWRzkq-kSeRuNmsJKvZpJcx-HxY=.8993be7c-c864-41ca-9da3-40591f3dd909@github.com>

On Fri, 12 Aug 2022 01:28:42 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a test fix for a jtreg self-test.(There's also an update to a comment in a source file.)
> 
> This one is somewhat interesting.  Despite the name `System.getProperty("os.arch")` depends on the JDK being run, more than anything derived from `uname`.  In particular, for older JDKs on an M1 Mac, they report `os.arch` as the older `x86_64`, since older JDKs, up to JDK 11.0.15 inclusive, do not come as `aarch64` binaries.   But newer JDKs do report `os.arch` as `aarch64`.   
> 
> The fix for the test is to use the JDK being tested to update the problem-list template with the values that it will recognize when used as the test OS.  Tested with `JDKHOME` set to  JDK 11.0.15 and JDK 17.

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.org/jtreg/pull/102

From jjg at openjdk.org  Fri Aug 12 14:34:34 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 12 Aug 2022 14:34:34 GMT
Subject: Integrated: CODETOOLS-7903251: ProblemList test fails on M1 Mac
In-Reply-To: <T-dhB_-y945dlee7s_yvSYyF_i8fRWjA3EfE9umej8U=.8ee54641-0b09-4dbf-b748-4e9a2b2c0281@github.com>
References: <T-dhB_-y945dlee7s_yvSYyF_i8fRWjA3EfE9umej8U=.8ee54641-0b09-4dbf-b748-4e9a2b2c0281@github.com>
Message-ID: <KRyvaRm-uogkURlEKKS4zrUCzbrCY4hI4ZWuQkvdvSg=.1804ac33-7a96-4e56-bfac-6887c31a3d63@github.com>

On Fri, 12 Aug 2022 01:28:42 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a test fix for a jtreg self-test.(There's also an update to a comment in a source file.)
> 
> This one is somewhat interesting.  Despite the name `System.getProperty("os.arch")` depends on the JDK being run, more than anything derived from `uname`.  In particular, for older JDKs on an M1 Mac, they report `os.arch` as the older `x86_64`, since older JDKs, up to JDK 11.0.15 inclusive, do not come as `aarch64` binaries.   But newer JDKs do report `os.arch` as `aarch64`.   
> 
> The fix for the test is to use the JDK being tested to update the problem-list template with the values that it will recognize when used as the test OS.  Tested with `JDKHOME` set to  JDK 11.0.15 and JDK 17.

This pull request has now been integrated.

Changeset: daf8eb9c
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/daf8eb9c0c1560ed1690d93fdfdd445699400749
Stats:     68 lines in 3 files changed: 57 ins; 7 del; 4 mod

7903251: ProblemList test fails on M1 Mac

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/jtreg/pull/102

From jjg at openjdk.org  Fri Aug 12 16:09:35 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 12 Aug 2022 16:09:35 GMT
Subject: Integrated: CODETOOLS-7903246: Use homebrew/bin for pandoc if
 available
In-Reply-To: <4_ntVJWeVs6mPkau6gr_Q_6gW_MHWJcWIz6DPatvM4g=.cac11dad-c208-490c-ae6a-9c5011cb183f@github.com>
References: <4_ntVJWeVs6mPkau6gr_Q_6gW_MHWJcWIz6DPatvM4g=.cac11dad-c208-490c-ae6a-9c5011cb183f@github.com>
Message-ID: <zFuzL0MDJvVduaYkUxITU9pPRv7CJwVFyvsx1apSmMk=.13818c60-3a2f-4008-88a4-6bef663803cd@github.com>

On Thu, 11 Aug 2022 19:17:32 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple patch to include `/opt/homebrew/bin` in the list of locations to look for pandoc.

This pull request has now been integrated.

Changeset: e90154ff
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/e90154ff9b8f5c9f0a5a70b6b9a1bb6f1a3f168a
Stats:     2 lines in 1 file changed: 2 ins; 0 del; 0 mod

7903246: Use homebrew/bin for pandoc if available

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/jtreg/pull/100

From jjg at openjdk.org  Tue Aug 16 17:35:31 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Tue, 16 Aug 2022 17:35:31 GMT
Subject: RFR: CODETOOLS-7903254: Fix trailing whitespace in files
Message-ID: <x5B4VhNwofri0OyTuBHN4c6iZ_HNdjrQjRHnyHXh1mQ=.5955a159-cc1a-4665-929b-cb1222225991@github.com>

Please review a scripted update to remove trailing white space from `make` and `test` files.


grep -rl ' $' open/make open/test | xargs sed -i .BAK -e 's/  *$//'

-------------

Commit messages:
 - CODETOOLS-7903254: Fix trailing whitespace in files

Changes: https://git.openjdk.org/jtreg/pull/103/files
 Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=103&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903254
  Stats: 87 lines in 40 files changed: 0 ins; 0 del; 87 mod
  Patch: https://git.openjdk.org/jtreg/pull/103.diff
  Fetch: git fetch https://git.openjdk.org/jtreg pull/103/head:pull/103

PR: https://git.openjdk.org/jtreg/pull/103

From iris at openjdk.org  Tue Aug 16 18:22:44 2022
From: iris at openjdk.org (Iris Clark)
Date: Tue, 16 Aug 2022 18:22:44 GMT
Subject: RFR: CODETOOLS-7903254: Fix trailing whitespace in files
In-Reply-To: <x5B4VhNwofri0OyTuBHN4c6iZ_HNdjrQjRHnyHXh1mQ=.5955a159-cc1a-4665-929b-cb1222225991@github.com>
References: <x5B4VhNwofri0OyTuBHN4c6iZ_HNdjrQjRHnyHXh1mQ=.5955a159-cc1a-4665-929b-cb1222225991@github.com>
Message-ID: <1Nv60JcOfsl5Wj8QpghdjhEQsEUWKiUHcREhFfhz8mg=.22dea585-cf28-4604-b67e-101abfe1bdd8@github.com>

On Tue, 16 Aug 2022 17:29:35 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a scripted update to remove trailing white space from `make` and `test` files.
> 
> 
> grep -rl ' $' open/make open/test | xargs sed -i .BAK -e 's/  *$//'

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.org/jtreg/pull/103

From jjg at openjdk.org  Tue Aug 16 20:40:34 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Tue, 16 Aug 2022 20:40:34 GMT
Subject: Integrated: CODETOOLS-7903254: Fix trailing whitespace in files
In-Reply-To: <x5B4VhNwofri0OyTuBHN4c6iZ_HNdjrQjRHnyHXh1mQ=.5955a159-cc1a-4665-929b-cb1222225991@github.com>
References: <x5B4VhNwofri0OyTuBHN4c6iZ_HNdjrQjRHnyHXh1mQ=.5955a159-cc1a-4665-929b-cb1222225991@github.com>
Message-ID: <NqnUipeLnlF2qvc-K2EvdLoz7CYljH238Y_DTkKgMII=.0d740fbf-51bb-46d3-9e6e-e3ce8057a9b2@github.com>

On Tue, 16 Aug 2022 17:29:35 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a scripted update to remove trailing white space from `make` and `test` files.
> 
> 
> grep -rl ' $' open/make open/test | xargs sed -i .BAK -e 's/  *$//'

This pull request has now been integrated.

Changeset: 81b1343c
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/81b1343c0956ccee5abcee82a0efd7213179eeac
Stats:     87 lines in 40 files changed: 0 ins; 0 del; 87 mod

7903254: Fix trailing whitespace in files

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/jtreg/pull/103

From jjg at openjdk.org  Fri Aug 19 22:30:43 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 19 Aug 2022 22:30:43 GMT
Subject: RFR: CODETOOLS-7903256: Fix typos and grammar issues in docs and
 comments
Message-ID: <Bt9SOWJk4i1pg4F7oSh9CnzRcuC9WdL2FXLkzvHig0I=.4702ab1b-e4d9-44c5-a793-b167e75eea15@github.com>

Please review an update to fix typos and grammar errors found by inspection and by an IDE.

-------------

Commit messages:
 - CODETOOLS-7903256: Fix typos and grammar issues in docs and comments

Changes: https://git.openjdk.org/jtreg/pull/104/files
 Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=104&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903256
  Stats: 73 lines in 5 files changed: 0 ins; 1 del; 72 mod
  Patch: https://git.openjdk.org/jtreg/pull/104.diff
  Fetch: git fetch https://git.openjdk.org/jtreg pull/104/head:pull/104

PR: https://git.openjdk.org/jtreg/pull/104

From iris at openjdk.org  Fri Aug 19 23:59:47 2022
From: iris at openjdk.org (Iris Clark)
Date: Fri, 19 Aug 2022 23:59:47 GMT
Subject: RFR: CODETOOLS-7903256: Fix typos and grammar issues in docs and
 comments
In-Reply-To: <Bt9SOWJk4i1pg4F7oSh9CnzRcuC9WdL2FXLkzvHig0I=.4702ab1b-e4d9-44c5-a793-b167e75eea15@github.com>
References: <Bt9SOWJk4i1pg4F7oSh9CnzRcuC9WdL2FXLkzvHig0I=.4702ab1b-e4d9-44c5-a793-b167e75eea15@github.com>
Message-ID: <srtXamGwCVUUA_qqiies_RG7Esh7-kRTMpxFe1v905M=.91d46274-42a3-409f-9bd7-f9e954932cb1@github.com>

On Fri, 19 Aug 2022 22:24:37 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review an update to fix typos and grammar errors found by inspection and by an IDE.

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.org/jtreg/pull/104

From jjg at openjdk.org  Sat Aug 20 00:45:07 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Sat, 20 Aug 2022 00:45:07 GMT
Subject: Integrated: CODETOOLS-7903256: Fix typos and grammar issues in docs
 and comments
In-Reply-To: <Bt9SOWJk4i1pg4F7oSh9CnzRcuC9WdL2FXLkzvHig0I=.4702ab1b-e4d9-44c5-a793-b167e75eea15@github.com>
References: <Bt9SOWJk4i1pg4F7oSh9CnzRcuC9WdL2FXLkzvHig0I=.4702ab1b-e4d9-44c5-a793-b167e75eea15@github.com>
Message-ID: <XZzFOdGIJrqY_xrZ645OlyU-Nnk_8y4IMBUaveDDrmw=.135664f4-f12e-49d7-86d9-b27d10ea6ae4@github.com>

On Fri, 19 Aug 2022 22:24:37 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review an update to fix typos and grammar errors found by inspection and by an IDE.

This pull request has now been integrated.

Changeset: ef79d603
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/ef79d60334c7e3ae63449f12610b4520fd7d93b1
Stats:     73 lines in 5 files changed: 0 ins; 1 del; 72 mod

7903256: Fix typos and grammar issues in docs and comments

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/jtreg/pull/104

From gziemski at openjdk.org  Mon Aug 22 17:11:50 2022
From: gziemski at openjdk.org (Gerard Ziemski)
Date: Mon, 22 Aug 2022 17:11:50 GMT
Subject: RFR: 7903217: jtreg could try killing descendants of stuck test, 
 before timing out the test
In-Reply-To: <0_0yJzR0O012cAMqYQFnObMgLWhNFyvF7V_MBY85lDk=.72af50d0-27d8-4042-b219-0c55e76ad54a@github.com>
References: <EdrQ-aAmgSQVIN34XjqcMdlHJxpwhow0IDkxsBtGw-M=.6f881262-2039-49a7-8496-7f98caed6aa8@github.com>
 <0_0yJzR0O012cAMqYQFnObMgLWhNFyvF7V_MBY85lDk=.72af50d0-27d8-4042-b219-0c55e76ad54a@github.com>
Message-ID: <X3kAjWS-V2FSRbDNQz8FAxL8h4xgId-xhgOKRAWYpZ8=.a6335ae4-328b-4595-bfb1-1e3bcd567d00@github.com>

On Thu, 11 Aug 2022 20:32:36 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> This is an enhancement that aims to improve the robustness of the testing by attempting to quit any child processes (that are possibly stuck and are blocking the parent process from terminating) before timing out the target parent process.
>> 
>> Aborting a process will flush its stdout/stderr streams, which will hopefully get captured in the test's log and provide additional clues as to why a test was timing out.
>> 
>> This enhancement was locally tested with a handcrafted test that itself launched a child process that would get stuck on purpose and worked as intended.
>> 
>> Hopefully, this will help debug issues such as [JDK-8286345](https://bugs.openjdk.org/browse/JDK-8286345)
>
> src/share/classes/com/sun/javatest/diff/SuperDiff.java line 286:
> 
>> 284: 
>> 285:         final transient Set<String> platforms = new TreeSet<>();
>> 286:         final transient Map<String, Info> infoTable = new HashMap<>();
> 
> This seems totally unrelated

I wasn't able to compile jtreg without this modification, and I thought that including this change would help others in similar situation, but I can take it out and either leave it out completely or do a separate PR if you wish?

> src/share/classes/com/sun/javatest/regtest/exec/ProcessCommand.java line 267:
> 
>> 265:                       long count = descendants.count();
>> 266:                       if (count > 0) {
>> 267:                         System.err.println("Detected a possibly stuck process (pid:"+pid+") with "+count+" descendants");
> 
> Don't use `System.err` directly;  use the `err` and `out` streams that were passed in when the class was invoked.

Thank you, will fix.

-------------

PR: https://git.openjdk.org/jtreg/pull/97

From gziemski at openjdk.org  Mon Aug 22 17:21:30 2022
From: gziemski at openjdk.org (Gerard Ziemski)
Date: Mon, 22 Aug 2022 17:21:30 GMT
Subject: RFR: 7903217: jtreg could try killing descendants of stuck test, 
 before timing out the test
In-Reply-To: <EdrQ-aAmgSQVIN34XjqcMdlHJxpwhow0IDkxsBtGw-M=.6f881262-2039-49a7-8496-7f98caed6aa8@github.com>
References: <EdrQ-aAmgSQVIN34XjqcMdlHJxpwhow0IDkxsBtGw-M=.6f881262-2039-49a7-8496-7f98caed6aa8@github.com>
Message-ID: <UU1wSIq2aG0HG1PoZ267YsEXLZAgA9PkJbX8CWMtUko=.8721c3b8-78b2-4b14-a40d-5be2c401d9ba@github.com>

On Thu, 28 Jul 2022 18:58:41 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

> This is an enhancement that aims to improve the robustness of the testing by attempting to quit any child processes (that are possibly stuck and are blocking the parent process from terminating) before timing out the target parent process.
> 
> Aborting a process will flush its stdout/stderr streams, which will hopefully get captured in the test's log and provide additional clues as to why a test was timing out.
> 
> This enhancement was locally tested with a handcrafted test that itself launched a child process that would get stuck on purpose and worked as intended.
> 
> Hopefully, this will help debug issues such as [JDK-8286345](https://bugs.openjdk.org/browse/JDK-8286345)

Thank you Jonathan for you feedback!

-------------

PR: https://git.openjdk.org/jtreg/pull/97

From gziemski at openjdk.org  Mon Aug 22 17:21:34 2022
From: gziemski at openjdk.org (Gerard Ziemski)
Date: Mon, 22 Aug 2022 17:21:34 GMT
Subject: RFR: 7903217: jtreg could try killing descendants of stuck test, 
 before timing out the test
In-Reply-To: <0g7fnN6RoKfFB3JhT5Z58jXp2lsrfEAECCxLHlxISAw=.17efd471-d55c-4b90-84a9-2df8d845e212@github.com>
References: <EdrQ-aAmgSQVIN34XjqcMdlHJxpwhow0IDkxsBtGw-M=.6f881262-2039-49a7-8496-7f98caed6aa8@github.com>
 <0g7fnN6RoKfFB3JhT5Z58jXp2lsrfEAECCxLHlxISAw=.17efd471-d55c-4b90-84a9-2df8d845e212@github.com>
Message-ID: <Xr20rh2thxbz9kVBw2J7HaFxBiFcPGMQHMx5wr-JjTo=.86c76597-85e2-4678-b0e6-580a33c5c6be@github.com>

On Thu, 11 Aug 2022 20:40:56 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> This is an enhancement that aims to improve the robustness of the testing by attempting to quit any child processes (that are possibly stuck and are blocking the parent process from terminating) before timing out the target parent process.
>> 
>> Aborting a process will flush its stdout/stderr streams, which will hopefully get captured in the test's log and provide additional clues as to why a test was timing out.
>> 
>> This enhancement was locally tested with a handcrafted test that itself launched a child process that would get stuck on purpose and worked as intended.
>> 
>> Hopefully, this will help debug issues such as [JDK-8286345](https://bugs.openjdk.org/browse/JDK-8286345)
>
> src/share/classes/com/sun/javatest/regtest/exec/ProcessCommand.java line 307:
> 
>> 305:                 alarm.cancel();
>> 306: 
>> 307:                 return getStatus(exitCode, statusScanner.exitStatus());
> 
> I think you need to do something more here.   If the class killed child processes, you need to ensure that (probably) `Status.error` is returned with a suitable string. In other words, consider the case where you unlock a child process and the main process exits normally for some reason. That should *not* be grounds for the test to pass.

I see the point, but I also had a case where after force quitting the child process, the parent test process is able to retrieve everything it needed from the child (which finished its task required for the parent before getting itself locked up) and be able to succeed just fine.

If we were to return error code in such cases, we would be generating failures in cases where the parent process was able to finish, but its children were not. Not necessarily always directly related to the case under test, more of a tangential failure, but I do see the value in reporting such cases. I will tweak it then.

-------------

PR: https://git.openjdk.org/jtreg/pull/97

From gziemski at openjdk.org  Mon Aug 22 20:18:43 2022
From: gziemski at openjdk.org (Gerard Ziemski)
Date: Mon, 22 Aug 2022 20:18:43 GMT
Subject: RFR: 7903217: jtreg could try killing descendants of stuck test, 
 before timing out the test [v2]
In-Reply-To: <EdrQ-aAmgSQVIN34XjqcMdlHJxpwhow0IDkxsBtGw-M=.6f881262-2039-49a7-8496-7f98caed6aa8@github.com>
References: <EdrQ-aAmgSQVIN34XjqcMdlHJxpwhow0IDkxsBtGw-M=.6f881262-2039-49a7-8496-7f98caed6aa8@github.com>
Message-ID: <srOak5G4HEw8NiccOfJyfBz5yK5AT1l2r3cLkzyaw6E=.aeb10b96-d5c4-47d0-97e4-8899a69ed7f6@github.com>

> This is an enhancement that aims to improve the robustness of the testing by attempting to quit any child processes (that are possibly stuck and are blocking the parent process from terminating) before timing out the target parent process.
> 
> Aborting a process will flush its stdout/stderr streams, which will hopefully get captured in the test's log and provide additional clues as to why a test was timing out.
> 
> This enhancement was locally tested with a handcrafted test that itself launched a child process that would get stuck on purpose and worked as intended.
> 
> Hopefully, this will help debug issues such as [JDK-8286345](https://bugs.openjdk.org/browse/JDK-8286345)

Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:

  use process out stream to write meesages

-------------

Changes:
  - all: https://git.openjdk.org/jtreg/pull/97/files
  - new: https://git.openjdk.org/jtreg/pull/97/files/56707613..b2b59d44

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jtreg&pr=97&range=01
 - incr: https://webrevs.openjdk.org/?repo=jtreg&pr=97&range=00-01

  Stats: 43 lines in 1 file changed: 19 ins; 1 del; 23 mod
  Patch: https://git.openjdk.org/jtreg/pull/97.diff
  Fetch: git fetch https://git.openjdk.org/jtreg pull/97/head:pull/97

PR: https://git.openjdk.org/jtreg/pull/97

From gziemski at openjdk.org  Mon Aug 22 20:22:59 2022
From: gziemski at openjdk.org (Gerard Ziemski)
Date: Mon, 22 Aug 2022 20:22:59 GMT
Subject: RFR: 7903217: jtreg could try killing descendants of stuck test, 
 before timing out the test [v2]
In-Reply-To: <X3kAjWS-V2FSRbDNQz8FAxL8h4xgId-xhgOKRAWYpZ8=.a6335ae4-328b-4595-bfb1-1e3bcd567d00@github.com>
References: <EdrQ-aAmgSQVIN34XjqcMdlHJxpwhow0IDkxsBtGw-M=.6f881262-2039-49a7-8496-7f98caed6aa8@github.com>
 <0_0yJzR0O012cAMqYQFnObMgLWhNFyvF7V_MBY85lDk=.72af50d0-27d8-4042-b219-0c55e76ad54a@github.com>
 <X3kAjWS-V2FSRbDNQz8FAxL8h4xgId-xhgOKRAWYpZ8=.a6335ae4-328b-4595-bfb1-1e3bcd567d00@github.com>
Message-ID: <3zeVODsu7Rua1yYkuT5bvwP7wYAynUDiNKRuhNEuXvw=.0a0a7d3e-cd78-41fc-8cc6-e53fd588b3da@github.com>

On Mon, 22 Aug 2022 17:08:33 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> src/share/classes/com/sun/javatest/regtest/exec/ProcessCommand.java line 267:
>> 
>>> 265:                       long count = descendants.count();
>>> 266:                       if (count > 0) {
>>> 267:                         System.err.println("Detected a possibly stuck process (pid:"+pid+") with "+count+" descendants");
>> 
>> Don't use `System.err` directly;  use the `err` and `out` streams that were passed in when the class was invoked.
>
> Thank you, will fix.

That got much more complicated that I imaged. Please take a look and tell me if I missed something and it could have been done in a simpler way.

-------------

PR: https://git.openjdk.org/jtreg/pull/97

From gziemski at openjdk.org  Mon Aug 22 20:46:46 2022
From: gziemski at openjdk.org (Gerard Ziemski)
Date: Mon, 22 Aug 2022 20:46:46 GMT
Subject: RFR: 7903217: jtreg could try killing descendants of stuck test, 
 before timing out the test [v3]
In-Reply-To: <EdrQ-aAmgSQVIN34XjqcMdlHJxpwhow0IDkxsBtGw-M=.6f881262-2039-49a7-8496-7f98caed6aa8@github.com>
References: <EdrQ-aAmgSQVIN34XjqcMdlHJxpwhow0IDkxsBtGw-M=.6f881262-2039-49a7-8496-7f98caed6aa8@github.com>
Message-ID: <WdGb-x3vxiYjKemNjb61GclofP2b2HXNVCkeNTOamr8=.be3f39e8-ad95-4809-afb2-9e55e511cd76@github.com>

> This is an enhancement that aims to improve the robustness of the testing by attempting to quit any child processes (that are possibly stuck and are blocking the parent process from terminating) before timing out the target parent process.
> 
> Aborting a process will flush its stdout/stderr streams, which will hopefully get captured in the test's log and provide additional clues as to why a test was timing out.
> 
> This enhancement was locally tested with a handcrafted test that itself launched a child process that would get stuck on purpose and worked as intended.
> 
> Hopefully, this will help debug issues such as [JDK-8286345](https://bugs.openjdk.org/browse/JDK-8286345)

Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:

  overcomplicated things with last commit, just use the available err print writer

-------------

Changes:
  - all: https://git.openjdk.org/jtreg/pull/97/files
  - new: https://git.openjdk.org/jtreg/pull/97/files/b2b59d44..47ff7edf

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jtreg&pr=97&range=02
 - incr: https://webrevs.openjdk.org/?repo=jtreg&pr=97&range=01-02

  Stats: 43 lines in 1 file changed: 1 ins; 19 del; 23 mod
  Patch: https://git.openjdk.org/jtreg/pull/97.diff
  Fetch: git fetch https://git.openjdk.org/jtreg pull/97/head:pull/97

PR: https://git.openjdk.org/jtreg/pull/97

From gziemski at openjdk.org  Mon Aug 22 20:46:46 2022
From: gziemski at openjdk.org (Gerard Ziemski)
Date: Mon, 22 Aug 2022 20:46:46 GMT
Subject: RFR: 7903217: jtreg could try killing descendants of stuck test, 
 before timing out the test [v3]
In-Reply-To: <3zeVODsu7Rua1yYkuT5bvwP7wYAynUDiNKRuhNEuXvw=.0a0a7d3e-cd78-41fc-8cc6-e53fd588b3da@github.com>
References: <EdrQ-aAmgSQVIN34XjqcMdlHJxpwhow0IDkxsBtGw-M=.6f881262-2039-49a7-8496-7f98caed6aa8@github.com>
 <0_0yJzR0O012cAMqYQFnObMgLWhNFyvF7V_MBY85lDk=.72af50d0-27d8-4042-b219-0c55e76ad54a@github.com>
 <X3kAjWS-V2FSRbDNQz8FAxL8h4xgId-xhgOKRAWYpZ8=.a6335ae4-328b-4595-bfb1-1e3bcd567d00@github.com>
 <3zeVODsu7Rua1yYkuT5bvwP7wYAynUDiNKRuhNEuXvw=.0a0a7d3e-cd78-41fc-8cc6-e53fd588b3da@github.com>
Message-ID: <l22k4m95_Uvc_76tN0vOV065EffQDG6wf5viJRpaNo4=.d4c735b9-7143-4f1b-9407-1edf48cd72ba@github.com>

On Mon, 22 Aug 2022 20:18:47 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Thank you, will fix.
>
> That got much more complicated that I imaged. Please take a look and tell me if I missed something and it could have been done in a simpler way.

Hmm, I think I did overcomplicate things. After my last commit, I started working on the other feedback, and noticed "err" print writer, so I am using it now instead.

-------------

PR: https://git.openjdk.org/jtreg/pull/97

From gziemski at openjdk.org  Mon Aug 22 20:54:38 2022
From: gziemski at openjdk.org (Gerard Ziemski)
Date: Mon, 22 Aug 2022 20:54:38 GMT
Subject: RFR: 7903217: jtreg could try killing descendants of stuck test, 
 before timing out the test [v4]
In-Reply-To: <Xr20rh2thxbz9kVBw2J7HaFxBiFcPGMQHMx5wr-JjTo=.86c76597-85e2-4678-b0e6-580a33c5c6be@github.com>
References: <EdrQ-aAmgSQVIN34XjqcMdlHJxpwhow0IDkxsBtGw-M=.6f881262-2039-49a7-8496-7f98caed6aa8@github.com>
 <0g7fnN6RoKfFB3JhT5Z58jXp2lsrfEAECCxLHlxISAw=.17efd471-d55c-4b90-84a9-2df8d845e212@github.com>
 <Xr20rh2thxbz9kVBw2J7HaFxBiFcPGMQHMx5wr-JjTo=.86c76597-85e2-4678-b0e6-580a33c5c6be@github.com>
Message-ID: <T0x-_dQVpBvUesQP8mu9QCl2eKhfG8XuIv4rn-YH5_g=.96c3908b-58b7-4349-8d80-c678e336ac5f@github.com>

On Mon, 22 Aug 2022 17:16:52 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> src/share/classes/com/sun/javatest/regtest/exec/ProcessCommand.java line 307:
>> 
>>> 305:                 alarm.cancel();
>>> 306: 
>>> 307:                 return getStatus(exitCode, statusScanner.exitStatus());
>> 
>> I think you need to do something more here.   If the class killed child processes, you need to ensure that (probably) `Status.error` is returned with a suitable string. In other words, consider the case where you unlock a child process and the main process exits normally for some reason. That should *not* be grounds for the test to pass.
>
> I see the point, but I also had a case where after force quitting the child process, the parent test process is able to retrieve everything it needed from the child (which finished its task required for the parent before getting itself locked up) and be able to succeed just fine.
> 
> If we were to return error code in such cases, we would be generating failures in cases where the parent process was able to finish, but its children were not. Not necessarily always directly related to the case under test, more of a tangential failure, but I do see the value in reporting such cases. I will tweak it then.

We now detect whether we had to cancel any child processes and return an error code if we do (this would fix any potential false positives, where the parent test process is free to proceed, but a child process is unable to throw any error status back at the parent, because the child itself is stuck)

-------------

PR: https://git.openjdk.org/jtreg/pull/97

From gziemski at openjdk.org  Mon Aug 22 20:54:36 2022
From: gziemski at openjdk.org (Gerard Ziemski)
Date: Mon, 22 Aug 2022 20:54:36 GMT
Subject: RFR: 7903217: jtreg could try killing descendants of stuck test, 
 before timing out the test [v4]
In-Reply-To: <EdrQ-aAmgSQVIN34XjqcMdlHJxpwhow0IDkxsBtGw-M=.6f881262-2039-49a7-8496-7f98caed6aa8@github.com>
References: <EdrQ-aAmgSQVIN34XjqcMdlHJxpwhow0IDkxsBtGw-M=.6f881262-2039-49a7-8496-7f98caed6aa8@github.com>
Message-ID: <XC6kJWG8Zr1D6mimhc79GUqMkUAqooy0eEmQEDi1JNM=.7c08d837-4599-402b-9c63-e6b5703fa7bb@github.com>

> This is an enhancement that aims to improve the robustness of the testing by attempting to quit any child processes (that are possibly stuck and are blocking the parent process from terminating) before timing out the target parent process.
> 
> Aborting a process will flush its stdout/stderr streams, which will hopefully get captured in the test's log and provide additional clues as to why a test was timing out.
> 
> This enhancement was locally tested with a handcrafted test that itself launched a child process that would get stuck on purpose and worked as intended.
> 
> Hopefully, this will help debug issues such as [JDK-8286345](https://bugs.openjdk.org/browse/JDK-8286345)

Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:

  return exit code if we had to cancel any child processes

-------------

Changes:
  - all: https://git.openjdk.org/jtreg/pull/97/files
  - new: https://git.openjdk.org/jtreg/pull/97/files/47ff7edf..0f86b130

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jtreg&pr=97&range=03
 - incr: https://webrevs.openjdk.org/?repo=jtreg&pr=97&range=02-03

  Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jtreg/pull/97.diff
  Fetch: git fetch https://git.openjdk.org/jtreg pull/97/head:pull/97

PR: https://git.openjdk.org/jtreg/pull/97

From jjg at openjdk.org  Tue Aug 23 21:33:26 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Tue, 23 Aug 2022 21:33:26 GMT
Subject: RFR: CODETOOLS-7903260: Fix support for JUnit tests in a system module
Message-ID: <2z-A7zlOHCBP2h1DiKf_XgQ2HhR8SJpoOvJdmIE4oMg=.29ca36be-d638-4ae5-8496-43d7dfb82d5a@github.com>

Please review a simple patch to allow a directory of TestNG or JUnit tests to be patched into a system module, in order to access package-private API.

The patch is just to export the package containing the patched test to the possibly-unnamed module containing the library code to run the tests.

-------------

Commit messages:
 - CODETOOLS-7903260: Fix support for JUnit tests in a system module

Changes: https://git.openjdk.org/jtreg/pull/105/files
 Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=105&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903260
  Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jtreg/pull/105.diff
  Fetch: git fetch https://git.openjdk.org/jtreg pull/105/head:pull/105

PR: https://git.openjdk.org/jtreg/pull/105

From iris at openjdk.org  Tue Aug 23 21:37:47 2022
From: iris at openjdk.org (Iris Clark)
Date: Tue, 23 Aug 2022 21:37:47 GMT
Subject: RFR: CODETOOLS-7903260: Fix support for JUnit tests in a system
 module
In-Reply-To: <2z-A7zlOHCBP2h1DiKf_XgQ2HhR8SJpoOvJdmIE4oMg=.29ca36be-d638-4ae5-8496-43d7dfb82d5a@github.com>
References: <2z-A7zlOHCBP2h1DiKf_XgQ2HhR8SJpoOvJdmIE4oMg=.29ca36be-d638-4ae5-8496-43d7dfb82d5a@github.com>
Message-ID: <FBoC3agBaRI9C5YAIgnKClhFclf0jrxu3f3OAec2QUE=.9913e4b6-2104-47af-bab2-a2eb826eec72@github.com>

On Tue, 23 Aug 2022 21:26:48 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple patch to allow a directory of TestNG or JUnit tests to be patched into a system module, in order to access package-private API.
> 
> The patch is just to export the package containing the patched test to the possibly-unnamed module containing the library code to run the tests.

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.org/jtreg/pull/105

From jjg at openjdk.org  Wed Aug 24 01:26:48 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 24 Aug 2022 01:26:48 GMT
Subject: Integrated: CODETOOLS-7903260: Fix support for JUnit tests in a system
 module
In-Reply-To: <2z-A7zlOHCBP2h1DiKf_XgQ2HhR8SJpoOvJdmIE4oMg=.29ca36be-d638-4ae5-8496-43d7dfb82d5a@github.com>
References: <2z-A7zlOHCBP2h1DiKf_XgQ2HhR8SJpoOvJdmIE4oMg=.29ca36be-d638-4ae5-8496-43d7dfb82d5a@github.com>
Message-ID: <6ZI-5T9JsCYIQHRKsKpeszi0zp7fbhKrZsigKz1CQQE=.99c349a8-e7d0-466e-8bbf-53efe51fd1c5@github.com>

On Tue, 23 Aug 2022 21:26:48 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple patch to allow a directory of TestNG or JUnit tests to be patched into a system module, in order to access package-private API.
> 
> The patch is just to export the package containing the patched test to the possibly-unnamed module containing the library code to run the tests.

This pull request has now been integrated.

Changeset: ccb05af5
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/ccb05af578e522f2c331e4a20d7537e9a91a898d
Stats:     7 lines in 1 file changed: 7 ins; 0 del; 0 mod

7903260: Fix support for JUnit tests in a system module

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/jtreg/pull/105

From jjg at openjdk.org  Wed Aug 24 01:28:18 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 24 Aug 2022 01:28:18 GMT
Subject: RFR: CODETOOLS-7903261: Add FAQ entry about the time taken to run
 tests
Message-ID: <KDN2jIjQRMBu66N-GeoZU2KQVJ43K5kN_3Day01pyE8=.ffa9bdd9-d3c7-46fc-a158-597a7ae433db@github.com>

Please review an update to the FAQ, to add an entry about the information recorded in `.jtr` files about test execution times.

-------------

Commit messages:
 - ODETOOLS-7903261: Add FAQ entry about the time taken to run tests

Changes: https://git.openjdk.org/jtreg/pull/106/files
 Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=106&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903261
  Stats: 56 lines in 1 file changed: 53 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jtreg/pull/106.diff
  Fetch: git fetch https://git.openjdk.org/jtreg pull/106/head:pull/106

PR: https://git.openjdk.org/jtreg/pull/106

From iris at openjdk.org  Wed Aug 24 04:39:41 2022
From: iris at openjdk.org (Iris Clark)
Date: Wed, 24 Aug 2022 04:39:41 GMT
Subject: RFR: CODETOOLS-7903261: Add FAQ entry about the time taken to run
 tests
In-Reply-To: <KDN2jIjQRMBu66N-GeoZU2KQVJ43K5kN_3Day01pyE8=.ffa9bdd9-d3c7-46fc-a158-597a7ae433db@github.com>
References: <KDN2jIjQRMBu66N-GeoZU2KQVJ43K5kN_3Day01pyE8=.ffa9bdd9-d3c7-46fc-a158-597a7ae433db@github.com>
Message-ID: <eyO_G4gAeD2Mdf_p1jF696R3rTMRJHbOJqkJe_eSRX8=.e84149ee-a02a-4cb0-a142-2bdf74b66ed9@github.com>

On Wed, 24 Aug 2022 01:21:10 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review an update to the FAQ, to add an entry about the information recorded in `.jtr` files about test execution times.

Marked as reviewed by iris (Reviewer).

src/share/doc/javatest/regtest/faq.md line 1025:

> 1023: awhile in case the files go away in a timely manner.
> 1024: 
> 1025: ### My tests take a long time to run: how do I find where the time goes?

You might want to consider breaking up your answer into two parts.  The first part answers the question "My **test** takes a long time to run: how to I find where the time goes?" The second part answers "How do I find the longest-running tests in my test suite?"

-------------

PR: https://git.openjdk.org/jtreg/pull/106

From duke at openjdk.org  Thu Aug 25 04:28:46 2022
From: duke at openjdk.org (Jan Kratochvil)
Date: Thu, 25 Aug 2022 04:28:46 GMT
Subject: RFR: 7903191: Fix build with "MAKEFLAGS=-j32". [v2]
In-Reply-To: <GDSDuN-VF0GBoP1m3yA5HEli6lGN7CFN8SQ9RNj9Ukc=.4edda87b-0a55-4ade-a5f3-832df0c69f78@github.com>
References: <6uobKd-93s4HhfaGizx9KIx5b0wintpeeEEWwNbOebk=.dda8c3c9-7e4d-413c-9360-a712e973636e@github.com>
 <GDSDuN-VF0GBoP1m3yA5HEli6lGN7CFN8SQ9RNj9Ukc=.4edda87b-0a55-4ade-a5f3-832df0c69f78@github.com>
Message-ID: <egYqyvz_UbIafeCHDiWUJF4XAStq79-s0eigu-HP7AU=.16590386-7bac-4d8e-8f64-a169668e1c65@github.com>

On Mon, 16 May 2022 21:23:17 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Jan Kratochvil has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   Fix build with "MAKEFLAGS=-j32".
>>   
>>   /bin/sh: line 5: jtreg/build/classes/com/sun/javatest/regtest/tool/jars.properties: No such file or directory
>>   make: *** [jtreg.gmk:98: jtreg/build/classes/com/sun/javatest/regtest/tool/jars.properties] Error 1
>
> This would be better/simpler as just `$(MKDIR) -p $(@D)`

@jonathan-gibbons Hello, is there anything more I should do to get the patch approved? Thanks.

-------------

PR: https://git.openjdk.org/jtreg/pull/72

From jjg at openjdk.org  Fri Aug 26 02:15:56 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 26 Aug 2022 02:15:56 GMT
Subject: RFR: CODETOOLS-7903264: Full support for JUnit tests
Message-ID: <sDYHW2UhrOOG090ejBfGKS1SGOyH0Ci168swoRFSsLE=.3cdb3976-a064-4f57-8524-6fd750e71a00@github.com>

Please review a medium-size patch to upgrade the support for running directories of Unit tests. This is primarily in the jtreg front end, either cloning or sharing and then modifying the support for directories of TestNG tests. The back end already supports direct use of JUnit for `@run junit` and the new code leverages that work.

There is one tweak to the JUnit back-end, to enable the generation of summary reports. To that end, the class `TestNGSummaryReporter` has morphed into `SummaryReporter` with internal subtypes for `JUnit` and `TestNG`. That refactoring was too much for git to recognize, and so the change shows up as "old file deleted; new file added".

Two new groups of tests are added, which are just modified copies of existing TestNG tests, to verify that JUnit support is effectively equivalent to TestNG support.

-------------

Commit messages:
 - update to use JUnit
 - CODETOOLS-7903264: Full support for JUnit tests

Changes: https://git.openjdk.org/jtreg/pull/107/files
 Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=107&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903264
  Stats: 852 lines in 26 files changed: 630 ins; 153 del; 69 mod
  Patch: https://git.openjdk.org/jtreg/pull/107.diff
  Fetch: git fetch https://git.openjdk.org/jtreg pull/107/head:pull/107

PR: https://git.openjdk.org/jtreg/pull/107

From iris at openjdk.org  Fri Aug 26 04:11:12 2022
From: iris at openjdk.org (Iris Clark)
Date: Fri, 26 Aug 2022 04:11:12 GMT
Subject: RFR: CODETOOLS-7903264: Full support for JUnit tests
In-Reply-To: <sDYHW2UhrOOG090ejBfGKS1SGOyH0Ci168swoRFSsLE=.3cdb3976-a064-4f57-8524-6fd750e71a00@github.com>
References: <sDYHW2UhrOOG090ejBfGKS1SGOyH0Ci168swoRFSsLE=.3cdb3976-a064-4f57-8524-6fd750e71a00@github.com>
Message-ID: <QsCHbyPrGp43Kc1A0BHvTU-Sk3c_XSYbOL-UUy4VOns=.649be78f-31b3-4f39-a8e4-cc1e5d07062c@github.com>

On Fri, 26 Aug 2022 01:56:51 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a medium-size patch to upgrade the support for running directories of Unit tests. This is primarily in the jtreg front end, either cloning or sharing and then modifying the support for directories of TestNG tests. The back end already supports direct use of JUnit for `@run junit` and the new code leverages that work.
> 
> There is one tweak to the JUnit back-end, to enable the generation of summary reports. To that end, the class `TestNGSummaryReporter` has morphed into `SummaryReporter` with internal subtypes for `JUnit` and `TestNG`. That refactoring was too much for git to recognize, and so the change shows up as "old file deleted; new file added".
> 
> Two new groups of tests are added, which are just modified copies of existing TestNG tests, to verify that JUnit support is effectively equivalent to TestNG support.

Very nice!

-------------

Marked as reviewed by iris (Reviewer).

PR: https://git.openjdk.org/jtreg/pull/107

From jjg at openjdk.org  Fri Aug 26 16:56:18 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 26 Aug 2022 16:56:18 GMT
Subject: Integrated: CODETOOLS-7903264: Full support for JUnit tests
In-Reply-To: <sDYHW2UhrOOG090ejBfGKS1SGOyH0Ci168swoRFSsLE=.3cdb3976-a064-4f57-8524-6fd750e71a00@github.com>
References: <sDYHW2UhrOOG090ejBfGKS1SGOyH0Ci168swoRFSsLE=.3cdb3976-a064-4f57-8524-6fd750e71a00@github.com>
Message-ID: <mNigByW83yyp1Ol15kbFqyLHIbqUEOnPAsz4eVYqUOs=.61727158-9236-40e1-952f-b9210f979256@github.com>

On Fri, 26 Aug 2022 01:56:51 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a medium-size patch to upgrade the support for running directories of JUnit tests. This is primarily in the jtreg front end, either cloning or sharing and then modifying the support for directories of TestNG tests. The back end already supports direct use of JUnit for `@run junit` and the new code leverages that work.
> 
> There is one tweak to the JUnit back-end, to enable the generation of summary reports. To that end, the class `TestNGSummaryReporter` has morphed into `SummaryReporter` with internal subtypes for `JUnit` and `TestNG`. That refactoring was too much for git to recognize, and so the change shows up as "old file deleted; new file added".
> 
> Two new groups of tests are added, which are just modified copies of existing TestNG tests, to verify that JUnit support is effectively equivalent to TestNG support.

This pull request has now been integrated.

Changeset: 2bddb406
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/2bddb406f907072b6951b8b02a0c1a7cf640d7bf
Stats:     852 lines in 26 files changed: 630 ins; 153 del; 69 mod

7903264: Full support for JUnit tests

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/jtreg/pull/107

From jjg at openjdk.org  Fri Aug 26 22:30:15 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 26 Aug 2022 22:30:15 GMT
Subject: RFR: CODETOOLS-7903261: Add FAQ entry about the time taken to run
 tests
In-Reply-To: <eyO_G4gAeD2Mdf_p1jF696R3rTMRJHbOJqkJe_eSRX8=.e84149ee-a02a-4cb0-a142-2bdf74b66ed9@github.com>
References: <KDN2jIjQRMBu66N-GeoZU2KQVJ43K5kN_3Day01pyE8=.ffa9bdd9-d3c7-46fc-a158-597a7ae433db@github.com>
 <eyO_G4gAeD2Mdf_p1jF696R3rTMRJHbOJqkJe_eSRX8=.e84149ee-a02a-4cb0-a142-2bdf74b66ed9@github.com>
Message-ID: <JRoHHbhfHGeXH_VvToTmx1euVxlXwQ2TWWpEf8PV1mw=.d2be3ffd-b614-469e-9250-edbb11fc1090@github.com>

On Wed, 24 Aug 2022 04:35:57 GMT, Iris Clark <iris at openjdk.org> wrote:

>> Please review an update to the FAQ, to add an entry about the information recorded in `.jtr` files about test execution times.
>
> src/share/doc/javatest/regtest/faq.md line 1025:
> 
>> 1023: awhile in case the files go away in a timely manner.
>> 1024: 
>> 1025: ### My tests take a long time to run: how do I find where the time goes?
> 
> You might want to consider breaking up your answer into two parts.  The first part answers the question "My **test** takes a long time to run: how to I find where the time goes?" The second part answers "How do I find the longest-running tests in my test suite?"

Noted; thanks

-------------

PR: https://git.openjdk.org/jtreg/pull/106

From jjg at openjdk.org  Fri Aug 26 22:43:53 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 26 Aug 2022 22:43:53 GMT
Subject: RFR: CODETOOLS-7903261: Add FAQ entry about the time taken to run
 tests [v2]
In-Reply-To: <KDN2jIjQRMBu66N-GeoZU2KQVJ43K5kN_3Day01pyE8=.ffa9bdd9-d3c7-46fc-a158-597a7ae433db@github.com>
References: <KDN2jIjQRMBu66N-GeoZU2KQVJ43K5kN_3Day01pyE8=.ffa9bdd9-d3c7-46fc-a158-597a7ae433db@github.com>
Message-ID: <fEh7HH7JB3-htQ-4G-Snp6uo7n3iqD39qyfYreVaGR0=.0713c948-8857-4d75-927e-d72416b14c86@github.com>

> Please review an update to the FAQ, to add an entry about the information recorded in `.jtr` files about test execution times.

Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:

  address review feedback; split recent entry into 2

-------------

Changes:
  - all: https://git.openjdk.org/jtreg/pull/106/files
  - new: https://git.openjdk.org/jtreg/pull/106/files/faa1d918..9bff78a3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jtreg&pr=106&range=01
 - incr: https://webrevs.openjdk.org/?repo=jtreg&pr=106&range=00-01

  Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jtreg/pull/106.diff
  Fetch: git fetch https://git.openjdk.org/jtreg pull/106/head:pull/106

PR: https://git.openjdk.org/jtreg/pull/106

From iris at openjdk.org  Sat Aug 27 00:02:00 2022
From: iris at openjdk.org (Iris Clark)
Date: Sat, 27 Aug 2022 00:02:00 GMT
Subject: RFR: CODETOOLS-7903261: Add FAQ entry about the time taken to run
 tests [v2]
In-Reply-To: <fEh7HH7JB3-htQ-4G-Snp6uo7n3iqD39qyfYreVaGR0=.0713c948-8857-4d75-927e-d72416b14c86@github.com>
References: <KDN2jIjQRMBu66N-GeoZU2KQVJ43K5kN_3Day01pyE8=.ffa9bdd9-d3c7-46fc-a158-597a7ae433db@github.com>
 <fEh7HH7JB3-htQ-4G-Snp6uo7n3iqD39qyfYreVaGR0=.0713c948-8857-4d75-927e-d72416b14c86@github.com>
Message-ID: <xFvcyR7I90elQeC3np07COwDhc9ptsdVOiybEfCZYeY=.0ace734e-f2f1-4373-8c53-5c12b4560637@github.com>

On Fri, 26 Aug 2022 22:43:53 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review an update to the FAQ, to add an entry about the information recorded in `.jtr` files about test execution times.
>
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   address review feedback; split recent entry into 2

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.org/jtreg/pull/106

From iris at openjdk.org  Sat Aug 27 00:02:03 2022
From: iris at openjdk.org (Iris Clark)
Date: Sat, 27 Aug 2022 00:02:03 GMT
Subject: RFR: CODETOOLS-7903261: Add FAQ entry about the time taken to run
 tests [v2]
In-Reply-To: <JRoHHbhfHGeXH_VvToTmx1euVxlXwQ2TWWpEf8PV1mw=.d2be3ffd-b614-469e-9250-edbb11fc1090@github.com>
References: <KDN2jIjQRMBu66N-GeoZU2KQVJ43K5kN_3Day01pyE8=.ffa9bdd9-d3c7-46fc-a158-597a7ae433db@github.com>
 <eyO_G4gAeD2Mdf_p1jF696R3rTMRJHbOJqkJe_eSRX8=.e84149ee-a02a-4cb0-a142-2bdf74b66ed9@github.com>
 <JRoHHbhfHGeXH_VvToTmx1euVxlXwQ2TWWpEf8PV1mw=.d2be3ffd-b614-469e-9250-edbb11fc1090@github.com>
Message-ID: <1X9wdDZgVCqU45-uLqWRboA_wXCvMjTeDq6iVtBL1tI=.9bf2b7b7-39dc-4bba-a524-80a12c16204e@github.com>

On Fri, 26 Aug 2022 22:26:48 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> src/share/doc/javatest/regtest/faq.md line 1025:
>> 
>>> 1023: awhile in case the files go away in a timely manner.
>>> 1024: 
>>> 1025: ### My tests take a long time to run: how do I find where the time goes?
>> 
>> You might want to consider breaking up your answer into two parts.  The first part answers the question "My **test** takes a long time to run: how to I find where the time goes?" The second part answers "How do I find the longest-running tests in my test suite?"
>
> Noted; thanks

Looks good!

-------------

PR: https://git.openjdk.org/jtreg/pull/106

From jjg at openjdk.org  Sat Aug 27 00:49:04 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Sat, 27 Aug 2022 00:49:04 GMT
Subject: Integrated: CODETOOLS-7903261: Add FAQ entry about the time taken to
 run tests
In-Reply-To: <KDN2jIjQRMBu66N-GeoZU2KQVJ43K5kN_3Day01pyE8=.ffa9bdd9-d3c7-46fc-a158-597a7ae433db@github.com>
References: <KDN2jIjQRMBu66N-GeoZU2KQVJ43K5kN_3Day01pyE8=.ffa9bdd9-d3c7-46fc-a158-597a7ae433db@github.com>
Message-ID: <-Rkhqr9dPkSG2lff1M-WmAO9GR5qH_reiYjVyG6U68k=.6954aadc-c962-42fc-955f-f496e7cc5a0c@github.com>

On Wed, 24 Aug 2022 01:21:10 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review an update to the FAQ, to add an entry about the information recorded in `.jtr` files about test execution times.

This pull request has now been integrated.

Changeset: 5e988da8
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/5e988da8622d1f244d449c25905badfdb80715c9
Stats:     60 lines in 1 file changed: 57 ins; 0 del; 3 mod

7903261: Add FAQ entry about the time taken to run tests

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/jtreg/pull/106

From jjg at openjdk.org  Tue Aug 30 20:27:17 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Tue, 30 Aug 2022 20:27:17 GMT
Subject: RFR: CODETOOLS-7903273: Add comment for confusing pattern
Message-ID: <eDFng3QPEOfpxuGqzu3lNh0EZW9V5nLrWf9UiiOmCwI=.7913ff61-1608-476e-9bf1-f814ddd278dd@github.com>

Please review a simple patch to add a comment to some non-obvious code.

-------------

Commit messages:
 - CODETOOLS-7903273: Add comment for confusing pattern

Changes: https://git.openjdk.org/jtreg/pull/108/files
 Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=108&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903273
  Stats: 11 lines in 1 file changed: 11 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jtreg/pull/108.diff
  Fetch: git fetch https://git.openjdk.org/jtreg pull/108/head:pull/108

PR: https://git.openjdk.org/jtreg/pull/108

From iris at openjdk.org  Tue Aug 30 21:09:18 2022
From: iris at openjdk.org (Iris Clark)
Date: Tue, 30 Aug 2022 21:09:18 GMT
Subject: RFR: CODETOOLS-7903273: Add comment for confusing pattern
In-Reply-To: <eDFng3QPEOfpxuGqzu3lNh0EZW9V5nLrWf9UiiOmCwI=.7913ff61-1608-476e-9bf1-f814ddd278dd@github.com>
References: <eDFng3QPEOfpxuGqzu3lNh0EZW9V5nLrWf9UiiOmCwI=.7913ff61-1608-476e-9bf1-f814ddd278dd@github.com>
Message-ID: <O2GkXeKIEGSUkjhqNdHDNLktXlmYaIURkKgik4yDXq4=.9337dad1-1d24-46c3-b79a-4f1b1ebf75e1@github.com>

On Tue, 30 Aug 2022 20:19:15 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple patch to add a comment to some non-obvious code.

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.org/jtreg/pull/108

From jjg at openjdk.org  Wed Aug 31 14:21:38 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 31 Aug 2022 14:21:38 GMT
Subject: Integrated: CODETOOLS-7903273: Add comment for confusing pattern
In-Reply-To: <eDFng3QPEOfpxuGqzu3lNh0EZW9V5nLrWf9UiiOmCwI=.7913ff61-1608-476e-9bf1-f814ddd278dd@github.com>
References: <eDFng3QPEOfpxuGqzu3lNh0EZW9V5nLrWf9UiiOmCwI=.7913ff61-1608-476e-9bf1-f814ddd278dd@github.com>
Message-ID: <LlBJyD1SHRHCl6U3yOIk_O3jHJO-2punF588FhSxxz4=.a2083f30-bbb4-4205-9b23-d58733e6122a@github.com>

On Tue, 30 Aug 2022 20:19:15 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple patch to add a comment to some non-obvious code.

This pull request has now been integrated.

Changeset: 2cf3f0e6
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/2cf3f0e64eb61bff2bd2ae58ec851e73899f0ee3
Stats:     11 lines in 1 file changed: 11 ins; 0 del; 0 mod

7903273: Add comment for confusing pattern

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/jtreg/pull/108