Integrated: CODETOOLS-7903091: Convert jtreg to use NIO

[Jonathan Gibbons]

On Mon, 7 Feb 2022 22:49:29 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a medium-big, conceptually simple but occasionally tricky update to jtreg, to use `java.nio.file.Path` instead of `java.io.File` where reasonable.
> 
> While most of the changes are formulaic and follow the obvious patterns, there were some noteworthy points:
> 
> * The most complicated class to change was `Locations`, which does the most work to derive new paths. In particular, the semantics of `new File(a, b)` do not always match `Path.of(a).resolve(b)` for corner cases like when `a` is`null` or empty, or when `b` is absolute.
> 
> * The NIO equivalent for some operations on `File` throw checked IO exceptions.  These methods were wrapped to to throw a custom unchecked IO exception.
> 
> * The NIO equivalent for creating a new file (`Path`) throws an unchecked `InvalidPathException` exception. The use sites are too numerous to handle individually.  The solution is to catch exceptions like these (and the ones described in the previous bullet) at strategic points where they can be handled or wrapped back into (existing) checked exceptions.
> 
> The development has been iterative, frequently running the jtreg internal tests locally (on a Mac) and occasionally building on a CI system (Linux).  We should do more exhaustive testing with JDK before this work ever gets promoted.

This pull request has now been integrated.

Changeset: 8c048360
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.java.net/jtreg/commit/8c048360d6a8d2b8ade91d98191bd4c56a4c38b3
Stats:     1357 lines in 39 files changed: 468 ins; 104 del; 785 mod

7903091: Convert jtreg to use NIO

Reviewed-by: iris

-------------

PR: https://git.openjdk.java.net/jtreg/pull/50