RFR: 7903093: Detect/report invalid class names given to @clean action [v4]

Jonathan Gibbons jjg at openjdk.java.net
Thu Feb 10 20:00:48 UTC 2022


On Thu, 10 Feb 2022 09:02:58 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Check the validity of all given class names by delegating the check to the `javax.lang.model.SourceVersion#isName` method.
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adopt quick-test to new clean action input checks

Well done for incorporating the test into Basic.java

src/share/classes/com/sun/javatest/regtest/exec/CleanAction.java line 100:

> 98:                 continue;
> 99:             // detected a syntactically invalid class name
> 100:             throw new ParseException(CLEAN_BAD_CLASSNAME + arg);

Interesting that there was a simple "old" check.

-------------

Marked as reviewed by jjg (Lead).

PR: https://git.openjdk.java.net/jtreg/pull/53


More information about the jtreg-dev mailing list