RFR: 7903097: jtreg could implement ToolProvider [v3]

[Jonathan Gibbons]

On Mon, 14 Feb 2022 19:04:25 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Prevent non-zero exit code by using supported option
>
> test/toolprovider/ToolProviderTest.gmk line 34:
> 
>> 32: 		-jdk:$(JDKHOME) \
>> 33: 		$(TESTDIR)/toolprovider/Pass.java \
>> 34: 			> $(@:%.ok=%/jt.log) 2>&1 ; rc=$$? ; \
> 
> It really doesn't add anything, other than an unnecessary level of complexity, to invoke the test using jtreg. And using jtreg to launch tests that run jtreg is just confusing.
> 
> It should be sufficient to replace these lines with a simple compile-and-run of the test program, perhaps even using source launcher.

If you invoke the test directly, you don't need that empty `TEST.ROOT` file either. (I cannot comment on that file directly.)

-------------

PR: https://git.openjdk.java.net/jtreg/pull/54