RFR: CODETOOLS-7903102: Remove obsolete traces of references to JavaHelp

Iris Clark iris at openjdk.java.net
Tue Feb 15 21:04:31 UTC 2022


On Tue, 15 Feb 2022 20:38:58 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a build-only fix to remove obsolete references to the old JavaHelp system, which was removed back in 2016. [CODETOOLS-7901673](https://bugs.openjdk.java.net/browse/CODETOOLS-7901673)

Looks good.  I only have a single comment.

I'm surprised to see how many places JavaHelp turns up.

test/env/EnvTest.gmk line 30:

> 28: $(BUILDDIR)/EnvTest.simple.ok: $(ENV.files) \
> 29: 	    $(JTREG_IMAGEDIR)/lib/javatest.jar \
> 30: 	    $(JTREG_IMAGEDIR)/lib/jtreg.jar

Shouldn't there be a trailing "\" on this line and line 55?  In both cases, there's another path component on the next line.

-------------

Marked as reviewed by iris (Reviewer).

PR: https://git.openjdk.java.net/jtreg/pull/58


More information about the jtreg-dev mailing list