From cstein at openjdk.java.net  Thu Jun  9 09:02:16 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 9 Jun 2022 09:02:16 GMT
Subject: RFR: 7903206: Support MSYS2 for building jtreg on Windows
Message-ID: <57UPTGgqzMBeXEfoO5Yxt2RA4sQUTHSgdMVDy07KRdA=.4ae97a87-91e6-49fa-8ef1-6008a008a7dc@github.com>

7903206: Support MSYS2 for building jtreg on Windows

-------------

Commit messages:
 - Look for `MINGW` in `uname` as well
 - 7903206: Support MSYS2 for building jtreg on Windows

Changes: https://git.openjdk.java.net/jtreg/pull/87/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=87&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903206
  Stats: 16 lines in 3 files changed: 9 ins; 0 del; 7 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/87.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/87/head:pull/87

PR: https://git.openjdk.java.net/jtreg/pull/87

From ihse at openjdk.java.net  Thu Jun  9 09:02:17 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Thu, 9 Jun 2022 09:02:17 GMT
Subject: RFR: 7903206: Support MSYS2 for building jtreg on Windows
In-Reply-To: <57UPTGgqzMBeXEfoO5Yxt2RA4sQUTHSgdMVDy07KRdA=.4ae97a87-91e6-49fa-8ef1-6008a008a7dc@github.com>
References: <57UPTGgqzMBeXEfoO5Yxt2RA4sQUTHSgdMVDy07KRdA=.4ae97a87-91e6-49fa-8ef1-6008a008a7dc@github.com>
Message-ID: <_oXQEz_ThuVCCPjrEUy5VTK7cZ0Xi30IScAYmWz711g=.a68f1088-aeb3-4310-8c2e-cc5eb51aa1c8@github.com>

On Thu, 9 Jun 2022 08:13:20 GMT, Christian Stein <cstein at openjdk.org> wrote:

> 7903206: Support MSYS2 for building jtreg on Windows

make/Defs.gmk line 59:

> 57: endif
> 58: 
> 59: ifneq (,$(findstring MSYS,$(SYSTEM_UNAME)))

Look for MINGW as well; depending on how MSYS2 is configured, it can present itself as MSYS, MINGW32 or MINGW64 (the default).

-------------

PR: https://git.openjdk.java.net/jtreg/pull/87

From cstein at openjdk.java.net  Thu Jun  9 09:02:17 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 9 Jun 2022 09:02:17 GMT
Subject: RFR: 7903206: Support MSYS2 for building jtreg on Windows
In-Reply-To: <_oXQEz_ThuVCCPjrEUy5VTK7cZ0Xi30IScAYmWz711g=.a68f1088-aeb3-4310-8c2e-cc5eb51aa1c8@github.com>
References: <57UPTGgqzMBeXEfoO5Yxt2RA4sQUTHSgdMVDy07KRdA=.4ae97a87-91e6-49fa-8ef1-6008a008a7dc@github.com>
 <_oXQEz_ThuVCCPjrEUy5VTK7cZ0Xi30IScAYmWz711g=.a68f1088-aeb3-4310-8c2e-cc5eb51aa1c8@github.com>
Message-ID: <FM95BaOevHghUie7DFqSHgfMyRvSL1BP4Q6Iybs6Fiw=.592e25dd-da99-495f-bd29-a4ee8b28e611@github.com>

On Thu, 9 Jun 2022 08:31:59 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> 7903206: Support MSYS2 for building jtreg on Windows
>
> make/Defs.gmk line 59:
> 
>> 57: endif
>> 58: 
>> 59: ifneq (,$(findstring MSYS,$(SYSTEM_UNAME)))
> 
> Look for MINGW as well; depending on how MSYS2 is configured, it can present itself as MSYS, MINGW32 or MINGW64 (the default).

Good catch.

Any idea if `findstring` supports logical OR operation? _Looking for its man page..._

-------------

PR: https://git.openjdk.java.net/jtreg/pull/87

From cstein at openjdk.java.net  Thu Jun  9 09:02:17 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 9 Jun 2022 09:02:17 GMT
Subject: RFR: 7903206: Support MSYS2 for building jtreg on Windows
In-Reply-To: <FM95BaOevHghUie7DFqSHgfMyRvSL1BP4Q6Iybs6Fiw=.592e25dd-da99-495f-bd29-a4ee8b28e611@github.com>
References: <57UPTGgqzMBeXEfoO5Yxt2RA4sQUTHSgdMVDy07KRdA=.4ae97a87-91e6-49fa-8ef1-6008a008a7dc@github.com>
 <_oXQEz_ThuVCCPjrEUy5VTK7cZ0Xi30IScAYmWz711g=.a68f1088-aeb3-4310-8c2e-cc5eb51aa1c8@github.com>
 <FM95BaOevHghUie7DFqSHgfMyRvSL1BP4Q6Iybs6Fiw=.592e25dd-da99-495f-bd29-a4ee8b28e611@github.com>
Message-ID: <dwO5kNuKy2tummchFqHF7CgAzIcF8cJeOe4Rk_eUfp8=.8f41cdca-297d-47c5-9e72-1f2985f30545@github.com>

On Thu, 9 Jun 2022 08:40:49 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> make/Defs.gmk line 59:
>> 
>>> 57: endif
>>> 58: 
>>> 59: ifneq (,$(findstring MSYS,$(SYSTEM_UNAME)))
>> 
>> Look for MINGW as well; depending on how MSYS2 is configured, it can present itself as MSYS, MINGW32 or MINGW64 (the default).
>
> Good catch.
> 
> Any idea if `findstring` supports logical OR operation? _Looking for its man page..._

Addressed via https://github.com/openjdk/jtreg/pull/87/commits/3919f80869f46d73a6744fb052e03366e030c23b

-------------

PR: https://git.openjdk.java.net/jtreg/pull/87

From cstein at openjdk.java.net  Thu Jun  9 10:00:36 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 9 Jun 2022 10:00:36 GMT
Subject: RFR: 7903206: Support MSYS2 for building jtreg on Windows [v2]
In-Reply-To: <57UPTGgqzMBeXEfoO5Yxt2RA4sQUTHSgdMVDy07KRdA=.4ae97a87-91e6-49fa-8ef1-6008a008a7dc@github.com>
References: <57UPTGgqzMBeXEfoO5Yxt2RA4sQUTHSgdMVDy07KRdA=.4ae97a87-91e6-49fa-8ef1-6008a008a7dc@github.com>
Message-ID: <it4i115MpXzXCHtGokbKNblQSL86FhqjOcTuZVvmTN4=.8242df7e-8862-4ccd-818e-ee2fdd6b0142@github.com>

> Support MSYS2 for building jtreg on Windows.

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Fix typo and print value of `CYGWIN_OR_MSYS`

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/87/files
  - new: https://git.openjdk.java.net/jtreg/pull/87/files/3919f808..1dc45a92

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=87&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=87&range=00-01

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/87.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/87/head:pull/87

PR: https://git.openjdk.java.net/jtreg/pull/87

From cstein at openjdk.java.net  Thu Jun  9 10:44:42 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 9 Jun 2022 10:44:42 GMT
Subject: RFR: 7903206: Support MSYS2 for building jtreg on Windows [v3]
In-Reply-To: <57UPTGgqzMBeXEfoO5Yxt2RA4sQUTHSgdMVDy07KRdA=.4ae97a87-91e6-49fa-8ef1-6008a008a7dc@github.com>
References: <57UPTGgqzMBeXEfoO5Yxt2RA4sQUTHSgdMVDy07KRdA=.4ae97a87-91e6-49fa-8ef1-6008a008a7dc@github.com>
Message-ID: <zAlkTzV-M7-ddovb4exIEKk2kKophvOnN76tE0eivmI=.2d425b8e-6766-4de3-b617-82de33d0e7b8@github.com>

> Support MSYS2 for building jtreg on Windows.

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Mix path to JDKHOME

-------------

Changes:
  - all: https://git.openjdk.java.net/jtreg/pull/87/files
  - new: https://git.openjdk.java.net/jtreg/pull/87/files/1dc45a92..68ea5432

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtreg&pr=87&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jtreg&pr=87&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jtreg/pull/87.diff
  Fetch: git fetch https://git.openjdk.java.net/jtreg pull/87/head:pull/87

PR: https://git.openjdk.java.net/jtreg/pull/87

From ihse at openjdk.java.net  Thu Jun  9 12:37:00 2022
From: ihse at openjdk.java.net (Magnus Ihse Bursie)
Date: Thu, 9 Jun 2022 12:37:00 GMT
Subject: RFR: 7903206: Support MSYS2 for building jtreg on Windows [v3]
In-Reply-To: <zAlkTzV-M7-ddovb4exIEKk2kKophvOnN76tE0eivmI=.2d425b8e-6766-4de3-b617-82de33d0e7b8@github.com>
References: <57UPTGgqzMBeXEfoO5Yxt2RA4sQUTHSgdMVDy07KRdA=.4ae97a87-91e6-49fa-8ef1-6008a008a7dc@github.com>
 <zAlkTzV-M7-ddovb4exIEKk2kKophvOnN76tE0eivmI=.2d425b8e-6766-4de3-b617-82de33d0e7b8@github.com>
Message-ID: <3askeIvQXMags38Y_wVrArNEwxc-4O7fmY7R4S8vsh8=.c98e7828-0caa-48b1-bafd-0e55876fa38f@github.com>

On Thu, 9 Jun 2022 10:44:42 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Support MSYS2 for building jtreg on Windows.
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Mix path to JDKHOME

This looks good to me. I have verified that it can build on GHA with MSYS2.

-------------

Marked as reviewed by ihse (Author).

PR: https://git.openjdk.java.net/jtreg/pull/87

From jjg at openjdk.java.net  Thu Jun  9 14:07:04 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Thu, 9 Jun 2022 14:07:04 GMT
Subject: RFR: 7903206: Support MSYS2 for building jtreg on Windows [v3]
In-Reply-To: <zAlkTzV-M7-ddovb4exIEKk2kKophvOnN76tE0eivmI=.2d425b8e-6766-4de3-b617-82de33d0e7b8@github.com>
References: <57UPTGgqzMBeXEfoO5Yxt2RA4sQUTHSgdMVDy07KRdA=.4ae97a87-91e6-49fa-8ef1-6008a008a7dc@github.com>
 <zAlkTzV-M7-ddovb4exIEKk2kKophvOnN76tE0eivmI=.2d425b8e-6766-4de3-b617-82de33d0e7b8@github.com>
Message-ID: <n9lby1_7-slhEyWiX_rT1JZfnbeMiKPS4PzC-XRcrpo=.b25c2168-81e0-458c-8ccf-61a94a107e86@github.com>

On Thu, 9 Jun 2022 10:44:42 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Support MSYS2 for building jtreg on Windows.
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Mix path to JDKHOME

Marked as reviewed by jjg (Lead).

-------------

PR: https://git.openjdk.org/jtreg/pull/87

From cstein at openjdk.java.net  Thu Jun  9 16:09:53 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 9 Jun 2022 16:09:53 GMT
Subject: Integrated: 7903206: Support MSYS2 for building jtreg on Windows
In-Reply-To: <57UPTGgqzMBeXEfoO5Yxt2RA4sQUTHSgdMVDy07KRdA=.4ae97a87-91e6-49fa-8ef1-6008a008a7dc@github.com>
References: <57UPTGgqzMBeXEfoO5Yxt2RA4sQUTHSgdMVDy07KRdA=.4ae97a87-91e6-49fa-8ef1-6008a008a7dc@github.com>
Message-ID: <9ZqJUZBE0TdCsZynfszYIzEtaH5j_GKG34ywSzCZQJ8=.58d42aa0-2484-462e-b70a-0aaf3db33963@github.com>

On Thu, 9 Jun 2022 08:13:20 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Support MSYS2 for building jtreg on Windows.

This pull request has now been integrated.

Changeset: d60381de
Author:    Christian Stein <cstein at openjdk.org>
Committer: Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/d60381de853f9e17d358b6a5c745be595f71e5c9
Stats:     18 lines in 4 files changed: 10 ins; 0 del; 8 mod

7903206: Support MSYS2 for building jtreg on Windows

Reviewed-by: ihse, jjg

-------------

PR: https://git.openjdk.org/jtreg/pull/87

From duke at openjdk.java.net  Thu Jun  9 16:32:26 2022
From: duke at openjdk.java.net (Jan Kratochvil)
Date: Thu, 9 Jun 2022 16:32:26 GMT
Subject: RFR: CODETOOLS-7903207: Simplify make/jtreg.gmk rules
Message-ID: <ObDmBD8GXd2At8XYd-IhN1vZkS-85Yxz37oxKpBxGvQ=.f9dcc67a-95f6-47a9-b858-a7521eb55f4d@github.com>

CODETOOLS-7903207: Simplify make/jtreg.gmk rules

-------------

Commit messages:
 - Simplify make/jtreg.gmk rules

Changes: https://git.openjdk.org/jtreg/pull/86/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=86&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903207
  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jtreg/pull/86.diff
  Fetch: git fetch https://git.openjdk.org/jtreg pull/86/head:pull/86

PR: https://git.openjdk.org/jtreg/pull/86

From jjg at openjdk.java.net  Thu Jun  9 16:32:27 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Thu, 9 Jun 2022 16:32:27 GMT
Subject: RFR: CODETOOLS-7903207: Simplify make/jtreg.gmk rules
In-Reply-To: <ObDmBD8GXd2At8XYd-IhN1vZkS-85Yxz37oxKpBxGvQ=.f9dcc67a-95f6-47a9-b858-a7521eb55f4d@github.com>
References: <ObDmBD8GXd2At8XYd-IhN1vZkS-85Yxz37oxKpBxGvQ=.f9dcc67a-95f6-47a9-b858-a7521eb55f4d@github.com>
Message-ID: <d-YTF45Wf3cpjSqOmp9_eEVZWgIbMVNJeuzEDpNEd0o=.19b53834-e524-49bb-8116-6fa7788c99c9@github.com>

On Tue, 17 May 2022 07:19:12 GMT, Jan Kratochvil <duke at openjdk.java.net> wrote:

> CODETOOLS-7903207: Simplify make/jtreg.gmk rules

Marked as reviewed by jjg (Lead).

-------------

PR: https://git.openjdk.org/jtreg/pull/86

From cstein at openjdk.java.net  Thu Jun  9 19:03:45 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Thu, 9 Jun 2022 19:03:45 GMT
Subject: RFR: 7903206: Support MSYS2 for building jtreg on Windows
Message-ID: <D9oVfOcH1D-E8zmESUKrwhqpt3W03Bnj9bPniB5TUXI=.c07b9387-2b49-4207-b128-d2d71a186371@github.com>

Reviewed-by: ihse, jjg

(cherry picked from commit d60381de853f9e17d358b6a5c745be595f71e5c9)

-------------

Commit messages:
 - 7903206: Support MSYS2 for building jtreg on Windows

Changes: https://git.openjdk.org/jtreg/pull/88/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtreg&pr=88&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903206
  Stats: 16 lines in 3 files changed: 10 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jtreg/pull/88.diff
  Fetch: git fetch https://git.openjdk.org/jtreg pull/88/head:pull/88

PR: https://git.openjdk.org/jtreg/pull/88

From jjg at openjdk.java.net  Fri Jun 10 02:55:18 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Fri, 10 Jun 2022 02:55:18 GMT
Subject: RFR: 7903206: Support MSYS2 for building jtreg on Windows
In-Reply-To: <D9oVfOcH1D-E8zmESUKrwhqpt3W03Bnj9bPniB5TUXI=.c07b9387-2b49-4207-b128-d2d71a186371@github.com>
References: <D9oVfOcH1D-E8zmESUKrwhqpt3W03Bnj9bPniB5TUXI=.c07b9387-2b49-4207-b128-d2d71a186371@github.com>
Message-ID: <jy_hE0w35dQ3R0PMGqRf-XunWOQhuDBBdlB-sf3MuqY=.116d204a-1380-452c-bc91-10ca969b30e4@github.com>

On Thu, 9 Jun 2022 18:54:16 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Reviewed-by: ihse, jjg
> 
> (cherry picked from commit d60381de853f9e17d358b6a5c745be595f71e5c9)

You may need to file a back port request, since the original issue (to update 7) has now been closed.  There are also some warnings from the bots that you should check.

-------------

PR: https://git.openjdk.org/jtreg/pull/88

From cstein at openjdk.java.net  Fri Jun 10 06:55:18 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Fri, 10 Jun 2022 06:55:18 GMT
Subject: RFR: 7903206: Support MSYS2 for building jtreg on Windows
In-Reply-To: <D9oVfOcH1D-E8zmESUKrwhqpt3W03Bnj9bPniB5TUXI=.c07b9387-2b49-4207-b128-d2d71a186371@github.com>
References: <D9oVfOcH1D-E8zmESUKrwhqpt3W03Bnj9bPniB5TUXI=.c07b9387-2b49-4207-b128-d2d71a186371@github.com>
Message-ID: <cBpy4tCuWLD_BMNhhKq2xYk89YqxUA-CWMbcXlfB18A=.22a71e97-d5a8-4eaf-8e6c-5549757c902f@github.com>

On Thu, 9 Jun 2022 18:54:16 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Reviewed-by: ihse, jjg
> 
> (cherry picked from commit d60381de853f9e17d358b6a5c745be595f71e5c9)

As Skara doesn't manage versions of jtreg (it lacks a version configured in `.jcheck/conf`) a back port request seems not required.

The warning only addresses a naming conflict detected for my personal fork - which I tend to ignore, as I won't sync that branch in the future.

In the light of that, I will issue a `/integrate` command in a follow-up comment.

-------------

PR: https://git.openjdk.org/jtreg/pull/88

From fjiang at openjdk.java.net  Fri Jun 10 08:27:18 2022
From: fjiang at openjdk.java.net (Feilong Jiang)
Date: Fri, 10 Jun 2022 08:27:18 GMT
Subject: RFR: 7903138: os.simpleArch is x64 for linux-riscv64 in @require
 context [v3]
In-Reply-To: <EQE7dxUh8X0BeWfLytBMxPnj3qYxgXJWbtQipV1knLc=.ec2861c4-9829-4c83-88da-e2fc3f6e29ae@github.com>
References: <eiC8QuVInYOP6q9IDsakQGTfY3p5efP2OQTwKuc3VV0=.871e27a7-cd2d-4963-8310-cd4527d55a57@github.com>
 <PIm_0ANkSQ1-x_LHpJGlg_55b8XUDM47uCUdfXm_IU4=.7777d967-65b6-4308-9813-591c2c49f715@github.com>
 <EQE7dxUh8X0BeWfLytBMxPnj3qYxgXJWbtQipV1knLc=.ec2861c4-9829-4c83-88da-e2fc3f6e29ae@github.com>
Message-ID: <qYQncp-JpxI1UL6qfKSeU8m8b2J-vYMJRJ9Z9Ca06gI=.e8f6f1cf-0491-4a81-9a60-fd748f7be612@github.com>

On Mon, 16 May 2022 17:32:33 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove riscv in comment
>
> Marked as reviewed by jjg (Lead).

Hi @jonathan-gibbons , This patch has been reviewed and the conflict was resolved too. Could you sponsor this PR?  Thanks!

-------------

PR: https://git.openjdk.org/jtreg/pull/66

From jjg at openjdk.java.net  Fri Jun 10 14:48:27 2022
From: jjg at openjdk.java.net (Jonathan Gibbons)
Date: Fri, 10 Jun 2022 14:48:27 GMT
Subject: RFR: 7903206: Support MSYS2 for building jtreg on Windows
In-Reply-To: <D9oVfOcH1D-E8zmESUKrwhqpt3W03Bnj9bPniB5TUXI=.c07b9387-2b49-4207-b128-d2d71a186371@github.com>
References: <D9oVfOcH1D-E8zmESUKrwhqpt3W03Bnj9bPniB5TUXI=.c07b9387-2b49-4207-b128-d2d71a186371@github.com>
Message-ID: <0DqdV3BvA_qfEM5Kk4gQFo3mqDAY_MPSEmGmD5K7KLs=.5df7e7cf-652f-4e39-b304-bf82f643e29a@github.com>

On Thu, 9 Jun 2022 18:54:16 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Reviewed-by: ihse, jjg
> 
> (cherry picked from commit d60381de853f9e17d358b6a5c745be595f71e5c9)

Going forward, I think it would be better to lean into Skara some more, and configure a version in .jcheck/conf

-------------

PR: https://git.openjdk.org/jtreg/pull/88

From cstein at openjdk.java.net  Fri Jun 10 14:48:27 2022
From: cstein at openjdk.java.net (Christian Stein)
Date: Fri, 10 Jun 2022 14:48:27 GMT
Subject: Integrated: 7903206: Support MSYS2 for building jtreg on Windows
In-Reply-To: <D9oVfOcH1D-E8zmESUKrwhqpt3W03Bnj9bPniB5TUXI=.c07b9387-2b49-4207-b128-d2d71a186371@github.com>
References: <D9oVfOcH1D-E8zmESUKrwhqpt3W03Bnj9bPniB5TUXI=.c07b9387-2b49-4207-b128-d2d71a186371@github.com>
Message-ID: <xBkGrxnGumYf3DjE6yvrc4cqYFEviWypOWnVWKgAiew=.6d5ecb6e-1d0a-48e2-8029-2d604279a2cd@github.com>

On Thu, 9 Jun 2022 18:54:16 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Reviewed-by: ihse, jjg
> 
> (cherry picked from commit d60381de853f9e17d358b6a5c745be595f71e5c9)

This pull request has now been integrated.

Changeset: 382fe545
Author:    Christian Stein <cstein at openjdk.org>
Committer: Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/382fe545b996170eb54593d9ffea52664f67b901
Stats:     16 lines in 3 files changed: 10 ins; 0 del; 6 mod

7903206: Support MSYS2 for building jtreg on Windows

-------------

PR: https://git.openjdk.org/jtreg/pull/88

From jjg at openjdk.org  Wed Jun 29 17:22:26 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 29 Jun 2022 17:22:26 GMT
Subject: RFR: CODETOOLS-7903220: Improve setting of the generated "release"
 file
Message-ID: <7ELnGbVojrBW48EGjkgZccEts6gIn4GoGfOxAqqDtbY=.9d4f9187-b4b9-4ded-9bf8-16ccf375532a@github.com>

Please review a small change to permit  more flexible, optional setting of the `.src-rev` file used to generate info in the `release` file for an image.

-------------

Commit messages:
 - CODETOOLS-7903220: Improve setting of the generated "release" file

Changes: https://git.openjdk.org/jtreg/pull/89/files
 Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=89&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903220
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jtreg/pull/89.diff
  Fetch: git fetch https://git.openjdk.org/jtreg pull/89/head:pull/89

PR: https://git.openjdk.org/jtreg/pull/89

From iris at openjdk.org  Wed Jun 29 17:32:16 2022
From: iris at openjdk.org (Iris Clark)
Date: Wed, 29 Jun 2022 17:32:16 GMT
Subject: RFR: CODETOOLS-7903220: Improve setting of the generated "release"
 file
In-Reply-To: <7ELnGbVojrBW48EGjkgZccEts6gIn4GoGfOxAqqDtbY=.9d4f9187-b4b9-4ded-9bf8-16ccf375532a@github.com>
References: <7ELnGbVojrBW48EGjkgZccEts6gIn4GoGfOxAqqDtbY=.9d4f9187-b4b9-4ded-9bf8-16ccf375532a@github.com>
Message-ID: <X55cmi0qEVxPuvpxOh_BjCIYuor60sZeY755ECvvrQw=.dff57397-5728-4eed-ac9e-67068d05c621@github.com>

On Wed, 29 Jun 2022 17:14:42 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a small change to permit  more flexible, optional setting of the `.src-rev` file used to generate info in the `release` file for an image.

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.org/jtreg/pull/89

From jjg at openjdk.org  Wed Jun 29 22:27:00 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 29 Jun 2022 22:27:00 GMT
Subject: Integrated: CODETOOLS-7903220: Improve setting of the generated
 "release" file
In-Reply-To: <7ELnGbVojrBW48EGjkgZccEts6gIn4GoGfOxAqqDtbY=.9d4f9187-b4b9-4ded-9bf8-16ccf375532a@github.com>
References: <7ELnGbVojrBW48EGjkgZccEts6gIn4GoGfOxAqqDtbY=.9d4f9187-b4b9-4ded-9bf8-16ccf375532a@github.com>
Message-ID: <PpQ-Koj5--wIR4uwp-Urv2dK8JvL2aQ_6O0LgLPiBvM=.3abfcf9c-5f03-496d-8d00-070c8064c83f@github.com>

On Wed, 29 Jun 2022 17:14:42 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a small change to permit  more flexible, optional setting of the `.src-rev` file used to generate info in the `release` file for an image.

This pull request has now been integrated.

Changeset: 2101d2b1
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/2101d2b165095f78811c7758a3453326b519eff5
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

7903220: Improve setting of the generated "release" file

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/jtreg/pull/89

From jjg at openjdk.org  Wed Jun 29 23:06:28 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 29 Jun 2022 23:06:28 GMT
Subject: RFR: CODETOOLS-7903221: broken self-tests
Message-ID: <_Yb8o3sZFVSxwv99tHkPtPWHX3H49IhYuM--Vi8sulA=.1b8d600c-29d9-4194-a508-3ee0bfd2707e@github.com>

Please review a couple of test changes to make them more robust in the face of using alternate locations for the build directory, and choice of JUnit library

-------------

Commit messages:
 - Merge remote-tracking branch 'upstream/master' into jtreg.7113596.broken-tests
 - CODETOOLS-7903221: broken self-tests

Changes: https://git.openjdk.org/jtreg/pull/90/files
 Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=90&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903221
  Stats: 7 lines in 2 files changed: 4 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jtreg/pull/90.diff
  Fetch: git fetch https://git.openjdk.org/jtreg pull/90/head:pull/90

PR: https://git.openjdk.org/jtreg/pull/90

From iris at openjdk.org  Wed Jun 29 23:23:54 2022
From: iris at openjdk.org (Iris Clark)
Date: Wed, 29 Jun 2022 23:23:54 GMT
Subject: RFR: CODETOOLS-7903221: broken self-tests
In-Reply-To: <_Yb8o3sZFVSxwv99tHkPtPWHX3H49IhYuM--Vi8sulA=.1b8d600c-29d9-4194-a508-3ee0bfd2707e@github.com>
References: <_Yb8o3sZFVSxwv99tHkPtPWHX3H49IhYuM--Vi8sulA=.1b8d600c-29d9-4194-a508-3ee0bfd2707e@github.com>
Message-ID: <82mJI8ThfdlitQQcEBQ6-NYhuxFBnt0pYxDwhkXWFgw=.8be195ce-6bcd-4846-acfc-076be7713dfd@github.com>

On Wed, 29 Jun 2022 23:00:19 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a couple of test changes to make them more robust in the face of using alternate locations for the build directory, and choice of JUnit library

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.org/jtreg/pull/90

From jjg at openjdk.org  Wed Jun 29 23:28:22 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 29 Jun 2022 23:28:22 GMT
Subject: RFR: CODETOOLS-7903222: update entries in .gitignore
Message-ID: <ZlS8FiMhU-A08JFkvJpaq2btwuF1DJaYSLTu1B2araQ=.0e49f07b-1c2c-411c-bb9f-447f073afcaa@github.com>

Please review some minor updates to .gitignore

-------------

Commit messages:
 - CODETOOLS-7903222: update entries in .gitignore

Changes: https://git.openjdk.org/jtreg/pull/91/files
 Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=91&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903222
  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jtreg/pull/91.diff
  Fetch: git fetch https://git.openjdk.org/jtreg pull/91/head:pull/91

PR: https://git.openjdk.org/jtreg/pull/91

From iris at openjdk.org  Wed Jun 29 23:34:00 2022
From: iris at openjdk.org (Iris Clark)
Date: Wed, 29 Jun 2022 23:34:00 GMT
Subject: RFR: CODETOOLS-7903222: update entries in .gitignore
In-Reply-To: <ZlS8FiMhU-A08JFkvJpaq2btwuF1DJaYSLTu1B2araQ=.0e49f07b-1c2c-411c-bb9f-447f073afcaa@github.com>
References: <ZlS8FiMhU-A08JFkvJpaq2btwuF1DJaYSLTu1B2araQ=.0e49f07b-1c2c-411c-bb9f-447f073afcaa@github.com>
Message-ID: <Kly_accMFLJK6YG2C3H1ZXmguKgnoMiypUN83-lSrEs=.41175de9-6175-4d74-9ee4-fdffe3e5c4dc@github.com>

On Wed, 29 Jun 2022 23:22:30 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review some minor updates to .gitignore

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.org/jtreg/pull/91

From jjg at openjdk.org  Thu Jun 30 00:58:39 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Thu, 30 Jun 2022 00:58:39 GMT
Subject: git: openjdk/jtreg: 7903221: broken self-tests
Message-ID: <f5998fab-2a9c-406a-b096-e2f872e49d16@openjdk.org>

Changeset: fb76daee
Author:    Jonathan Gibbons <jjg at openjdk.org>
Date:      2022-06-30 00:58:17 +0000
URL:       https://git.openjdk.org/jtreg/commit/fb76daee1c4cd4c5c39fc657565adcb2f638905f

7903221: broken self-tests

Reviewed-by: iris

! test/7113596/T7113596.gmk
! test/share/basic/junit/BadTestClass.java


From jjg at openjdk.org  Thu Jun 30 01:01:54 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Thu, 30 Jun 2022 01:01:54 GMT
Subject: Integrated: CODETOOLS-7903221: broken self-tests
In-Reply-To: <_Yb8o3sZFVSxwv99tHkPtPWHX3H49IhYuM--Vi8sulA=.1b8d600c-29d9-4194-a508-3ee0bfd2707e@github.com>
References: <_Yb8o3sZFVSxwv99tHkPtPWHX3H49IhYuM--Vi8sulA=.1b8d600c-29d9-4194-a508-3ee0bfd2707e@github.com>
Message-ID: <_rKciE0NOp8je3AQl7YY1APAUONrwphpixXSAwKbSd4=.8dd4767b-5099-4e36-9460-5b5466d00932@github.com>

On Wed, 29 Jun 2022 23:00:19 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a couple of test changes to make them more robust in the face of using alternate locations for the build directory, and choice of JUnit library

This pull request has now been integrated.

Changeset: fb76daee
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/fb76daee1c4cd4c5c39fc657565adcb2f638905f
Stats:     7 lines in 2 files changed: 4 ins; 0 del; 3 mod

7903221: broken self-tests

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/jtreg/pull/90

From jjg at openjdk.org  Thu Jun 30 01:03:01 2022
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Thu, 30 Jun 2022 01:03:01 GMT
Subject: Integrated: CODETOOLS-7903222: update entries in .gitignore
In-Reply-To: <ZlS8FiMhU-A08JFkvJpaq2btwuF1DJaYSLTu1B2araQ=.0e49f07b-1c2c-411c-bb9f-447f073afcaa@github.com>
References: <ZlS8FiMhU-A08JFkvJpaq2btwuF1DJaYSLTu1B2araQ=.0e49f07b-1c2c-411c-bb9f-447f073afcaa@github.com>
Message-ID: <1uLVjOlqSTryWuQIL0P7PVa79lX2qeWM6_9OrO8fDj0=.d210ace9-71e6-47e7-9a70-44ddee26cfdc@github.com>

On Wed, 29 Jun 2022 23:22:30 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review some minor updates to .gitignore

This pull request has now been integrated.

Changeset: ed04f9cd
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/ed04f9cd5cfca7b4919011e688b4bf9eaef1c0c4
Stats:     2 lines in 1 file changed: 1 ins; 0 del; 1 mod

7903222: update entries in .gitignore

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/jtreg/pull/91