RFR: CODETOOLS-7903184: Update OS version check

Christian Stein cstein at openjdk.java.net
Fri May 13 01:16:56 UTC 2022


On Thu, 12 May 2022 21:12:02 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a small fix to be slightly more permissive in the check for the os.version property, and allow a double-dotted number (like 1.2.3) to be accepted as better than a single-dotted prefix (like 1.2).

LGTM and supersedes https://github.com/openjdk/jtreg/pull/75/files#diff-a5a4da5948aa7c272080a329f721f8095d1802b11821e6c11970ffc3585a4c9c

Do you want to include the comment from the linked solution?


        // The os.version property may be more detailed than the expected value determined in the makefiles.
        // For example, "11.6.5" is a valid match for an expected "11.6" version.

-------------

Marked as reviewed by cstein (Author).

PR: https://git.openjdk.java.net/jtreg/pull/83


More information about the jtreg-dev mailing list