RFR: 7903373: Add ability to customize test execution using main wrapper plugin [v5]

Leonid Mesnik lmesnik at openjdk.org
Thu Nov 10 00:14:11 UTC 2022


On Fri, 28 Oct 2022 23:30:18 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> src/share/classes/com/sun/javatest/regtest/agent/CustomMainWrapper.java line 105:
>> 
>>> 103:         return vmOpts;
>>> 104:     }
>>> 105: }
>> 
>> Is this real code, or just toy test code?
>
> It loos like it is just test code, included from the new test, in which case it doesn't belong here in the mainline source.

Moved to test code.

>> src/share/classes/com/sun/javatest/regtest/config/RegressionParameters.java line 1248:
>> 
>>> 1246: 
>>> 1247:     private long timeoutHandlerTimeout;
>>> 1248:     //---------------------------------------------------------------------
>> 
>> You have not updated `load` and `save` in this class
>
> Are these methods actually being called?   You seem to be stashing the custom main wrapper values early in the `testVMOpts`

Fixed.

-------------

PR: https://git.openjdk.org/jtreg/pull/136


More information about the jtreg-dev mailing list