RFR: 7903373: Add ability to customize test execution using main wrapper plugin

Jonathan Gibbons jjg at openjdk.org
Wed Oct 26 21:34:28 UTC 2022


On Fri, 21 Oct 2022 21:43:04 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> The fix adds support of a plugin that customizes test execution.

On a first pass, it generally looks very good;  well done.

I'd like to go through it again next week.

src/share/classes/com/sun/javatest/regtest/tool/i18n.properties line 177:

> 175: help.main.mw.desc=Man wrapper desc
> 176: help.main.mwp.arg=Man wrapper argument
> 177: help.main.mwp.desc=Man wrapper desc

possible spelling errors: should "Man wrapper" be "Main" -- if not, what is a "Man Wrapper" ?

test/mainWrapper/TestMainWrapper.gmk line 49:

> 47: 	echo "test passed at `date`" > $@
> 48: 
> 49: INITIAL_TESTS += $(BUILDTESTDIR)/TestMainWrapper.ok

I don't think this test is important enough to be in the set of initial tests; it should just be in the set of general jtreg tests (`TESTS.jtreg`)

-------------

PR: https://git.openjdk.org/jtreg/pull/136


More information about the jtreg-dev mailing list