RFR: 7903299: Add '.gradle/' and 'build/' to file '.gitignore'

Guoxiong Li gli at openjdk.org
Thu Sep 15 18:34:09 UTC 2022


On Thu, 15 Sep 2022 15:52:25 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Hi all,
>> 
>> The directories '.gradle' and 'build/' are autumaticall created when opening and building the plugin project. It is good to ignore them in the git repo.
>> 
>> Thanks for taking time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Marked as reviewed by mcimadamore (Committer).

@mcimadamore Thanks for the reivew. But It seems the you are not a formal reviewer in `code-tools` project. Considering the repos in `code-tools` project lacks developers, I suggest to change the `reviewers check` from `one reviewer` to `one committer` (shown below). And the `JMH` project also has the same [setting](https://github.com/openjdk/jmh/blob/master/.jcheck/conf). What do you think about it?


// in file jtreg/.jcheck/conf
[checks "reviewers"]
reviewers=1   -- change to --> committer=1
ignore=duke

-------------

PR: https://git.openjdk.org/jtreg/pull/116


More information about the jtreg-dev mailing list