RFR: CODETOOLS-7903317: Fix code to compile extra property definitions

[Jonathan Gibbons]

On Mon, 19 Sep 2022 06:43:52 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Please review a fairly simple update to eliminate false positives in comments when looking for the name of the class in a Java source file.
>> 
>> The fix addresses a performance issue when running tests, because the "extra property definition" files were compiled every time jtreg was run, instead of as needed, which is the intent.
>> 
>> The fix is to ignore comments in the source code. The code to do this is copied from equivalent functionality in the langtools `ToolBox` class, which has been in use for many years.
>> 
>> The existing tests for "extra property definition" files have been extended with a test case to ensure that the false positives no longer occur and that the files are not recompiled unnecessarily.
>> 
>> Minor style issues in the main source file have also been fixed.
>
> src/share/classes/com/sun/javatest/regtest/config/ExtraPropDefns.java line 227:
> 
>> 225:         if (needCompilation) {
>> 226:             if (trace) {
>> 227:                 System.err.println("Compiling extra property definition files: " + javacArgs);
> 
> Could you also log why the compilation was needed? i.e. when setting needCompilation, log sf and cf.

Will investigate, as a separate RFE

-------------

PR: https://git.openjdk.org/jtreg/pull/122