RFR: CODETOOLS-7903317: Fix code to compile extra property definitions

[Jonathan Gibbons]

On Sat, 17 Sep 2022 05:05:25 GMT, Iris Clark <iris at openjdk.org> wrote:

>> Please review a fairly simple update to eliminate false positives in comments when looking for the name of the class in a Java source file.
>> 
>> The fix addresses a performance issue when running tests, because the "extra property definition" files were compiled every time jtreg was run, instead of as needed, which is the intent.
>> 
>> The fix is to ignore comments in the source code. The code to do this is copied from equivalent functionality in the langtools `ToolBox` class, which has been in use for many years.
>> 
>> The existing tests for "extra property definition" files have been extended with a test case to ensure that the false positives no longer occur and that the files are not recompiled unnecessarily.
>> 
>> Minor style issues in the main source file have also been fixed.
>
> test/extra-props/comments/TEST.ROOT line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
> 
> Copyright year?

Borderline, since it's a copy ...

-------------

PR: https://git.openjdk.org/jtreg/pull/122