Integrated: CODETOOLS-7903317: Fix code to compile extra property definitions
Jonathan Gibbons
jjg at openjdk.org
Wed Sep 21 23:34:32 UTC 2022
On Fri, 16 Sep 2022 19:00:31 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
> Please review a fairly simple update to eliminate false positives in comments when looking for the name of the class in a Java source file.
>
> The fix addresses a performance issue when running tests, because the "extra property definition" files were compiled every time jtreg was run, instead of as needed, which is the intent.
>
> The fix is to ignore comments in the source code. The code to do this is copied from equivalent functionality in the langtools `ToolBox` class, which has been in use for many years.
>
> The existing tests for "extra property definition" files have been extended with a test case to ensure that the false positives no longer occur and that the files are not recompiled unnecessarily.
>
> Minor style issues in the main source file have also been fixed.
This pull request has now been integrated.
Changeset: 77650ff6
Author: Jonathan Gibbons <jjg at openjdk.org>
URL: https://git.openjdk.org/jtreg/commit/77650ff600fa3110bd596fba89ef85d07497a70d
Stats: 127 lines in 23 files changed: 95 ins; 27 del; 5 mod
7903317: Fix code to compile extra property definitions
Reviewed-by: iris, djelinski
-------------
PR: https://git.openjdk.org/jtreg/pull/122
More information about the jtreg-dev
mailing list