RFR: 7903515: Some default env vars on Windows not set

[Jonathan Gibbons]

On Wed, 9 Aug 2023 15:26:14 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change to fix setting of some default environment variables on Windows.

src/share/classes/com/sun/javatest/regtest/tool/Tool.java line 2199:

> 2197: 
> 2198:     // This method streams over a case-sensitive set of entries, returned by
> 2199:     // System.getenv(String); custom name filters can be implemented in a

comment says `System.getenv(String)`; code says `System.getenv`

src/share/classes/com/sun/javatest/regtest/tool/Tool.java line 2208:

> 2206: 
> 2207:     // 7903515: Use case-insensitive System.getenv(String) here.
> 2208:     private static String getCaseInsensitiveEnvironmentVariableOrNull(String name) {

Suggest removing the `CaseInsensitive` part of the name, since it is not true on non-Windows systems.

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/166#discussion_r1288738490
PR Review Comment: https://git.openjdk.org/jtreg/pull/166#discussion_r1288734696