RFR: 7903580: Allow for re-attempting agent creation when an attempt fails [v2]

[Jonathan Gibbons]

On Tue, 14 Nov 2023 09:40:06 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> src/share/classes/com/sun/javatest/regtest/exec/Agent.java line 990:
>> 
>>> 988:         private Duration idleTimeout;
>>> 989:         // default is 2 i.e. we retry a failed agent selection once
>>> 990:         private int numAgentSelectionAttempts = 2;
>> 
>> The limit of 2 is set here but also later on.
>
> I did not understand this review comment. With the updated changes in this PR, the default value now is set to 1, here too. Did you mean something more?

The review comment was to the effect that a default of 2 was set in multiple places.  I'll verify that is no longer the case.  If you haven't already done so, perhaps `1` (the default) could be a named constant.

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/173#discussion_r1417748093