RFR: 7903580: Allow for re-attempting agent creation when an attempt fails [v5]

[Jaikiran Pai]

On Wed, 6 Dec 2023 17:50:24 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   kill the AgentServer process if Agent instance creation fails
>
> src/share/classes/com/sun/javatest/regtest/tool/Tool.java line 2335:
> 
>> 2333:     // number of attempts to get an agent for an action. we default to 1, which implies
>> 2334:     // by default we don't re-attempt on a failure
>> 2335:     private int numAgentSelectionAttempt = 1;
> 
> ... see above, this appears to be a duplicate setting for the default.

Hello Jon, I've updated the PR to set this default at a single place and also used a static final constant for the default value.

> src/share/doc/javatest/regtest/faq.md line 718:
> 
>> 716: re-attempt a failed attempt. Passing a higher value for this option will allow
>> 717: jtreg to re-attempt a failed attempt. For example, a value of `2` will allow jtreg
>> 718: to re-attempt once for each failed attempt.
> 
> Inconsistent typography for `jtreg`.
> 
> Use `jtreg` (code font) for the command or just JTReg for the name of the system, or otherwise try and make this new text consistent with other uses n the FAQ, if that is possible. (Note, I'm _not_ suggesting to fix/change other entries.)

Done. I've updated this section of the FAQ, to use JTReg, except for one place where the sentence refers to the `jtreg` command.

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/173#discussion_r1419035470
PR Review Comment: https://git.openjdk.org/jtreg/pull/173#discussion_r1419033718