RFR: 7903601 : jtr.xml logs produced with -xml argument do not contain failure justification [v2]
andrlos
duke at openjdk.org
Sat Dec 9 07:33:39 UTC 2023
On Wed, 6 Dec 2023 17:14:26 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> src/share/classes/com/sun/javatest/regtest/report/XMLWriter.java line 188:
>>
>>> 186: for (String x : s.getOutputNames()) {
>>> 187: return s.getOutput(name);
>>> 188: }
>>
>> The outer loop seems weird. It would be simpler to just change
>>
>> `if (titles[i].equals(section))`
>>
>> to
>>
>> `if (titles[I].equals("main") || titles[I].equals("shell"))`
>>
>> or equivalent
>
> or `if (Set.of("main", "shell").contains(titles[i]))` or equivalent
fixed.. I did not know if there is any chance of jtharness producing both Main and Shell section in the log in some corner cases, so I decided to play it safe and made the Shell section as a fallback option when no Main section is found.
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/175#discussion_r1421301877
More information about the jtreg-dev
mailing list