RFR: 7903601 : jtr.xml logs produced with -xml argument do not contain failure justification [v2]

Jonathan Gibbons jjg at openjdk.org
Wed Dec 13 22:02:08 UTC 2023


On Fri, 8 Dec 2023 20:10:06 GMT, andrlos <duke at openjdk.org> wrote:

>> issue:
>> https://bugs.openjdk.org/browse/CODETOOLS-7903601
>> 
>> with "-xml" argument when a shell driven test fails, the only thing you are getting in jtr.xml file as an explanation is the exit code which is not very helpful.. this is a fix for that which aligns the behavior of shell tests with that of java tests. The solution is up for a discussion, I just did the simplest and sturdiest solution I could think of.. in case there is no "main" section in the original jtr file, the xmlwriter in jtreg tries to iterate the sections again for "shell" section and writes the failure it finds there to the jtr.xml log
>
> andrlos has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix based on PR comments

Marked as reviewed by jjg (Lead).

-------------

PR Review: https://git.openjdk.org/jtreg/pull/175#pullrequestreview-1780561528


More information about the jtreg-dev mailing list