RFR: 7903373: Add ability to customize test execution using main wrapper plugin [v5]

Leonid Mesnik lmesnik at openjdk.org
Thu Jan 26 00:15:16 UTC 2023


On Tue, 6 Dec 2022 23:17:09 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   empty lines removed.
>
> src/share/classes/com/sun/javatest/regtest/agent/CustomMainWrapper.java line 38:
> 
>> 36: /**
>> 37:  * Interface which should be implemented to customize execution of test.
>> 38:  * It is used by main and driver actions to execute test.
> 
> This comment needs a lot of work. More than anywhere else, this seems like the place to document this feature.  In particular, the only aspect of the execution that can be customized is the thread that is created to run the test.

Comments were updated.

> src/share/classes/com/sun/javatest/regtest/exec/MainAction.java line 489:
> 
>> 487:         if (script.getCustomWrapperPath() != null) {
>> 488:             javaProps.put(MainWrapper.MAIN_WRAPPER_PATH, script.getCustomWrapperPath());
>> 489:         }
> 
> these properties should probably be documented in the appendix at the end of the tag spec

These properties are internal, seems such properties are not documented in tag spec.

-------------

PR: https://git.openjdk.org/jtreg/pull/136


More information about the jtreg-dev mailing list