RFR: 7903507: jtreg runs into race conditions for multi-modules tests [v2]

Jonathan Gibbons jjg at openjdk.org
Tue Jul 25 16:08:07 UTC 2023


On Tue, 25 Jul 2023 07:02:21 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> This change puts the necessary JAR files onto the module path as (automatic) modules - without copying them. Therefore, no race condition can happen when multiple tests that require modules of test frameworks are compiling or executing in parallel.
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comments

One whitespace suggestion

src/share/classes/com/sun/javatest/regtest/exec/Action.java line 525:

> 523:                 getModule(element, results);
> 524:             }
> 525:             else if (Files.isDirectory(element)) {

nit: `} else`

-------------

Marked as reviewed by jjg (Lead).

PR Review: https://git.openjdk.org/jtreg/pull/161#pullrequestreview-1545861478
PR Review Comment: https://git.openjdk.org/jtreg/pull/161#discussion_r1273781308


More information about the jtreg-dev mailing list