RFR: 7903499: Update various versions used by jtreg's IDEA plugin
Marc Philipp
duke at openjdk.org
Wed Jun 28 07:31:28 UTC 2023
On Sat, 10 Jun 2023 18:00:16 GMT, Christoph <duke at openjdk.org> wrote:
> This enables building the plugin with never java versions
>
> I tested with IntelliJ 2023.1.2 and java 17 and 19
>
> Plugin still works
As far as I can tell the `javaLevel` property is currently only used to configure the source/target compatibility of Java compile tasks:
https://github.com/openjdk/jtreg/blob/4b756c42fb9c06bcffe5e6de2312b787d4c9a6f2/plugins/idea/build.gradle#L14-L17
Instead, the `options.release` option should be used since `-source` and `-target` are deprecated IIRC.
> I wonder if we can apply something similar to [junit-team/junit5@`649c9a8`/gradle/plugins/settings.gradle.kts#L1-L5](https://github.com/junit-team/junit5/blob/649c9a85fe99087cca9335f3b4cd8024750695c9/gradle/plugins/settings.gradle.kts#L1-L5) in order to enforce a suitable Java version? /cc @marcphilipp
That concerns the version of Java the build is running with which doesn't necessarily have to be the same that is used for compilation. In JUnit we mainly restrict the version the build runs with to ensure a version of Java that is supported by Gradle is used and to benefit from Gradle's build cache across different machines. If everyone used a different major version of Java, that would result in different cache keys.
-------------
PR Comment: https://git.openjdk.org/jtreg/pull/157#issuecomment-1610910282
More information about the jtreg-dev
mailing list