RFR: 7903781: Report the process id of the agent or other VM that was used for a jtreg action [v2]

[Jaikiran Pai]

On Thu, 15 Aug 2024 22:03:35 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   include a self test for verifying the process id in the generated report
>
> src/share/classes/com/sun/javatest/regtest/exec/Agent.java line 581:
> 
>> 579:     /**
>> 580:      * Returns the process id of the {@code AgentServer} with which this {@code Agent}
>> 581:      * communicates. Returns {@code -1} if the process id of the {@code AgentServer}
> 
> As a matter of style, it is better if the first sentence is "complete", so I suggest changing ". Returns" to " or ".
> 
> 
>       * Returns the process id of the {@code AgentServer} with which this {@code Agent}
>       * communicates or {@code -1} if the process id of the {@code AgentServer}
>       * couldn't be determined.

Done. I've updated the PR to use your suggested text.

> src/share/classes/com/sun/javatest/regtest/util/ProcessUtils.java line 58:
> 
>> 56:             pidMethod = null;
>> 57:         }
>> 58:         PID_METHOD = pidMethod;
> 
> These two blocks of code are functionally similar but stylistically different in the names used.
> I suggest making them similar, perhaps changing to use DESTROY_FORCIBLY_METHOD.

That makes sense - I've renamed that field to this suggested name.

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/215#discussion_r1721198536
PR Review Comment: https://git.openjdk.org/jtreg/pull/215#discussion_r1721198721