Integrated: 7901757: Race in counting total number of failures from TestNG

[Jaikiran Pai]

On Fri, 26 Jul 2024 09:52:40 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to fix the issue noted in https://bugs.openjdk.org/browse/CODETOOLS-7901757?
> 
> As noted there, the current implementation in jtreg's testng test listener doesn't take into account that the callback methods on that listener instance can be invoked concurrently for different threads. As a result, the count tracking logic in the listener ends up in a race condition which results in reporting incorrect numbers.
> 
> The commit in this PR fixes that issue and introduces a self test which reproduces the race issue and verifies the fix. The new test and existing tests continue to pass with this change.

This pull request has now been integrated.

Changeset: 3750f096
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jtreg/commit/3750f09675011ff237a65b1c623507e83d17796f
Stats:     122 lines in 4 files changed: 103 ins; 9 del; 10 mod

7901757: Race in counting total number of failures from TestNG

Reviewed-by: cstein, jjg

-------------

PR: https://git.openjdk.org/jtreg/pull/216