RFR: 7903785: Improve reporting for skipped tests [v2]

Jonathan Gibbons jjg at openjdk.org
Wed Aug 28 19:45:31 UTC 2024


On Wed, 28 Aug 2024 10:45:24 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Jonathan Gibbons has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - fix whitespace
>>  - update with improved reporting for all not-run tests
>
> test/basic/ReportOnlyTest.gmk line 29:
> 
>> 27: 
>> 28: ifdef HEADLESS
>> 29: REPORT_EXPECT_PASS = 91
> 
> Suggestion:
> 
> REPORT_EXPECT_PASS = 92
> 
> 
> At least on GHA there seem to be 92 tests in `ReportOnlyTest.gmk` that pass in `HEADLESS=1` mode.
> 
> Note that the entire `test` suite then ends with on GHA:
> 
> [...]
> All (220) selected tests completed successfully
> Warning: JDK8HOME not set; some tests may not have been executed
> Warning: JDK9HOME not set; some tests may not have been executed
> Warning: JDK10HOME not set; some tests may not have been executed
> Warning: JDK14HOME not set; some tests may not have been executed
> Warning: JDK18HOME not set; some tests may not have been executed
> Warning: HEADLESS is set; some tests may not have been executed

I'll have to check your suggested change; my recollection is that all tests passed when run locally.

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/217#discussion_r1735203763


More information about the jtreg-dev mailing list