RFR: 7903785: Improve reporting for skipped tests [v3]

[Ivan Bereziuk]

On Wed, 28 Aug 2024 23:09:49 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> This is to support the ability to track `skipped` tests in the JDK `make test` system.
>> 
>> It is somewhere between "proof of concept", "draft PR", and initial version of a real PR.
>> 
>> The primary goal is to post the number of `skipped` tests in a backwards compatible way that does not break existing makefile rules or require any changes.  The makefiles currently have some "fuzzy parsing" to search for named values that may appear on the `Test results:` line near the end of the `jtreg` output to the console.   This PR _adds_ a new value to that line _without changing any existing values_. In particular, the `passed` value is unchanged and continues to include the `skipped` tests, as before, but for readers and tools alike, the number of skipped tests is also reported.
>> 
>> The PR also exposes a previously undocumented feature, to control the formatting of that line, using a format string that can be given to `jtreg` in a system property. The set of format specifiers in that string has been extended to include format specifiers for "skipped tests" and "passed tests, excluding skipped tests".
>> 
>> In exposing that feature, some design questions come to mind:
>> * the terminology of "ignored" tests is somewhat confusing -- it is about tests that were not selected by virtue of the keyword filter (and related `-k` option)
>> * if the number of `skipped` tests is interesting, there are other similar numbers that might also be interesting, such as the number of tests that were filtered out by a `@requires` tag -- which is similar to but more powerful than the keyword filter. But these extra numbers are contained within a composite filter, and may not have been so easily accessible when `jtreg` was built using older versions of JDK -- that is, before covariant returns.
>> * the `conditional space` and `conditional comma` provided as format specifiers do not work as well as intended if there is a plain-text label at the beginning of the format string.
>> 
>> But to summarize, this feature is primarily about reporting the number of `skipped` tests. We can either defer supporting additional values until a subsequent PR, or put more work into this PR to expose more of these "interesting" numbers.
>
> Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
> 
>  - Merge with upstream/master
>  - fix whitespace
>  - update with improved reporting for all not-run tests
>  - CODETOOLS-7903785: Improve reporting for skipped tests

Would it be possible to generate a report for every test which was skipped? I am not sure if that's already possible or will be possible with this change. It's likely out of scope.
But it would be nice to know your thoughts.

src/share/doc/javatest/regtest/faq.md line 961:

> 959: _error_
> 960: :   The number of tests that were executed and which indicated that an error
> 961:     occurred bedfore it could be determined whether the test passed or failed.

Suggestion:

    occurred before it could be determined whether the test passed or failed.

Probably a typo.

-------------

PR Review: https://git.openjdk.org/jtreg/pull/217#pullrequestreview-2272004782
PR Review Comment: https://git.openjdk.org/jtreg/pull/217#discussion_r1738459597