RFR: 7903883: --verify-exclude test existence and format checks are broken [v3]
Jaikiran Pai
jpai at openjdk.org
Mon Dec 16 14:25:09 UTC 2024
On Mon, 16 Dec 2024 14:21:53 GMT, Ludvig Janiuk <lujaniuk at openjdk.org> wrote:
>> The way this feature selected "the full set of tests" was actually getting "the set of tests to be run". But often, we run some subset through either specifying test files, folders, or groups. Our problemlist files will still have entries for other tests we were not running right now.
>>
>> As a solution, --verify-exclude needs to compute the maximal set of tests that could be run for all test suites that any of the tests being run are a part of. I've implemented this by creating a dummy testmanager and passing no parameters to it.
>>
>> Additionally, the regex for problemlist format had a typo.
>
> Ludvig Janiuk has updated the pull request incrementally with one additional commit since the last revision:
>
> Exists typo
Marked as reviewed by jpai (Reviewer).
-------------
PR Review: https://git.openjdk.org/jtreg/pull/236#pullrequestreview-2506330049
More information about the jtreg-dev
mailing list