RFR: 7903658 Document build/make.sh

Jonathan Gibbons jjg at openjdk.org
Thu Feb 15 16:25:04 UTC 2024


On Mon, 12 Feb 2024 09:10:18 GMT, Ludvig Janiuk <lujaniuk at openjdk.org> wrote:

> Add a note in building.md about build/make.sh, explaning that you can use it to rebuild faster.

Thanks for this; this is good for now.

It would be tweak to tweak the script the remember the MAKE_ARGS but still allow them to be overridden. And then we should document that.

doc/building.md line 45:

> 43: ### Rebuilding faster with `build/make.sh`
> 44: 
> 45: After you have run `build.sh` once, if you wish to rebuild after making some 

Suggest giving the full path for `make/build.sh`

doc/building.md line 47:

> 45: After you have run `build.sh` once, if you wish to rebuild after making some 
> 46: changes, you can run `build/make.sh` which should be significantly faster.
> 47: 

Suggest: 


you can just run `build/make.sh`, which skips the steps to download and build the dependencies, 
and so should be significantly faster.

-------------

Marked as reviewed by jjg (Lead).

PR Review: https://git.openjdk.org/jtreg/pull/182#pullrequestreview-1883263179
PR Review Comment: https://git.openjdk.org/jtreg/pull/182#discussion_r1491267162
PR Review Comment: https://git.openjdk.org/jtreg/pull/182#discussion_r1491272119


More information about the jtreg-dev mailing list