RFR: 7903580: Allow for re-attempting agent creation when an attempt fails [v7]

[Jaikiran Pai]

On Fri, 19 Jan 2024 23:14:53 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address review comments in faq
>
> src/share/classes/com/sun/javatest/regtest/exec/Agent.java line 93:
> 
>> 91:     static final boolean showAgent = Flags.get("showAgent");
>> 92:     static final boolean traceAgent = Flags.get("traceAgent");
>> 93: 
> 
> (minor) suggest adding a comment that this is to allow running `jtreg` on older JDKs that do not support the `pid` method.

Done - I've updated the PR to include a code comment for this line.

> src/share/doc/javatest/regtest/faq.md line 714:
> 
>> 712: This default behaviour can be overridden by passing the `--agent-attempts` option
>> 713: to `jtreg` command. This option takes an integer value which represents the number
>> 714: of attempts JTReg is allowed to make when attempting to get a agent for a test
> 
> (minor) remove `JTReg is allowed` so that it reads "the number of attempts to make..."

Done, updated the PR to remove that part.

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/173#discussion_r1460109855
PR Review Comment: https://git.openjdk.org/jtreg/pull/173#discussion_r1460109556