RFR: 7902346: Need better message when test times out in agentvm mode

[Mark Sheppard]

On Mon, 10 Jun 2024 07:16:49 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to improve the error message when a test action times out on an agent VM? This addresses https://bugs.openjdk.org/browse/CODETOOLS-7902346.
> 
> Before this change, whenever a test action timed out in an agentvm, then it would be reported as:
> 
>> result: Error. Agent error: java.lang.Exception: Agent 3 timed out with a timeout of 1200 seconds; check console log for any additional details 
> 
> With the changes in this PR, the error reporting will be a more accurate and won't give an impression that this was some error within the jtreg agent implementation. For `@run main ...`, the error will now say:
> 
>> result: Error. "main" action timed out with a timeout of 1200 seconds on agent 3
> 
> Another example, this time for a driver action:
> 
>> result: Error. "driver" action timed out with a timeout of 1200 seconds on agent 3
> 
> A couple of new self tests have been added to verify this change. Self tests including this new one continue to pass with this change.

Here's my tuppence worth.
I think the existing  message is reasonable clear as it indicates that the test being executed by the agentvm i.e. the AgenetServer, has failed to complete in the expected jtreg time frame
The newer message add additional ambiguity as it is not the main action that causes the timeout but some problem within the test e.g. a UDP socket receive or a test thread that has not completed and been reaped successfully.

I think amending the exist message with a little guidance would be preferable, for example,

result: Error. Agent error: java.lang.Exception: Agent 3 timed out with a timeout of 1200 seconds; check console log for any additional details and process capture in process.html

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/205#issuecomment-2202683248