RFR: 7903188: Log time spent waiting to acquire exclusive access lock [v2]

[Jonathan Gibbons]

On Thu, 20 Jun 2024 14:06:08 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> src/share/classes/com/sun/javatest/regtest/config/RegressionTestSuite.java line 226:
>> 
>>> 224:      */
>>> 225:     @Deprecated
>>> 226:     public boolean needsExclusiveAccess(TestDescription td) throws TestSuite.Fault {
>> 
>> This already existing `throws TestSuite.Fault` is actually unnecessary because nothing in that logic throws that checked exception. However, I decided not to change this method signature since that can cause compatibility issue - I'm guessing this `com.sun.javatest.regtest.config.RegressionTestSuite` is a public API?
>> That's why I decided to introduce a new `isExclusiveAccessRequired` method which doesn't throw the checked exception.
>
> I am not aware of any consumer of `RegressionTestSuite` - is there, @jonathan-gibbons ?

`RegressionTestSuite` is a mostly-private implementation of a public interface `TestSuite`.
"mostly private" means that there are probably no other uses of the class. Maybe at one point I thought there might be.

I also suspect this might be a historical leftover from times past, when access to the underlying properties might have been more lazy.

At any rate, any clients of `RegressionTestSuite` would be "friends" and should be willing to tolerate change. There is no published commitment to the stability of these internal classes.

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/208#discussion_r1663303210