RFR: 7903188: Log time spent waiting to acquire exclusive access lock [v2]

Jaikiran Pai jpai at openjdk.org
Wed Jul 3 03:56:58 UTC 2024


On Tue, 2 Jul 2024 23:41:56 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   A more cleaner fix - let the Action class dealing with acquiring and releasing locks and printing the wait duration
>
> src/share/classes/com/sun/javatest/regtest/config/RegressionTestSuite.java line 220:
> 
>> 218:     /**
>> 219:      * @param td the test description
>> 220:      * {@return true if the test is configured to run exclusively, false otherwise}
> 
> This is in the wrong place.
> As written, the inline tag `{@return...}` is part of the description of the preceding block tag `@param`
> 
> When using the inline form of the `return` tag, it should appear at the beginning of the description.

Hello Jon, I wasn't aware of this. I've now moved the `{@return}` to place it before the `@param`.

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/208#discussion_r1663448125


More information about the jtreg-dev mailing list