RFR: 7902346: Need better message when test times out in agentvm mode

[Mark Sheppard]

On Mon, 10 Jun 2024 07:16:49 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to improve the error message when a test action times out on an agent VM? This addresses https://bugs.openjdk.org/browse/CODETOOLS-7902346.
> 
> Before this change, whenever a test action timed out in an agentvm, then it would be reported as:
> 
>> result: Error. Agent error: java.lang.Exception: Agent 3 timed out with a timeout of 1200 seconds; check console log for any additional details 
> 
> With the changes in this PR, the error reporting will be a more accurate and won't give an impression that this was some error within the jtreg agent implementation. For `@run main ...`, the error will now say:
> 
>> result: Error. "main" action timed out with a timeout of 1200 seconds on agent 3
> 
> Another example, this time for a driver action:
> 
>> result: Error. "driver" action timed out with a timeout of 1200 seconds on agent 3
> 
> A couple of new self tests have been added to verify this change. Self tests including this new one continue to pass with this change.

As an extensive user of this error and its implications, I have to disagree with Jonathon on this. I don't think that the additions in their current form assist in the diagnosis of a failure. They are even more obscure than the Agent error message It is not a jtreg failure per se, it a failure of a test to execute in a timely manner. 

Providing an error or exception message that indicates main action or driver action doesn't help in the diagnosis. 

Knowing the Agent/AgentServer relationship and conveying that a timeout on test completion has occurred is important. Also, providing guidance on where to look for further details i.e. to look in process capture (process.html), would be helpful

-------------

PR Comment: https://git.openjdk.org/jtreg/pull/205#issuecomment-2205784616