RFR: 7903775: Add LIBRARY.properties
Jonathan Gibbons
jjg at openjdk.org
Fri Jul 12 18:47:03 UTC 2024
On Thu, 11 Jul 2024 08:05:16 GMT, Christian Stein <cstein at openjdk.org> wrote:
> Initial implementation adding support for `LIBRARY.properties`.
Marked as reviewed by jjg (Lead).
src/share/classes/com/sun/javatest/regtest/exec/BuildAction.java line 309:
> 307: if (libLocn.isLibrary()) {
> 308: try {
> 309: var properties = LibraryProperties.of(libLocn);
The `Locations` class would be a good place to cache the `LibraryProperties` object for a `LibLocn`
src/share/classes/com/sun/javatest/regtest/exec/CompileAction.java line 425:
> 423: return script.locations.getLibs().stream()
> 424: .filter(LibLocn::isLibrary)
> 425: .map(LibraryProperties::of) // cache library properties object in LibLocn ?
Re: comment -- indeed!
-------------
PR Review: https://git.openjdk.org/jtreg/pull/212#pullrequestreview-2175532058
PR Review Comment: https://git.openjdk.org/jtreg/pull/212#discussion_r1676335329
PR Review Comment: https://git.openjdk.org/jtreg/pull/212#discussion_r1676335812
More information about the jtreg-dev
mailing list