RFR: 7903741: some test properties are not documented

Iris Clark iris at openjdk.org
Fri Jun 7 01:04:23 UTC 2024


On Thu, 6 Jun 2024 21:35:06 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple doc and test update for tag-spec.html, after it was recently noted that `test.module.path` was available but not documented.
> 
> The new test verifies 1:1 correspondence between names that are available, as env vars or system properties, and those that are documented.

Marked as reviewed by iris (Reviewer).

src/share/doc/javatest/regtest/tag-spec.html line 1247:

> 1245: <td><i>Not Available</i>
> 1246: <td>The name of the test, formed from the defining file of the test
> 1247: and any corresponding id if the file contains many separate test

maybe "multiple" or "more than one" instead of "many".  "Many" implies an undefined threshold.

test/tag-spec/TestTagSpec.gmk line 45:

> 43: 		$(JAVAFILES.com.sun.javatest.regtest-tools)
> 44: 	$(GREP) -oh '\(.put(\|put(map, \)"test.[^"]*' $(JAVAFILES.com.sun.javatest.regtest-tools) | \
> 45: 		$(GREP) -v "test.class.path.prefix" | \

Why do we want to ignore this sysprop?  It's not defined in the tag spec, but why is it defined... convenience?

-------------

PR Review: https://git.openjdk.org/jtreg/pull/203#pullrequestreview-2103428191
PR Review Comment: https://git.openjdk.org/jtreg/pull/203#discussion_r1630461591
PR Review Comment: https://git.openjdk.org/jtreg/pull/203#discussion_r1630470747


More information about the jtreg-dev mailing list