RFR: 7903730: Enhance the agentvm to be tolerant to unexpected connection on the port the Agent listens on for handshake with the AgentServer [v3]

[Jaikiran Pai]

On Thu, 23 May 2024 13:34:41 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   reduce the scope of the try/catch and fix potential short read() issue
>
> src/share/classes/com/sun/javatest/regtest/exec/Agent.java line 153:
> 
>> 151:             // We allow for some unexpected processes to connect to the port we listen on.
>> 152:             // We discard such connections if, after connecting, our internal handshake fails.
>> 153:             final int maxAcceptAttempts = 3;
> 
> this is effectively a constant -- maybe have it as a private static final MAXACCEPTATTEMPTS = 3;

Done. I've now moved this to a `private static final` field.

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/195#discussion_r1631068807