RFR: 7903753: Report duration of testng test methods [v2]

[Christian Stein]

On Thu, 13 Jun 2024 14:00:46 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to print the duration for each of the testng test methods? This addresses https://bugs.openjdk.org/browse/CODETOOLS-7903753.
>> 
>> Similar to https://github.com/openjdk/jtreg/pull/206, which does this for junit tests, the commit in this PR includes the duration for each test method as follows:
>> 
>> 
>> test LargeEntriesTest.testForceZIP64End(java.util.ImmutableCollections$MapN at 1398b884, 8): success [141ms]
>> test LargeEntriesTest.testForceZIP64End(java.util.ImmutableCollections$MapN at 1caef225, 0): success [5ms]
>> test LargeEntriesTest.testForceZIP64End(java.util.ImmutableCollections$MapN at 2a2df4a5, 8): success [4ms]
>> test LargeEntriesTest.testForceZIP64End(java.util.ImmutableCollections$MapN at 85ce7c1, 0): success [3ms]
>> test LargeEntriesTest.testJar({create=true}, 8): success [5121ms]
>> test LargeEntriesTest.testJar(java.util.ImmutableCollections$MapN at 34771e2b, 0): success [3029ms]
>> test LargeEntriesTest.testJar(java.util.ImmutableCollections$MapN at 27fb5d9f, 8): success [4333ms]
>> test LargeEntriesTest.testZip({create=true}, 8): success [3944ms]
>> test LargeEntriesTest.testZip(java.util.ImmutableCollections$MapN at 62272fdb, 0): success [2638ms]
>> test LargeEntriesTest.testZip(java.util.ImmutableCollections$MapN at 6f1bd253, 8): success [4138ms]
>> 
>> 
>> A new self test has been introduced to verify this change and an existing self test had to be updated to allow for the presence of the duration in the text output. All self tests including the new one continue to pass with these changes.
>
> Jaikiran Pai has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - update copyright year
>  - don't rely on testng's duration reporting instead use System.nanoTime() in listeners to track duration

src/share/classes/com/sun/javatest/regtest/agent/TestNGRunner.java line 118:

> 116:         // keeps track of the test start time for each test
> 117:         private final Map<ITestResult, Long> startTimeNanos =
> 118:                 Collections.synchronizedMap(new IdentityHashMap<>());

Why didn't you use `java.util.concurrent.ConcurrentHashMap` here?

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/207#discussion_r1639501180