RFR: 7903188: Log time spent waiting to acquire exclusive access lock

Jaikiran Pai jpai at openjdk.org
Wed Jun 19 09:42:44 UTC 2024


Can I please get a review of this change which proposes to implement the enhancement requested in https://bugs.openjdk.org/browse/CODETOOLS-7903188?

jtreg supports the ability to sequentially execute tests, instead of concurrently, for tests belonging to a pre-configured `exclusiveAccess.dirs` directory. The `MainAction` and `ShellAction` before launching the test, first acquire a lock. The lock acquisition can be time consuming and depends on how long an already running test from that directory takes to complete. This lock acquisiton time isn't reported anywhere in the jtreg action's `section` in the report. Because of this, it sometimes makes it difficult to determine where the unaccounted time is spent.

The change in this PR prints out how long it took to acquire a exclusive access before launching the test. It's only printed if the test was configured with exclusiveAccess. The reported message will look like:


#section:main
----------messages:(7/230)----------
command: main Test
reason: User specified action: run main Test 
started: Wed Jun 19 14:45:21 IST 2024
exclusiveAccess wait time (seconds): 20.289
Mode: othervm
finished: Wed Jun 19 14:45:21 IST 2024
elapsed time (seconds): 0.123


An existing self test has been updated to verify this change. All existing tests continue to pass with this change.

-------------

Commit messages:
 - 7903188: Log time spent waiting to acquire exclusive access lock

Changes: https://git.openjdk.org/jtreg/pull/208/files
  Webrev: https://webrevs.openjdk.org/?repo=jtreg&pr=208&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903188
  Stats: 64 lines in 5 files changed: 54 ins; 0 del; 10 mod
  Patch: https://git.openjdk.org/jtreg/pull/208.diff
  Fetch: git fetch https://git.openjdk.org/jtreg.git pull/208/head:pull/208

PR: https://git.openjdk.org/jtreg/pull/208


More information about the jtreg-dev mailing list