RFR: 7903188: Log time spent waiting to acquire exclusive access lock [v2]
Christian Stein
cstein at openjdk.org
Thu Jun 20 14:11:22 UTC 2024
On Thu, 20 Jun 2024 10:42:09 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>>
>> A more cleaner fix - let the Action class dealing with acquiring and releasing locks and printing the wait duration
>
> src/share/classes/com/sun/javatest/regtest/config/RegressionTestSuite.java line 226:
>
>> 224: */
>> 225: @Deprecated
>> 226: public boolean needsExclusiveAccess(TestDescription td) throws TestSuite.Fault {
>
> This already existing `throws TestSuite.Fault` is actually unnecessary because nothing in that logic throws that checked exception. However, I decided not to change this method signature since that can cause compatibility issue - I'm guessing this `com.sun.javatest.regtest.config.RegressionTestSuite` is a public API?
> That's why I decided to introduce a new `isExclusiveAccessRequired` method which doesn't throw the checked exception.
I am not aware of any consumer of `RegressionTestSuite` - is there, @jonathan-gibbons ?
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/208#discussion_r1647640381
More information about the jtreg-dev
mailing list