RFR: 7903659 Verify Problemlist contents [v4]

Jonathan Gibbons jjg at openjdk.org
Fri Mar 8 19:13:04 UTC 2024


On Fri, 8 Mar 2024 16:07:57 GMT, Ludvig Janiuk <lujaniuk at openjdk.org> wrote:

>> src/share/classes/com/sun/javatest/regtest/tool/Tool.java line 646:
>> 
>>> 644:         },
>>> 645: 
>>> 646:         new Option(NONE, MAIN, null, "-ve", "-verifyexclude") {
>> 
>> I might have gone for `--verify-exclude` but this is OK
>
> I also find `--verify-exclude` more pleasing, but for reasons unknown to me, all the existing jtreg flags use a single dash even for the long versions. The majority also seem to concatenate words with no separator, although there are examples of both kebab-case and camelCase. For these reasons, I would opt for the flag as it is written.

The existing options are all "very old" and the style goes all the way back to the beginning of java-time, in the mid 90s. We have started using the double-dash form for recent options, especially where like-named options appear in other tools -- most notably `--class-path` etc.

When we started introducing the double-dash form in JDK 9 ([JEP 293](https://openjdk.org/jeps/293)) there was general agreement that we should not go back and "gratuitously" update existing old-form options. But equally, there was also general agreement to use the new double-dash form for new options.

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/181#discussion_r1518181786


More information about the jtreg-dev mailing list