RFR: 7903683 Document how to run individual self-tests [v2]
Ludvig Janiuk
lujaniuk at openjdk.org
Mon Mar 11 16:33:00 UTC 2024
On Mon, 11 Mar 2024 13:00:32 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Ludvig Janiuk has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - typo
>> - typos
>> - update with pointer to test/README
>
> doc/building.md line 113:
>
>> 111: ```
>> 112: bash build/make.sh -- $(pwd)/build/test/ControlTest.ok
>> 113: ```
>
> Hello Ludvig, I think the idea of documenting this is a good one. I myself struggled to find a way to run individual tests until I saw your PR.
>
> As for the proposed text, I think it will still leave open a lot of questions - like, how does one find the right `.ok` target to pass to this command. The answer to that already resides in https://github.com/openjdk/jtreg/blob/master/test/README.md#makefiles. I think as part of the current proposed change, we may have to include a pointer to that other file to provide context about the `.ok` target or maybe just migrate that README.md file contents into this building.md file.
Thanks for the suggestion, I didn't know about that file! I've added a pointer and also borrowed the formulation from there, it sounded better IMO.
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/184#discussion_r1519864876
More information about the jtreg-dev
mailing list