RFR: 7903683 Document how to run individual self-tests [v3]

Ludvig Janiuk lujaniuk at openjdk.org
Thu Mar 14 15:17:05 UTC 2024


On Thu, 14 Mar 2024 13:58:08 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Thanks for the suggestion, I didn't know about that file! I've added a pointer and also borrowed the formulation from there, it sounded better IMO.
>
> Hello Ludvig, this looks better to me. To make it much more clear, I was thinking of something like this:
> 
> 
> diff --git a/doc/building.md b/doc/building.md
> index 931a519..846b955 100644
> --- a/doc/building.md
> +++ b/doc/building.md
> @@ -107,7 +107,15 @@ of the `legal` directory in the generated image.
>  ## Running `jtreg` Self-Tests
>  
>  The tests can be invoked with individual make targets, or collectively via the
> -`test` target.
> +`test` target. Individual make targets for self-tests are explained
> +[here](../test/README.md#makefiles). For example, the
> +[ControlTest.gmk](../test/ctrl/ControlTest.gmk) makefile has a `$(BUILDTESTDIR)/ControlTest.ok`
> +target which runs one of the self-tests. In order to run that individual test, use the following
> +command:
> +
> +```shell
> +bash build/make.sh -- $(pwd)/build/test/ControlTest.ok
> +```
> 
> 
> If you prefer to use your current version, that's fine too.

I like your version because the technical details are more explicit.

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/184#discussion_r1525057035


More information about the jtreg-dev mailing list