RFR: 7903693 Add contribution guidelines section [v2]
Ludvig Janiuk
lujaniuk at openjdk.org
Mon Mar 18 17:07:52 UTC 2024
On Thu, 14 Mar 2024 23:19:03 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> Ludvig Janiuk has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - x
>> - x
>> - final touches
>
> doc/building.md line 150:
>
>> 148: One notable exception is the rule about case-sensitivity - jtreg's command line
>> 149: flags are case insensitive and due to backwards compatibility it seems
>> 150: reasonable to keep this going forward.
>
> Generally, it is good practice to not use time-dependent text, like "going forward", in any spec.
>
> I would replace the entire 148-150 lines with,
>
> For backwards compatibility, `jtreg` option names are case-insensitive.
Good advice, I've adopted this language.
-------------
PR Review Comment: https://git.openjdk.org/jtreg/pull/192#discussion_r1528942029
More information about the jtreg-dev
mailing list