RFR: 7903659 Verify Problemlist contents [v6]

[Ludvig Janiuk]

On Tue, 12 Mar 2024 11:06:20 GMT, Ludvig Janiuk <lujaniuk at openjdk.org> wrote:

>> The code might work "by accident", but is for sure not how it is meant to be.
>> 
>> There are two parts to this expression:
>> 1. `$(@:%.ok=%/log)`. This is an expression to generate a string from `$@` by replacing the trailing `.ok` with `/log` -- in other words, based on the name of the target `$@` generate a related name for the log file
>> 2. `2>&1`. This is plain old shell redirection, and should be directly on the `grep` command line, and not hidden in. the `$(@:...)` expression.
>
> I'll change it here. I found some other files with the same pattern:
> 
> 
> test/exclude/ExcludeTest.gmk
> test/ignoresymbolfile/IgnoreSymbolFileTest.gmk
> test/junit/JUnitLibTest.gmk
> test/libBuildArgs/LibBuildArgsTest.gmk
> test/libdirs/LibDirsTest.gmk
> test/match/MatchTest.gmk
> test/testng/TestNGLibTest.gmk
> test/testprops/TestPropsTest.gmk
> test/versionCheck/TestVersionCheck.gmk
> 
> I think the earliest change introducing it is https://github.com/openjdk/jtreg/commit/c980056e6dc98cccf4c90a76204f17cb83d75e1d
> which is a big change. The message only refers to [https://blogs.oracle.com/jjg/entry/jtreg_update_november_2012](https://blogs.oracle.com/jjg/entry/jtreg_update_november_2012) which is a dead link. Searching around a bit, I found https://openjdk.org/jtreg/resources.html, which contains many similar dead links. 
> 
> for the historical context, can those updates be found somewhere and if so could the links be updated?
> 
> for this change, I'll submit a change of those test in a separate MR.

I've created https://bugs.openjdk.org/browse/CODETOOLS-7903699 to track the other occurrences.

-------------

PR Review Comment: https://git.openjdk.org/jtreg/pull/181#discussion_r1535817658